Skip to content

Commit f546618

Browse files
author
jlorich
committed
Merge pull request #83 from cloudspace/sort_by_published
Make default sort published_at
2 parents 2701f2b + 18f0861 commit f546618

57 files changed

Lines changed: 23947 additions & 28081 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

EasyReader.xcodeproj/project.pbxproj

Lines changed: 1931 additions & 6071 deletions
Large diffs are not rendered by default.

EasyReader/Application/Models/FeedItem.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ - (NSString *)feedName
3737

3838
- (NSString *)headline
3939
{
40-
NSString *timeAgo = [self.updatedAt timeAgo];
4140
NSString *feedName = self.feed.name;
41+
NSString *timeAgo = self.publishedAt ? [self.publishedAt timeAgo] : [self.updatedAt timeAgo];
42+
4243

4344
if (feedName.length > 30) {
4445
feedName = [[feedName substringToIndex:30] stringByAppendingString:@"..."];

EasyReader/Application/Services/EZRCurrentFeedsProvider.m

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ - (instancetype) init
7676
_feeds = [self.currentUser.feeds sortedArrayByAttributes:@[@"name"]
7777
ascending:[self nameSortDirection]];
7878

79-
_feedItems = [self.currentUser.feedItems sortedArrayByAttributes:@[@"createdAt"]
80-
ascending:[self createdAtSortDirection]];
79+
_feedItems = [self sorted:self.currentUser.feedItems];
8180
_visibleFeedItems = _feedItems;
8281

8382
[[NSNotificationCenter defaultCenter] addObserver:self
@@ -110,8 +109,7 @@ - (void)selectedFeedDidChange:(NSNotification *)notification
110109
[self willChangeValueForKey:@"visibleFeedItems"];
111110

112111
if (feed) {
113-
_visibleFeedItems = [feed.feedItems sortedArrayByAttributes:@[@"createdAt"]
114-
ascending:[self createdAtSortDirection]];
112+
_visibleFeedItems = [self sorted:feed.feedItems];
115113
currentFeed = feed;
116114
} else {
117115
_visibleFeedItems = _feedItems;
@@ -166,8 +164,7 @@ - (void) userFeedsDidChange:(User *)currentUser oldFeeds:(NSSet *)oldFeeds newFe
166164
_feeds = [newFeeds sortedArrayByAttributes:@[@"name"]
167165
ascending:[self nameSortDirection]];
168166

169-
_feedItems = [feedItems sortedArrayByAttributes:@[@"createdAt"]
170-
ascending:[self createdAtSortDirection]];
167+
_feedItems = [self sorted:feedItems];
171168

172169
if (!currentFeed) {
173170
_visibleFeedItems = _feedItems;
@@ -203,22 +200,30 @@ - (void)observeFeedItemsForFeeds:(NSArray *)feeds {
203200
[self willChangeValueForKey:@"visibleFeedItems"];
204201
[self willChangeValueForKey:@"feedItems"];
205202

206-
_feedItems = [self.currentUser.feedItems sortedArrayByAttributes:@[@"createdAt"]
207-
ascending:[self createdAtSortDirection]];
203+
_feedItems = [self sorted:self.currentUser.feedItems];
208204

209205
if (!currentFeed) {
210206
_visibleFeedItems = _feedItems;
211207
} else {
212-
_visibleFeedItems = [currentFeed.feedItems sortedArrayByAttributes:@[@"createdAt"]
213-
ascending:[self createdAtSortDirection]];
208+
_visibleFeedItems = [self sorted:currentFeed.feedItems];
214209
}
215210

216211
[self didChangeValueForKey:@"feedItems"];
217212
[self didChangeValueForKey:@"visibleFeedItems"];
218213
};
219214
}
220215

221-
- (BOOL)createdAtSortDirection {
216+
- (NSArray *)sorted:(NSSet*)feedItems {
217+
return [feedItems sortedArrayByAttributes:[self feedItemSortAttributes]
218+
ascending:[self feedItemSortDirection]];
219+
}
220+
221+
- (NSArray *)feedItemSortAttributes
222+
{
223+
return @[@"publishedAt", @"createdAt"];
224+
}
225+
226+
- (BOOL)feedItemSortDirection {
222227
return NO;
223228
}
224229

EasyReader/Supporting Files/Production-Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
</dict>
4141
</array>
4242
<key>CFBundleVersion</key>
43-
<string>2.1</string>
43+
<string>2.2</string>
4444
<key>LSApplicationCategoryType</key>
4545
<string></string>
4646
<key>LSRequiresIPhoneOS</key>

0 commit comments

Comments
 (0)