Skip to content

Commit ac0f7fa

Browse files
author
Joey Lorich
committed
Work on moving relationships into the storyboards
1 parent 40b19b4 commit ac0f7fa

13 files changed

Lines changed: 101 additions & 168 deletions

EasyReader.xcodeproj/project.pbxproj

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -305,10 +305,6 @@
305305
9DFC326D18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFC326B18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m */; };
306306
9DFC326E18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFC326B18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m */; };
307307
9DFC326F18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFC326B18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m */; };
308-
9DFD89EA18FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFD89E918FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m */; };
309-
9DFD89EB18FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFD89E918FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m */; };
310-
9DFD89EC18FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFD89E918FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m */; };
311-
9DFD89ED18FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFD89E918FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m */; };
312308
9DFD89F618FC7D9300630CBF /* CSArrayTableViewDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFD89F518FC7D9300630CBF /* CSArrayTableViewDataSource.m */; };
313309
9DFD89F718FC7D9300630CBF /* CSArrayTableViewDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFD89F518FC7D9300630CBF /* CSArrayTableViewDataSource.m */; };
314310
9DFD89F818FC7D9300630CBF /* CSArrayTableViewDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 9DFD89F518FC7D9300630CBF /* CSArrayTableViewDataSource.m */; };
@@ -489,8 +485,6 @@
489485
9DFC326518FD7263008A2A44 /* EZRCurrentFeedsProvider.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = EZRCurrentFeedsProvider.m; sourceTree = "<group>"; };
490486
9DFC326A18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CSArrayCollectionViewDataSource.h; sourceTree = "<group>"; };
491487
9DFC326B18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CSArrayCollectionViewDataSource.m; sourceTree = "<group>"; };
492-
9DFD89E818FC66E800630CBF /* EZRHomeFeedImagePrefetcher.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = EZRHomeFeedImagePrefetcher.h; path = Home/EZRHomeFeedImagePrefetcher.h; sourceTree = "<group>"; };
493-
9DFD89E918FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = EZRHomeFeedImagePrefetcher.m; path = Home/EZRHomeFeedImagePrefetcher.m; sourceTree = "<group>"; };
494488
9DFD89F418FC7D9300630CBF /* CSArrayTableViewDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CSArrayTableViewDataSource.h; sourceTree = "<group>"; };
495489
9DFD89F518FC7D9300630CBF /* CSArrayTableViewDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CSArrayTableViewDataSource.m; sourceTree = "<group>"; };
496490
A7ACF08D0CD54248B25E110A /* libPods.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libPods.a; sourceTree = BUILT_PRODUCTS_DIR; };
@@ -798,8 +792,6 @@
798792
2751F4DB18DA0D3000339C96 /* FeedItemCollectionView */,
799793
2751F4D818DA0A6B00339C96 /* EZRHomeViewController.h */,
800794
2751F4D918DA0A6B00339C96 /* EZRHomeViewController.m */,
801-
9DFD89E818FC66E800630CBF /* EZRHomeFeedImagePrefetcher.h */,
802-
9DFD89E918FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m */,
803795
9D38DDD318EB08D600C67022 /* EZRHomeCollectionViewDelegate.h */,
804796
9D38DDD418EB08D600C67022 /* EZRHomeCollectionViewDelegate.m */,
805797
9D38DDEB18EB0A7600C67022 /* EZRHomeScrollViewDelegate.h */,
@@ -1407,7 +1399,6 @@
14071399
9D79270B18DA1D0300E1D3E1 /* EZRAppDelegate.m in Sources */,
14081400
9D79270C18DA1D0300E1D3E1 /* main.m in Sources */,
14091401
9D38DDD718EB08D600C67022 /* EZRHomeCollectionViewDelegate.m in Sources */,
1410-
9DFD89EC18FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m in Sources */,
14111402
9D79270D18DA1D0300E1D3E1 /* EZRHomeViewController.m in Sources */,
14121403
9D38DDE318EB090500C67022 /* EZRHomePageControlDelegate.m in Sources */,
14131404
9DFC326E18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m in Sources */,
@@ -1470,7 +1461,6 @@
14701461
9D79275118DA1D3800E1D3E1 /* EZRHomeViewController.m in Sources */,
14711462
9D79275218DA1D3800E1D3E1 /* EZRFeedItemCollectionView.m in Sources */,
14721463
9D79275318DA1D3800E1D3E1 /* NSObject+CSReflectionAdditions.m in Sources */,
1473-
9DFD89ED18FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m in Sources */,
14741464
9D38DDEA18EB091B00C67022 /* EZRHomePageControlDataSource.m in Sources */,
14751465
9D79275418DA1D3800E1D3E1 /* CSRemoteObject.m in Sources */,
14761466
9DFC326F18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m in Sources */,
@@ -1559,7 +1549,6 @@
15591549
9D9CBACD18DCC68A00532F8C /* EZRFeedItemCollectionView.m in Sources */,
15601550
9D639E7D18E0A53100350B5F /* APIMockResponse.m in Sources */,
15611551
9D9CBACE18DCC68A00532F8C /* NSObject+CSReflectionAdditions.m in Sources */,
1562-
9DFD89EB18FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m in Sources */,
15631552
9D38DDE818EB091B00C67022 /* EZRHomePageControlDataSource.m in Sources */,
15641553
9D9CBACF18DCC68A00532F8C /* CSRemoteObject.m in Sources */,
15651554
9DFC326D18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m in Sources */,
@@ -1622,7 +1611,6 @@
16221611
9DAC172E170A043200383722 /* main.m in Sources */,
16231612
2751F4DA18DA0A6B00339C96 /* EZRHomeViewController.m in Sources */,
16241613
2751F4E418DA0D3000339C96 /* EZRFeedItemCollectionView.m in Sources */,
1625-
9DFD89EA18FC66E800630CBF /* EZRHomeFeedImagePrefetcher.m in Sources */,
16261614
9D38DDE718EB091B00C67022 /* EZRHomePageControlDataSource.m in Sources */,
16271615
2751F4D718DA02C100339C96 /* NSObject+CSReflectionAdditions.m in Sources */,
16281616
9DFC326C18FD8CB8008A2A44 /* CSArrayCollectionViewDataSource.m in Sources */,
@@ -1805,7 +1793,7 @@
18051793
UIKit,
18061794
);
18071795
PRODUCT_NAME = Staging;
1808-
PROVISIONING_PROFILE = "AE75F2A8-B0F9-486D-8DE0-CFEA22EC508C";
1796+
PROVISIONING_PROFILE = "56017F00-F968-4F0C-8C2F-8CEFF1BE147E";
18091797
TARGETED_DEVICE_FAMILY = 1;
18101798
VALID_ARCHS = "armv7 arm64 armv7s";
18111799
WRAPPER_EXTENSION = app;

EasyReader/Application/Controllers/EZRHomeScrollViewDelegate.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,4 @@
1414
*/
1515
@interface EZRHomeScrollViewDelegate : NSObject <UIScrollViewDelegate>
1616

17-
/**
18-
* Initializes a new scroll view delegate for the given home view controller instance
19-
*
20-
* @param homeController The home view controller
21-
*/
22-
- (instancetype)initWithController:(EZRHomeViewController *)homeController;
23-
2417
@end

EasyReader/Application/Controllers/EZRHomeScrollViewDelegate.m

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,41 +8,46 @@
88

99
#import "EZRHomeScrollViewDelegate.h"
1010
#import "EZRHomeViewController.h"
11+
#import "EZRFeedItemCollectionView.h"
12+
13+
@interface EZRHomeScrollViewDelegate ()
14+
15+
@property (nonatomic, weak) IBOutlet EZRNestableWebView *webView_feedItem;
16+
17+
@property (nonatomic, weak) IBOutlet EZRFeedItemCollectionView *collectionView_feedItems;
18+
19+
@end
1120

1221
@implementation EZRHomeScrollViewDelegate
1322
{
14-
EZRHomeViewController *controller;
1523
NSString *currentURL;
1624
BOOL dragging;
1725
CGPoint dragStart;
1826
}
1927

20-
- (instancetype)initWithController:(EZRHomeViewController *)homeController
21-
{
28+
- (instancetype)init {
2229
self = [super init];
2330

2431
if (self) {
25-
controller = homeController;
2632
dragging = NO;
2733
}
2834

2935
return self;
3036
}
31-
3237
//
3338
- (void)scrollViewDidScroll:(UIScrollView *)scrollView {
3439
// Make scrolling back up to the top feel more natural
3540
if (scrollView.contentOffset.y == scrollView.frame.size.height) {
36-
if (controller.webView_feedItem.scrollView.contentOffset.y == 0) {
37-
controller.webView_feedItem.scrollView.contentOffset = CGPointMake(0, 1);
41+
if (self.webView_feedItem.scrollView.contentOffset.y == 0) {
42+
self.webView_feedItem.scrollView.contentOffset = CGPointMake(0, 1);
3843
}
3944
}
4045

4146
// Prevent collectionview scrolling when shar bar is showing
4247
if (scrollView.contentOffset.y < 0) {
43-
controller.collectionView_feedItems.userInteractionEnabled = NO;
48+
self.collectionView_feedItems.userInteractionEnabled = NO;
4449
} else {
45-
controller.collectionView_feedItems.userInteractionEnabled = YES;
50+
self.collectionView_feedItems.userInteractionEnabled = YES;
4651
}
4752

4853
// Don't allow drags from the share view to go past the base view without a stop

EasyReader/Application/Controllers/Home/EZRHomeCollectionViewDelegate.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,4 @@
1616
*/
1717
@interface EZRHomeCollectionViewDelegate : NSObject <UICollectionViewDelegate, EZRFeedItemCollectionViewCellDelegate>
1818

19-
/**
20-
* Initializes a collection view delegate for the given home view controller instance
21-
*
22-
* @param homeController The home view controller
23-
*/- (instancetype)initWithController:(EZRHomeViewController *)homeController;
24-
2519
@end

EasyReader/Application/Controllers/Home/EZRHomeCollectionViewDelegate.m

Lines changed: 21 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -17,31 +17,26 @@
1717
@interface EZRHomeViewController (Additions)
1818

1919
- (void)prefetchImagesNearIndex:(NSInteger)currentPageIndex count:(NSInteger)count;
20-
- (void)setCurrentFeedItem:(FeedItem *)item;
21-
- (void)setCurrentPageIndex:(NSInteger)index;
20+
21+
@end
22+
23+
24+
@interface EZRHomeCollectionViewDelegate ()
25+
26+
@property (nonatomic, weak) IBOutlet EZRHomeViewController *controller;
27+
28+
@property (nonatomic, weak) IBOutlet EZRFeedItemCollectionView *collectionView;
29+
30+
@property (nonatomic, weak) IBOutlet UIScrollView *scrollView_vertical;
2231

2332
@end
2433

2534

2635
@implementation EZRHomeCollectionViewDelegate
2736
{
28-
EZRHomeViewController *controller;
29-
EZRFeedItemCollectionView *collectionView;
3037
FeedItem *previousFeedItem;
3138
}
3239

33-
- (instancetype)initWithController:(EZRHomeViewController *)homeController
34-
{
35-
self = [super init];
36-
37-
if (self)
38-
{
39-
controller = homeController;
40-
collectionView = homeController.collectionView_feedItems;
41-
}
42-
43-
return self;
44-
}
4540

4641
/**
4742
* Fires when the collection view scrolls
@@ -51,20 +46,20 @@ - (instancetype)initWithController:(EZRHomeViewController *)homeController
5146
*/
5247
- (void)scrollViewDidScroll:(UIScrollView *)scrollView
5348
{
54-
FeedItem *currentFeedItem = collectionView.currentFeedItem;
55-
NSInteger pageIndex = collectionView.currentPageIndex;
49+
FeedItem *currentFeedItem = self.collectionView.currentFeedItem;
50+
NSInteger pageIndex = self.collectionView.currentPageIndex;
5651

57-
if (previousFeedItem != collectionView.currentFeedItem) {
58-
[controller resetWebView];
52+
if (previousFeedItem != self.collectionView.currentFeedItem) {
53+
[self.controller resetWebView];
5954

6055
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 0.5 * NSEC_PER_SEC), dispatch_get_main_queue(), ^{
61-
if (collectionView.currentFeedItem == currentFeedItem) {
62-
[controller loadURLForFeedItem:currentFeedItem];
56+
if (self.collectionView.currentFeedItem == currentFeedItem) {
57+
[self.controller loadURLForFeedItem:currentFeedItem];
6358
}
6459
});
6560

66-
[controller prefetchImagesNearIndex:pageIndex count:5];
67-
[controller.pageControl_itemIndicator setPageControllerPageAtIndex:pageIndex];
61+
[self.controller prefetchImagesNearIndex:pageIndex count:5];
62+
[self.controller.pageControl_itemIndicator setPageControllerPageAtIndex:pageIndex];
6863

6964
previousFeedItem = currentFeedItem;
7065
}
@@ -74,8 +69,8 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView
7469
* Scrolls the window down when a title is tapped
7570
*/
7671
- (void)didTapHeadlineOfCell:(EZRFeedItemCollectionViewCell *)cell {
77-
CGPoint lowestPoint = CGPointMake(0, controller.scrollView_vertical.contentSize.height - CGRectGetHeight(controller.scrollView_vertical.frame));
78-
[controller.scrollView_vertical setContentOffset:lowestPoint animated:YES];
72+
CGPoint lowestPoint = CGPointMake(0, self.scrollView_vertical.contentSize.height - CGRectGetHeight(self.scrollView_vertical.frame));
73+
[self.scrollView_vertical setContentOffset:lowestPoint animated:YES];
7974
}
8075

8176
@end

EasyReader/Application/Controllers/Home/EZRHomeFeedImagePrefetcher.h

Lines changed: 0 additions & 13 deletions
This file was deleted.

EasyReader/Application/Controllers/Home/EZRHomeFeedImagePrefetcher.m

Lines changed: 0 additions & 46 deletions
This file was deleted.

EasyReader/Application/Controllers/Home/EZRHomeViewController.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@
3939
/// The collection view which holds the individual feed items
4040
@property (strong, nonatomic) IBOutlet EZRFeedItemCollectionView *collectionView_feedItems;
4141

42-
/// Displays website that hosts article
43-
@property (nonatomic, strong) EZRNestableWebView *webView_feedItem;
4442

4543
/// The up indicator displayed over the web view to assist in navigating to the top of the page
4644
@property (nonatomic, strong) UIImageView *upIndicatorView;
@@ -54,6 +52,8 @@
5452
/// Feed Item currently visible
5553
@property (nonatomic, readonly) NSInteger currentPageIndex;
5654

55+
/// Displays website that hosts article
56+
@property (nonatomic, weak) IBOutlet EZRNestableWebView *webView_feedItem;
5757

5858
# pragma mark - Methods
5959

0 commit comments

Comments
 (0)