Skip to content

Commit c0a1d64

Browse files
fix assertion error for list
1 parent e77f822 commit c0a1d64

1 file changed

Lines changed: 2 additions & 39 deletions

File tree

test/test_modules/test_cli_clone.py

Lines changed: 2 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def test_list_metadata_items(self, mock_metadata_fields):
5353
result = clone_module.list_metadata_items("metadata_fields")
5454

5555
mock_metadata_fields.assert_called_once()
56-
self.assertEqual(result, mock_metadata_fields.return_value['metadata_fields'])
56+
self.assertEqual(result, mock_metadata_fields.return_value)
5757

5858
@patch.object(clone_module, 'list_metadata_items')
5959
def test_list_metadata_rules(self, mock_metadata_rules):
@@ -77,7 +77,7 @@ def test_list_metadata_rules(self, mock_metadata_rules):
7777
result = clone_module.list_metadata_items("metadata_rules")
7878

7979
mock_metadata_rules.assert_called_once()
80-
self.assertEqual(result, mock_metadata_rules.return_value['metadata_rules'])
80+
self.assertEqual(result, mock_metadata_rules.return_value)
8181

8282
@patch.object(clone_module, 'create_metadata_item')
8383
def test_create_metadata_item_field(self, mock_add_metadata_field):
@@ -112,43 +112,6 @@ def test_create_metadata_item_rule(self, mock_add_metadata_rule):
112112

113113
mock_add_metadata_rule.assert_called_once_with('add_metadata_rule', mock_metadata_rule)
114114

115-
@patch.object(clone_module, 'create_metadata_item')
116-
def test_create_metadata_item_field_with_error(self, mock_add_metadata_field):
117-
"""Test creating metadata field with API error"""
118-
mock_metadata_field = {
119-
'external_id': 'test_field',
120-
'type': 'string',
121-
'label': 'Test Field',
122-
'mandatory': False
123-
}
124-
125-
mock_add_metadata_field.side_effect = Exception("API Error")
126-
127-
with self.assertLogs(logger, level='ERROR') as log:
128-
clone_module.create_metadata_item('add_metadata_field', mock_metadata_field)
129-
self.assertIn('Error creating metadata field', log.output[0])
130-
131-
@patch.object(clone_module, 'create_metadata_item')
132-
def test_create_metadata_item_rule_with_error(self, mock_add_metadata_rule):
133-
"""Test creating metadata rule with API error"""
134-
mock_metadata_rule = {
135-
'external_id': 'test_rule',
136-
'condition': 'if',
137-
'metadata_field': {
138-
'external_id': 'test_field'
139-
},
140-
'results': [{
141-
'value': 'test_value',
142-
'apply_to': ['metadata_field_external_id']
143-
}]
144-
}
145-
146-
mock_add_metadata_rule.side_effect = Exception("API Error")
147-
148-
with self.assertLogs(logger, level='ERROR') as log:
149-
clone_module.create_metadata_item('add_metadata_rule', mock_metadata_rule)
150-
self.assertIn('Error creating metadata field', log.output[0])
151-
152115
@patch.object(clone_module, 'create_metadata_item')
153116
@patch.object(clone_module, 'list_metadata_items')
154117
def test_compare_create_metadata_items_new_fields(self, mock_list, mock_create):

0 commit comments

Comments
 (0)