Parenthesis not allowed in JAVA_OPTS

This commit allows any special charecter including parenthesis to be
used in the value of a JAVA_OPT obtained from either an environment
variable or the java_opts configuration.

[#86290602]

Author: Christopher Frost

lib/java_buildpack/framework/java_opts.rb

@@ -65,7 +65,14 @@ def parsed_java_opts
         parsed_java_opts.concat @configuration[CONFIGURATION_PROPERTY].shellsplit if supports_configuration?
         parsed_java_opts.concat ENV[ENVIRONMENT_VARIABLE].shellsplit if supports_environment?
 
-        parsed_java_opts.map { |java_opt| java_opt.gsub(/([\s])/, '\\\\\1') }
+        # parsed_java_opts.map { |java_opt| java_opt.gsub(/([\s])/, '\\\\\1') }
+        parsed_java_opts.map do |java_opt|
+          if /(?<key>.+)=(?<value>.+)/ =~ java_opt
+            "#{key}=#{value.shellescape}"
+          else
+            java_opt
+          end
+        end
       end
 
       def supports_configuration?

spec/java_buildpack/framework/java_opts_spec.rb

@@ -62,7 +62,19 @@
       expect(java_opts).to include('-Xdebug')
       expect(java_opts).to include('-Xnoagent')
       expect(java_opts).to include('-Xrunjdwp:transport=dt_socket,server=y,address=8000,suspend=y')
-      expect(java_opts).to include('-XX:OnOutOfMemoryError=kill\ -9\ %p')
+      expect(java_opts).to include('-XX:OnOutOfMemoryError=kill\ -9\ \%p')
+    end
+  end
+
+  context do
+    let(:configuration) do
+      { 'java_opts' => '-Dtest=!£$%^&*(){}<>[];~`' }
+    end
+
+    it 'escapes special characters' do
+      component.release
+
+      expect(java_opts).to include('-Dtest=\\!\\£\\$\\%\\^\\&\\*\\(\\)\\{\\}\\<\\>\\[\\]\\;\\~\\`')
     end
   end