Skip to content

Commit 9e096be

Browse files
committed
More defensive
Guess I should test before pushing. This change makes the SSL debug logging a lot more defensive.
1 parent 793f793 commit 9e096be

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

lib/java_buildpack/util/cache/download_cache.rb

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,17 @@ def cache_last_modified(response, cached_file)
177177
end
178178
end
179179

180+
def debug_ssl(http)
181+
socket = http.instance_variable_get('@socket')
182+
return unless socket
183+
184+
io = socket.io
185+
return unless io
186+
187+
session = io.session
188+
@logger.debug { session.to_text } if session
189+
end
190+
180191
def from_mutable_cache(uri)
181192
cached_file = CachedFile.new @mutable_cache_root, uri, true
182193
cached = update URI(uri), cached_file
@@ -256,7 +267,8 @@ def secure?(uri)
256267
def update(uri, cached_file)
257268
proxy(uri).start(uri.host, uri.port, http_options(uri)) do |http|
258269
@logger.debug { "HTTP: #{http.address}, #{http.port}, #{http_options(uri)}" }
259-
@logger.debug { http.instance_variable_get('@socket').io.session.to_text } if secure? uri
270+
debug_ssl(http) if secure?(uri)
271+
260272
request = request uri, cached_file
261273
request.basic_auth uri.user, uri.password if uri.user && uri.password
262274

0 commit comments

Comments
 (0)