Merge pull request #1169 from kiril-keranov/patch-16

[go-migration] Remove takipi agent framework

Author: ramonskie

README.md

@@ -185,7 +185,6 @@ For historical analysis documents from development sessions, see [`docs/archive/
   * [Spring Auto Reconfiguration](docs/framework-spring_auto_reconfiguration.md) ([Configuration](docs/framework-spring_auto_reconfiguration.md#configuration))
   * [Spring Insight](docs/framework-spring_insight.md)
   * [SkyWalking Agent](docs/framework-sky_walking_agent.md) ([Configuration](docs/framework-sky_walking_agent.md#configuration))
-  * [Takipi Agent](docs/framework-takipi_agent.md) ([Configuration](docs/framework-takipi_agent.md#configuration))
   * [YourKit Profiler](docs/framework-your_kit_profiler.md) ([Configuration](docs/framework-your_kit_profiler.md#configuration))
 * Standard JREs (Included in Manifest)
   * [OpenJDK](docs/jre-open_jdk_jre.md) ([Configuration](docs/jre-open_jdk_jre.md#configuration)) - Default

docs/framework-ordering.md

@@ -52,9 +52,8 @@ Line | Framework Name                          | Priority | Notes
 77   | SpringInsight                          | 43       | Spring monitoring
 78   | SkyWalkingAgent                        | 44       | APM agent
 79   | YourKitProfiler                        | 45       | Profiler
-80   | TakipiAgent                            | 46       | APM agent
-81   | JavaSecurity                           | 47       | Security configuration
-82   | JavaOpts                               | 99       | ⚠️ USER-DEFINED OPTS (ALWAYS LAST)
+80   | JavaSecurity                           | 47       | Security configuration
+81   | JavaOpts                               | 99       | ⚠️ USER-DEFINED OPTS (ALWAYS LAST)
 ```
 
 ## Go Buildpack Implementation

docs/framework-takipi_agent.md

@@ -908,27 +908,6 @@ func testFrameworks(platform switchblade.Platform, fixtures string) func(*testin
 				})
 			})
 
-			context("with Takipi service binding", func() {
-				it("detects and installs Takipi agent", func() {
-					t.Skip("SKIPPED: Takipi agent requires valid download URL and SHA256 in manifest.yml")
-					deployment, logs, err := platform.Deploy.
-						WithServices(map[string]switchblade.Service{
-							"takipi": {
-								"secret_key": "test-secret-key",
-								"server":     "https://takipi.example.com",
-							},
-						}).
-						WithEnv(map[string]string{
-							"BP_JAVA_VERSION": "11",
-						}).
-						Execute(name, filepath.Join(fixtures, "containers", "spring_boot_staged"))
-					Expect(err).NotTo(HaveOccurred(), logs.String)
-
-					Expect(logs.String()).To(ContainSubstring("Takipi"))
-					Eventually(deployment).Should(matchers.Serve(ContainSubstring("")))
-				})
-			})
-
 			context("with Introscope service binding", func() {
 				it("detects and installs Introscope agent", func() {
 					t.Skip("SKIPPED: Introscope agent requires authentication and is not in manifest.yml")
@@ -978,7 +957,7 @@ func testFrameworks(platform switchblade.Platform, fixtures string) func(*testin
 					deployment, logs, err := platform.Deploy.
 						WithEnv(map[string]string{
 							"BP_JAVA_VERSION":                 "11",
-							"JBP_CONFIG_ASPECTJ_WEAVER_AGENT": "'{enabled: true}'",
+							"JBP_CONFIG_ASPECTJ_WEAVER_AGENT": "{ enabled: true }",
 						}).
 						Execute(name, filepath.Join(fixtures, "frameworks", "aspectj_weaver_meta_inf"))
 					Expect(err).NotTo(HaveOccurred(), logs.String)

src/integration/frameworks_test.go

@@ -101,7 +101,6 @@ func (r *Registry) RegisterStandardFrameworks() {
 	r.Register(NewJRebelAgentFramework(r.context))
 	r.Register(NewContrastSecurityAgentFramework(r.context))
 	r.Register(NewAspectJWeaverAgentFramework(r.context))
-	r.Register(NewTakipiAgentFramework(r.context))
 	r.Register(NewYourKitProfilerFramework(r.context))
 	r.Register(NewJProfilerProfilerFramework(r.context))
 	r.Register(NewSealightsAgentFramework(r.context))