Skip to content

Commit 70faf51

Browse files
authored
Merge pull request #1141 from kiril-keranov/patch-3
Update sapmachine versions
2 parents 8dd8175 + 8762470 commit 70faf51

3 files changed

Lines changed: 21 additions & 14 deletions

File tree

comparison.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,11 +180,11 @@ The following frameworks were added since the initial migration:
180180

181181
#### Included in Default Manifest (3 JREs) ✅
182182

183-
| JRE | Ruby File | Go File | Versions Supported | Default | Status |
184-
|-----|-----------|---------|-------------------|---------|--------|
185-
| **OpenJDK** | `open_jdk_jre.rb` | `openjdk.go` | 8, 11, 17, 21, 23 | 17.x | ✅ Complete |
186-
| **Zulu (Azul)** | `zulu_jre.rb` | `zulu.go` | 8, 11, 17 | 11.x | ✅ Complete |
187-
| **SAP Machine** | `sap_machine_jre.rb` | `sapmachine.go` | 11, 17 | 17.x | ✅ Complete |
183+
| JRE | Ruby File | Go File | Versions Supported | Default | Status |
184+
|-----|-----------|---------|---------------------------------------------|---------|--------|
185+
| **OpenJDK** | `open_jdk_jre.rb` | `openjdk.go` | 8, 11, 17, 21, 23 | 17.x | ✅ Complete |
186+
| **Zulu (Azul)** | `zulu_jre.rb` | `zulu.go` | 8, 11, 17 | 11.x | ✅ Complete |
187+
| **SAP Machine** | `sap_machine_jre.rb` | `sapmachine.go` | 11(ruby only), 17, 21(go only), 25(go only) | 21.x | ✅ Complete |
188188

189189
#### BYOL JREs - Require Custom Manifest (4 JREs) ✅
190190

manifest.yml

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ default_versions:
2121
- name: zulu
2222
version: 11.x
2323
- name: sapmachine
24-
version: 17.x
24+
version: 21.x
2525
- name: tomcat
2626
version: 10.1.x
2727
- name: tomcat-access-logging-support
@@ -259,16 +259,23 @@ dependencies:
259259
# SAP Machine JRE versions
260260
# Repository: https://github.com/SAP/SapMachine/releases
261261
- name: sapmachine
262-
version: 11.0.25
263-
uri: https://github.com/SAP/SapMachine/releases/download/sapmachine-11.0.25/sapmachine-jre-11.0.25_linux-x64_bin.tar.gz
264-
sha256: 10f3eb5b93c2c26f7c69a3690d5877b401b5ab24a6b1798fac5518beb1f1f839
262+
version: 17.0.17
263+
uri: https://github.com/SAP/SapMachine/releases/download/sapmachine-17.0.17/sapmachine-jre-17.0.17_linux-x64_bin.tar.gz
264+
sha256: c45d572629c722b18a6254f7503a397dbfe474223afb3ac96ef462d27074f7a0
265265
cf_stacks:
266266
- cflinuxfs4
267267

268268
- name: sapmachine
269-
version: 17.0.13
270-
uri: https://github.com/SAP/SapMachine/releases/download/sapmachine-17.0.13/sapmachine-jre-17.0.13_linux-x64_bin.tar.gz
271-
sha256: b5f16befcb6415cfcf3bdb57b361c8eeca8176d494cd1e6c067cd56acec1afe6
269+
version: 21.0.9
270+
uri: https://github.com/SAP/SapMachine/releases/download/sapmachine-21.0.9/sapmachine-jre-21.0.9_linux-x64_bin.tar.gz
271+
sha256: 4cc6b1501a2fe8ae0f106342b3c00eec00b7886ce9215760b611cc9975bd339b
272+
cf_stacks:
273+
- cflinuxfs4
274+
275+
- name: sapmachine
276+
version: 25.0.1
277+
uri: https://github.com/SAP/SapMachine/releases/download/sapmachine-25.0.1/sapmachine-jre-25.0.1_linux-x64_bin.tar.gz
278+
sha256: 6bc007201b97214a3883e2da92dc80b2e5ae29378a7a77ab4077d74ccbfdfdbd
272279
cf_stacks:
273280
- cflinuxfs4
274281

src/integration/java_main_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ func testJavaMain(platform switchblade.Platform, fixtures string) func(*testing.
105105
it("deploys with SAPMachine JRE from manifest", func() {
106106
_, logs, err := platform.Deploy.
107107
WithEnv(map[string]string{
108-
"BP_JAVA_VERSION": "11",
108+
"BP_JAVA_VERSION": "17",
109109
"JBP_CONFIG_COMPONENTS": `{jres: ["JavaBuildpack::Jre::SapMachineJRE"]}`,
110110
}).
111111
Execute(name, filepath.Join(fixtures, "containers", "main"))
@@ -114,7 +114,7 @@ func testJavaMain(platform switchblade.Platform, fixtures string) func(*testing.
114114
// Verify SAPMachine JRE was installed from manifest
115115
Expect(logs.String()).To(ContainSubstring("Java Buildpack"))
116116
Expect(logs.String()).To(ContainSubstring("Installing SAP Machine"))
117-
Expect(logs.String()).To(ContainSubstring("11."))
117+
Expect(logs.String()).To(ContainSubstring("17."))
118118
})
119119
})
120120
}

0 commit comments

Comments
 (0)