Skip to content

Commit 4c29ce1

Browse files
author
Patrick Mueller
committed
updates for version 1.0.4
1 parent 674a48a commit 4c29ce1

4 files changed

Lines changed: 16 additions & 3 deletions

File tree

README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,13 @@ first with `url.parse()`, there will be a `host` property in the result, so
260260
you won't be able to use the `hostname` and `port` values directly. You
261261
can **ONLY** set the resultant hostname and port with the `host` property.
262262

263+
Note that `url.parse()` and the later `url.format()` calls to construct the
264+
result, will not produce pleasing results for "unusual" URLs, especially
265+
those which do not use `http:` or `https:` protocols. The `url` `parse()`
266+
and `format()` methods will not be used though, if you have no replacement
267+
values, or the only replacement property is `url`, and so are safe to
268+
use in that case.
269+
263270
Since the `appEnv.getServiceURL()` method operates against the
264271
`appEnv.services` property, you can fudge this object if that makes your
265272
life easier.
@@ -304,6 +311,12 @@ When you visit the site, you'll see the output of various cfenv calls.
304311
changes
305312
================================================================================
306313

314+
**1.0.4** - 2017/01/13
315+
316+
- fix to getServiceURL() with non-http URLs - [issue #21][]
317+
318+
[issue #21]: https://github.com/cloudfoundry-community/node-cfenv/issues/21
319+
307320
**1.0.3** - 2014/10/02
308321

309322
- fixes for compatibility with Diego - [issue #11][]

lib-src/cfenv.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ throwError = (message) ->
218218

219219
#-------------------------------------------------------------------------------
220220
# Copyright IBM Corp. 2014
221-
# Copyright Patrick Mueller 2015
221+
# Copyright Patrick Mueller 2015, 2017
222222
#
223223
# Licensed under the Apache License, Version 2.0 (the "License");
224224
# you may not use this file except in compliance with the License.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "cfenv",
33
"main": "./lib/cfenv",
44
"description": "easy access to your Cloud Foundry application environment",
5-
"version": "1.0.3",
5+
"version": "1.0.4",
66
"author": "pmuellr",
77
"license": "Apache-2.0",
88
"homepage": "https://github.com/cloudfoundry-community/node-cfenv",

tests/test-core.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ JL = (object) -> JSON.stringify object, null, 4
524524

525525
#-------------------------------------------------------------------------------
526526
# Copyright IBM Corp. 2014
527-
# Copyright Patrick Mueller 2015
527+
# Copyright Patrick Mueller 2015, 2017
528528
#
529529
# Licensed under the Apache License, Version 2.0 (the "License");
530530
# you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)