CLJS-1082: analysis memoization bug

drop :cljs.analyzer/analyzed-cljs, redundant, use :cljs.analyzer/namespaces as source
of truth of analyzed namespaces

Author: dnolen

src/clj/cljs/analyzer.clj

@@ -1979,7 +1979,7 @@ argument, which the reader will use in any emitted errors."
                cache (when (or (= (:ns ns-info) 'cljs.core)
                                (and (:cache-analysis opts) output-dir))
                        (cache-file res ns-info output-dir))]
-           (when-not (get-in @env/*compiler* [::analyzed-cljs path])
+           (when-not (get-in @env/*compiler* [::namespaces (:ns ns-info)])
              (if (or (not= (:ns ns-info) 'cljs.core)
                      (not cache)
                      (requires-analysis? res output-dir))
@@ -1999,8 +1999,7 @@ argument, which the reader will use in any emitted errors."
                                   (recur ns (next forms))))
                               ns))]
                    (when (and cache (true? (:cache-analysis opts)))
-                     (write-analysis-cache ns cache))
-                   (swap! env/*compiler* assoc-in [::analyzed-cljs path] true)))
+                     (write-analysis-cache ns cache))))
                ;; we want want to keep dependency analysis information
                ;; don't revert the environment - David
                (let [{:keys [ns]}
@@ -2017,5 +2016,4 @@ argument, which the reader will use in any emitted errors."
                        (doseq [x (get-in cached-ns [::constants :order])]
                          (register-constant! x))
                        (-> cenv
-                         (assoc-in [::analyzed-cljs path] true)
                          (assoc-in [::namespaces ns] cached-ns))))))))))))))

src/clj/cljs/compiler.clj

@@ -1015,8 +1015,7 @@
                                :source-map-timestamp (:source-map-timestamp opts)
                                :source-map-pretty-print (:source-map-pretty-print opts)}))))
                       (let [path (.getPath (.toURL ^File dest))]
-                        (swap! env/*compiler* assoc-in [::compiled-cljs path] ret)
-                        (swap! env/*compiler* assoc-in [::ana/analyzed-cljs path] true))
+                        (swap! env/*compiler* assoc-in [::compiled-cljs path] ret))
                       (let [{:keys [output-dir cache-analysis]} opts]
                         (when (and (true? cache-analysis) output-dir)
                           (ana/write-analysis-cache ns-name