Skip to content

Commit 07b4c2b

Browse files
feat(ui,clerk-js,shared,react,localizations): Rename the SSO fallback sign-in flow to SSO bypass (#9822)
1 parent 1b73117 commit 07b4c2b

65 files changed

Lines changed: 128 additions & 119 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
'@clerk/localizations': minor
3+
'@clerk/clerk-js': minor
4+
'@clerk/shared': minor
5+
'@clerk/react': minor
6+
'@clerk/ui': minor
7+
---
8+
9+
Rename the SSO fallback sign-in flow to SSO bypass, matching the name the feature ships under. The sign-in resource's `ssoFallbackFirstFactors` is now `ssoBypassFirstFactors` and reads the `sso_bypass_first_factors` field from the API, the `signIn.ssoFallback` localization keys are now `signIn.ssoBypass`, and the `ssoFallback` card action element id is now `ssoBypass`. The flow has not been enabled on any instance, so no application is affected by the old names going away.

‎packages/clerk-js/src/core/resources/SignIn.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ export class SignIn extends BaseResource implements SignInResource {
118118
supportedIdentifiers: SignInIdentifier[] = [];
119119
supportedFirstFactors: SignInFirstFactor[] | null = [];
120120
supportedSecondFactors: SignInSecondFactor[] | null = null;
121-
ssoFallbackFirstFactors: SignInFirstFactor[] | null = null;
121+
ssoBypassFirstFactors: SignInFirstFactor[] | null = null;
122122
firstFactorVerification: VerificationResource = new Verification(null);
123123
secondFactorVerification: VerificationResource = new Verification(null);
124124
identifier: string | null = null;
@@ -640,7 +640,7 @@ export class SignIn extends BaseResource implements SignInResource {
640640
this.identifier = data.identifier;
641641
this.supportedFirstFactors = deepSnakeToCamel(data.supported_first_factors) as SignInFirstFactor[] | null;
642642
this.supportedSecondFactors = deepSnakeToCamel(data.supported_second_factors) as SignInSecondFactor[] | null;
643-
this.ssoFallbackFirstFactors = deepSnakeToCamel(data.sso_fallback_first_factors ?? null) as
643+
this.ssoBypassFirstFactors = deepSnakeToCamel(data.sso_bypass_first_factors ?? null) as
644644
| SignInFirstFactor[]
645645
| null;
646646
this.firstFactorVerification = new Verification(data.first_factor_verification);
@@ -712,7 +712,7 @@ export class SignIn extends BaseResource implements SignInResource {
712712
supported_identifiers: this.supportedIdentifiers,
713713
supported_first_factors: deepCamelToSnake(this.supportedFirstFactors),
714714
supported_second_factors: deepCamelToSnake(this.supportedSecondFactors),
715-
sso_fallback_first_factors: deepCamelToSnake(this.ssoFallbackFirstFactors) ?? undefined,
715+
sso_bypass_first_factors: deepCamelToSnake(this.ssoBypassFirstFactors) ?? undefined,
716716
first_factor_verification: this.firstFactorVerification.__internal_toSnapshot(),
717717
second_factor_verification: this.secondFactorVerification.__internal_toSnapshot(),
718718
identifier: this.identifier,
@@ -832,8 +832,8 @@ class SignInFuture implements SignInFutureResource {
832832
return this.#resource.supportedSecondFactors ?? [];
833833
}
834834

835-
get ssoFallbackFirstFactors() {
836-
return this.#resource.ssoFallbackFirstFactors ?? [];
835+
get ssoBypassFirstFactors() {
836+
return this.#resource.ssoBypassFirstFactors ?? [];
837837
}
838838

839839
get isTransferable() {

‎packages/clerk-js/src/core/resources/__tests__/SignIn.test.ts‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3292,7 +3292,7 @@ describe('SignIn', () => {
32923292
});
32933293
});
32943294

3295-
describe('ssoFallbackFirstFactors', () => {
3295+
describe('ssoBypassFirstFactors', () => {
32963296
const baseJSON = {
32973297
id: 'signin_123',
32983298
object: 'sign_in',
@@ -3310,29 +3310,29 @@ describe('SignIn', () => {
33103310
it('defaults to null when the field is absent', () => {
33113311
const signIn = new SignIn(baseJSON);
33123312

3313-
expect(signIn.ssoFallbackFirstFactors).toBeNull();
3314-
expect(signIn.__internal_future.ssoFallbackFirstFactors).toEqual([]);
3315-
expect(signIn.__internal_toSnapshot().sso_fallback_first_factors).toBeUndefined();
3313+
expect(signIn.ssoBypassFirstFactors).toBeNull();
3314+
expect(signIn.__internal_future.ssoBypassFirstFactors).toEqual([]);
3315+
expect(signIn.__internal_toSnapshot().sso_bypass_first_factors).toBeUndefined();
33163316
});
33173317

33183318
it('round-trips the field through the snapshot', () => {
33193319
const signIn = new SignIn({
33203320
...baseJSON,
3321-
sso_fallback_first_factors: [
3321+
sso_bypass_first_factors: [
33223322
{ strategy: 'email_code', safe_identifier: 'user@corp.com', email_address_id: 'idn_hmac' },
33233323
],
33243324
});
33253325

3326-
expect(signIn.ssoFallbackFirstFactors).toEqual([
3326+
expect(signIn.ssoBypassFirstFactors).toEqual([
33273327
{ strategy: 'email_code', safeIdentifier: 'user@corp.com', emailAddressId: 'idn_hmac' },
33283328
]);
3329-
expect(signIn.__internal_future.ssoFallbackFirstFactors).toEqual(signIn.ssoFallbackFirstFactors);
3329+
expect(signIn.__internal_future.ssoBypassFirstFactors).toEqual(signIn.ssoBypassFirstFactors);
33303330

33313331
const snapshot = signIn.__internal_toSnapshot();
3332-
expect(snapshot.sso_fallback_first_factors).toEqual([
3332+
expect(snapshot.sso_bypass_first_factors).toEqual([
33333333
{ strategy: 'email_code', safe_identifier: 'user@corp.com', email_address_id: 'idn_hmac' },
33343334
]);
3335-
expect(new SignIn(snapshot).ssoFallbackFirstFactors).toEqual(signIn.ssoFallbackFirstFactors);
3335+
expect(new SignIn(snapshot).ssoBypassFirstFactors).toEqual(signIn.ssoBypassFirstFactors);
33363336
});
33373337
});
33383338
});

‎packages/localizations/src/ar-SA.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1687,7 +1687,7 @@ export const arSA: LocalizationResource = {
16871687
resetPasswordMfa: {
16881688
detailsLabel: 'نريد التحقق من هويتك قبل أعادة تعيين كلمة المرور',
16891689
},
1690-
ssoFallback: {
1690+
ssoBypass: {
16911691
actionLink: undefined,
16921692
code: {
16931693
resendButton: undefined,

‎packages/localizations/src/be-BY.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1694,7 +1694,7 @@ export const beBY: LocalizationResource = {
16941694
resetPasswordMfa: {
16951695
detailsLabel: 'Неабходна верыфікаваць вашу асобу перад аднаўленнем пароля',
16961696
},
1697-
ssoFallback: {
1697+
ssoBypass: {
16981698
actionLink: undefined,
16991699
code: {
17001700
resendButton: undefined,

‎packages/localizations/src/bg-BG.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1690,7 +1690,7 @@ export const bgBG: LocalizationResource = {
16901690
resetPasswordMfa: {
16911691
detailsLabel: 'Трябва да потвърдим вашата самоличност, преди да нулираме паролата ви.',
16921692
},
1693-
ssoFallback: {
1693+
ssoBypass: {
16941694
actionLink: undefined,
16951695
code: {
16961696
resendButton: undefined,

‎packages/localizations/src/bn-IN.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1700,7 +1700,7 @@ export const bnIN: LocalizationResource = {
17001700
resetPasswordMfa: {
17011701
detailsLabel: 'আপনার পাসওয়ার্ড রিসেট করার আগে আমাদের আপনার পরিচয় যাচাই করতে হবে।',
17021702
},
1703-
ssoFallback: {
1703+
ssoBypass: {
17041704
actionLink: undefined,
17051705
code: {
17061706
resendButton: undefined,

‎packages/localizations/src/ca-ES.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1699,7 +1699,7 @@ export const caES: LocalizationResource = {
16991699
resetPasswordMfa: {
17001700
detailsLabel: 'Necessitem verificar la teva identitat abans de restablir la teva contrasenya.',
17011701
},
1702-
ssoFallback: {
1702+
ssoBypass: {
17031703
actionLink: undefined,
17041704
code: {
17051705
resendButton: undefined,

‎packages/localizations/src/cs-CZ.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1698,7 +1698,7 @@ export const csCZ: LocalizationResource = {
16981698
resetPasswordMfa: {
16991699
detailsLabel: 'Před resetováním hesla musíme ověřit vaši identitu.',
17001700
},
1701-
ssoFallback: {
1701+
ssoBypass: {
17021702
actionLink: undefined,
17031703
code: {
17041704
resendButton: undefined,

‎packages/localizations/src/da-DK.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1688,7 +1688,7 @@ export const daDK: LocalizationResource = {
16881688
resetPasswordMfa: {
16891689
detailsLabel: 'Vi skal bekræfte din identitet, før du nulstiller din adgangskode.',
16901690
},
1691-
ssoFallback: {
1691+
ssoBypass: {
16921692
actionLink: undefined,
16931693
code: {
16941694
resendButton: undefined,

0 commit comments

Comments
 (0)