Skip to content

php 8.4 #520

Description

@olaulau

Hi ;

simply trying to instantiate this lib on PHP 8.4 fails :

composer require "jaggedsoft/php-binance-api @dev"

$api = new API();

Binance\API::orders(): Implicitly marking parameter $fromOrderId as nullable is deprecated, the explicit nullable type must be used instead
[vendor/jaggedsoft/php-binance-api/php-binance-api.php:610]

line 610 should have the ?int :
public function orders(string $symbol, ?int $limit = null, ?int $fromOrderId = null, array $params = [])

same for rollingWindowPriceChange and replaceOrder

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions