Repository navigation
Commit 5fcbd4e
committed
Run the directory's checks before the commit, not after
Plugin Check is what the release gates on, and today it caught three
things after they were pushed: an escaping sniff that cannot see through
a variable, a translators comment one line too far from its string, and a
deliberately versionless script. Each cost a red run and a fix commit.
It turns out the tool runs locally in about a second against a WordPress
install with the plugin-check plugin active, so the hook now runs it when
one is at hand. Errors block the commit and warnings do not, which is the
same line the workflow draws - what passes here passes there.
Point CAPTCHAAPI_WP_PATH at an install or keep one beside the repo as
../wp-test; without either, the step is skipped like phpcs above it, so a
fresh clone is unaffected.1 parent 079fa18 commit 5fcbd4e
1 file changed
Lines changed: 39 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
0 commit comments