EL-360 -- Revert the StateChangedDate back to Date

henrys-cm · henrys-cm · commit 1a04ce673feb · 2021-12-22T16:22:09.000+11:00
diff --git a/HISTORY.md b/HISTORY.md
@@ -8,7 +8,7 @@
 * Add new support for 'client.tags' endpoint (ie: getting list of tags for the client)
 * Add support for pagination, filtering and sorting to 'client.campaigns' endpoint
 * Add Python 3.10 to `tox.ini`
-* Breaking: Following endpoints now return ListJoinedDate for each subscriber.  Also, Date has been renamed to StateChangedDate:
+* Adding support for returning ListJoinedDate for each subscriber. 
   * List.Active()
   * List.Bounced()
   * List.Unsubscribed()
diff --git a/test/fixtures/active_subscribers.json b/test/fixtures/active_subscribers.json
@@ -3,7 +3,7 @@
     {
       "EmailAddress": "subs+7t8787Y@example.com",
       "Name": "Person One",
-      "StateChangedDate": "2010-10-25 10:28:00",
+      "Date": "2010-10-25 10:28:00",
       "ListJoinedDate": "2010-10-24 10:28:00",
       "State": "Active",
       "CustomFields": [
@@ -33,7 +33,7 @@
     {
       "EmailAddress": "subs+7878787y8ggg@example.com",
       "Name": "Person Two",
-      "StateChangedDate": "2010-10-25 12:17:00",
+      "Date": "2010-10-25 12:17:00",
       "ListJoinedDate": "2010-10-25 12:17:00",
       "State": "Active",
       "CustomFields": [
@@ -47,7 +47,7 @@
     {
       "EmailAddress": "subs+7890909i0ggg@example.com",
       "Name": "Person Three",
-      "StateChangedDate": "2010-10-25 12:52:00",
+      "Date": "2010-10-25 12:52:00",
       "ListJoinedDate": "2010-10-25 12:52:00",
       "State": "Active",
       "CustomFields": [
@@ -61,7 +61,7 @@
     {
       "EmailAddress": "subs@example.com",
       "Name": "Person Four",
-      "StateChangedDate": "2010-10-27 13:13:00",
+      "Date": "2010-10-27 13:13:00",
       "ListJoinedDate": "2010-10-27 13:13:00",
       "State": "Active",
       "CustomFields": [],
@@ -70,7 +70,7 @@
     {
       "EmailAddress": "joey@example.com",
       "Name": "Person Five",
-      "StateChangedDate": "2010-10-27 13:13:00",
+      "Date": "2010-10-27 13:13:00",
       "ListJoinedDate": "2010-10-27 13:13:00",
       "State": "Active",
       "CustomFields": [],
diff --git a/test/fixtures/active_subscribers_with_tracking_preference.json b/test/fixtures/active_subscribers_with_tracking_preference.json
@@ -3,7 +3,7 @@
     {
       "EmailAddress": "subs+7t8787Y@example.com",
       "Name": "Person One",
-      "StateChangedDate": "2010-10-25 10:28:00",
+      "Date": "2010-10-25 10:28:00",
       "ListJoinedDate": "2010-10-24 10:28:00",
       "State": "Active",
       "CustomFields": [
@@ -34,7 +34,7 @@
     {
       "EmailAddress": "subs+7878787y8ggg@example.com",
       "Name": "Person Two",
-      "StateChangedDate": "2010-10-25 12:17:00",
+      "Date": "2010-10-25 12:17:00",
       "ListJoinedDate": "2010-10-25 12:17:00",
       "State": "Active",
       "CustomFields": [
@@ -49,7 +49,7 @@
     {
       "EmailAddress": "subs+7890909i0ggg@example.com",
       "Name": "Person Three",
-      "StateChangedDate": "2010-10-25 12:52:00",
+      "Date": "2010-10-25 12:52:00",
       "ListJoinedDate": "2010-10-25 12:52:00",
       "State": "Active",
       "CustomFields": [
@@ -64,7 +64,7 @@
     {
       "EmailAddress": "subs@example.com",
       "Name": "Person Four",
-      "StateChangedDate": "2010-10-27 13:13:00",
+      "Date": "2010-10-27 13:13:00",
       "ListJoinedDate": "2010-10-27 13:13:00",
       "State": "Active",
       "CustomFields": [],
@@ -74,7 +74,7 @@
     {
       "EmailAddress": "joey@example.com",
       "Name": "Person Five",
-      "StateChangedDate": "2010-10-27 13:13:00",
+      "Date": "2010-10-27 13:13:00",
       "ListJoinedDate": "2010-10-27 13:13:00",
       "State": "Active",
       "CustomFields": [],
diff --git a/test/fixtures/bounced_subscribers.json b/test/fixtures/bounced_subscribers.json
@@ -3,7 +3,7 @@
     {
       "EmailAddress": "bouncedsubscriber@example.com",
       "Name": "Bounced One",
-      "StateChangedDate": "2010-10-25 13:11:00",
+      "Date": "2010-10-25 13:11:00",
       "ListJoinedDate": "2010-10-25 13:11:00",
       "State": "Bounced",
       "CustomFields": [],
diff --git a/test/fixtures/deleted_subscribers.json b/test/fixtures/deleted_subscribers.json
@@ -3,7 +3,7 @@
     {
       "EmailAddress": "subscriber@example.com",
       "Name": "Deleted One",
-      "StateChangedDate": "2010-10-25 13:11:00",
+      "Date": "2010-10-25 13:11:00",
       "ListJoinedDate": "2010-10-25 13:11:00",
       "State": "Deleted",
       "CustomFields": [],
@@ -12,7 +12,7 @@
     {
       "EmailAddress": "subscriberone@example.com",
       "Name": "Subscriber",
-      "StateChangedDate": "2010-10-25 13:04:00",
+      "Date": "2010-10-25 13:04:00",
       "ListJoinedDate": "2010-10-25 13:04:00",
       "State": "Deleted",
       "CustomFields": [
@@ -26,7 +26,7 @@
     {
       "EmailAddress": "example+1@example.com",
       "Name": "Example One",
-      "StateChangedDate": "2010-10-26 10:56:00",
+      "Date": "2010-10-26 10:56:00",
       "ListJoinedDate": "2010-10-26 10:56:00",
       "State": "Deleted",
       "CustomFields": [],
@@ -35,7 +35,7 @@
     {
       "EmailAddress": "example+2@example.com",
       "Name": "Example Two",
-      "StateChangedDate": "2010-10-26 10:56:00",
+      "Date": "2010-10-26 10:56:00",
       "ListJoinedDate": "2010-10-26 10:56:00",
       "State": "Deleted",
       "CustomFields": [],
@@ -44,7 +44,7 @@
     {
       "EmailAddress": "example+3@example.com",
       "Name": "Example Three",
-      "StateChangedDate": "2010-10-26 10:56:00",
+      "Date": "2010-10-26 10:56:00",
       "ListJoinedDate": "2010-10-26 10:56:00",
       "State": "Deleted",
       "CustomFields": [],
diff --git a/test/fixtures/segment_subscribers.json b/test/fixtures/segment_subscribers.json
@@ -3,15 +3,15 @@
     {
       "EmailAddress": "personone@example.com",
       "Name": "Person One",
-      "StateChangedDate": "2010-10-27 13:13:00",
+      "Date": "2010-10-27 13:13:00",
       "ListJoinedDate": "2010-10-27 13:13:00",
       "State": "Active",
       "CustomFields": []
     },
     {
       "EmailAddress": "persontwo@example.com",
       "Name": "Person Two",
-      "StateChangedDate": "2010-10-27 13:13:00",
+      "Date": "2010-10-27 13:13:00",
       "ListJoinedDate": "2010-10-27 13:13:00",
       "State": "Active",
       "CustomFields": []
diff --git a/test/fixtures/segment_subscribers_with_tracking_preference.json b/test/fixtures/segment_subscribers_with_tracking_preference.json
@@ -3,7 +3,7 @@
     {
       "EmailAddress": "personone@example.com",
       "Name": "Person One",
-      "StateChangedDate": "2010-10-27 13:13:00",
+      "Date": "2010-10-27 13:13:00",
       "ListJoinedDate": "2010-10-27 13:13:00",
       "State": "Active",
       "CustomFields": [],
@@ -12,7 +12,7 @@
     {
       "EmailAddress": "persontwo@example.com",
       "Name": "Person Two",
-      "StateChangedDate": "2010-10-27 13:13:00",
+      "Date": "2010-10-27 13:13:00",
       "ListJoinedDate": "2010-10-27 13:13:00",
       "State": "Active",
       "CustomFields": [],
diff --git a/test/fixtures/subscriber_details.json b/test/fixtures/subscriber_details.json
@@ -1,7 +1,7 @@
 {
   "EmailAddress": "subscriber@example.com",
   "Name": "Subscriber One",
-  "StateChangedDate": "2010-10-25 10:28:00",
+  "Date": "2010-10-25 10:28:00",
   "ListJoinedDate": "2010-10-25 10:28:00",
   "State": "Active",
   "CustomFields": [
diff --git a/test/fixtures/subscriber_details_with_tracking_preference.json b/test/fixtures/subscriber_details_with_tracking_preference.json
@@ -1,7 +1,7 @@
 {
   "EmailAddress": "subscriber@example.com",
   "Name": "Subscriber One",
-  "StateChangedDate": "2010-10-25 10:28:00",
+  "Date": "2010-10-25 10:28:00",
   "ListJoinedDate": "2010-10-25 10:28:00",
   "State": "Active",
   "CustomFields": [
diff --git a/test/fixtures/unconfirmed_subscribers.json b/test/fixtures/unconfirmed_subscribers.json
@@ -3,7 +3,7 @@
         {
             "EmailAddress": "subs+7t8787Y@example.com",
             "Name": "Unconfirmed One",
-            "StateChangedDate": "2010-10-25 10:28:00",
+            "Date": "2010-10-25 10:28:00",
             "ListJoinedDate": "2010-10-25 10:28:00",
             "State": "Unconfirmed",
             "CustomFields": [
@@ -17,7 +17,7 @@
         {
             "EmailAddress": "subs+7878787y8ggg@example.com",
             "Name": "Unconfirmed Two",
-            "StateChangedDate": "2010-10-25 12:17:00",
+            "Date": "2010-10-25 12:17:00",
             "ListJoinedDate": "2010-10-25 12:17:00",
             "State": "Unconfirmed",
             "CustomFields": [
diff --git a/test/fixtures/unsubscribed_subscribers.json b/test/fixtures/unsubscribed_subscribers.json
@@ -3,7 +3,7 @@
     {
       "EmailAddress": "subscriber@example.com",
       "Name": "Unsub One",
-      "StateChangedDate": "2010-10-25 13:11:00",
+      "Date": "2010-10-25 13:11:00",
       "ListJoinedDate": "2010-10-25 13:11:00",
       "State": "Unsubscribed",
       "CustomFields": [],
@@ -12,7 +12,7 @@
     {
       "EmailAddress": "subscriberone@example.com",
       "Name": "Subscriber",
-      "StateChangedDate": "2010-10-25 13:04:00",
+      "Date": "2010-10-25 13:04:00",
       "ListJoinedDate": "2010-10-25 13:04:00",
       "State": "Unsubscribed",
       "CustomFields": [
@@ -26,7 +26,7 @@
     {
       "EmailAddress": "example+1@example.com",
       "Name": "Example One",
-      "StateChangedDate": "2010-10-26 10:56:00",
+      "Date": "2010-10-26 10:56:00",
       "ListJoinedDate": "2010-10-26 10:56:00",
       "State": "Unsubscribed",
       "CustomFields": [],
@@ -35,7 +35,7 @@
     {
       "EmailAddress": "example+2@example.com",
       "Name": "Example Two",
-      "StateChangedDate": "2010-10-26 10:56:00",
+      "Date": "2010-10-26 10:56:00",
       "ListJoinedDate": "2010-10-26 10:56:00",
       "State": "Unsubscribed",
       "CustomFields": [],
@@ -44,7 +44,7 @@
     {
       "EmailAddress": "example+3@example.com",
       "Name": "Example Three",
-      "StateChangedDate": "2010-10-26 10:56:00",
+      "Date": "2010-10-26 10:56:00",
       "ListJoinedDate": "2010-10-26 10:56:00",
       "State": "Unsubscribed",
       "CustomFields": [],
diff --git a/test/test_list.py b/test/test_list.py
@@ -146,7 +146,7 @@ def test_active(self):
         self.assertEquals(res.Results[0].EmailAddress,
                           "subs+7t8787Y@example.com")
         self.assertEquals(res.Results[0].Name, "Person One")
-        self.assertEquals(res.Results[0].StateChangedDate, "2010-10-25 10:28:00")
+        self.assertEquals(res.Results[0].Date, "2010-10-25 10:28:00")
         self.assertEquals(res.Results[0].ListJoinedDate, "2010-10-24 10:28:00")
         self.assertEquals(res.Results[0].State, "Active")
         self.assertEquals(len(res.Results[0].CustomFields), 5)
@@ -177,7 +177,7 @@ def test_active_with_tracking_preference_included(self):
         self.assertEquals(res.Results[0].EmailAddress,
                           "subs+7t8787Y@example.com")
         self.assertEquals(res.Results[0].Name, "Person One")
-        self.assertEquals(res.Results[0].StateChangedDate, "2010-10-25 10:28:00")
+        self.assertEquals(res.Results[0].Date, "2010-10-25 10:28:00")
         self.assertEquals(res.Results[0].ListJoinedDate, "2010-10-24 10:28:00")
         self.assertEquals(res.Results[0].State, "Active")
         self.assertEquals(len(res.Results[0].CustomFields), 5)
@@ -227,7 +227,7 @@ def test_unsubscribed(self):
         self.assertEquals(
             res.Results[0].EmailAddress, "subscriber@example.com")
         self.assertEquals(res.Results[0].Name, "Unsub One")
-        self.assertEquals(res.Results[0].StateChangedDate, "2010-10-25 13:11:00")
+        self.assertEquals(res.Results[0].Date, "2010-10-25 13:11:00")
         self.assertEquals(res.Results[0].ListJoinedDate, "2010-10-25 13:11:00")
         self.assertEquals(res.Results[0].State, "Unsubscribed")
         self.assertEquals(len(res.Results[0].CustomFields), 0)
@@ -249,7 +249,7 @@ def test_deleted(self):
         self.assertEquals(
             res.Results[0].EmailAddress, "subscriber@example.com")
         self.assertEquals(res.Results[0].Name, "Deleted One")
-        self.assertEquals(res.Results[0].StateChangedDate, "2010-10-25 13:11:00")
+        self.assertEquals(res.Results[0].Date, "2010-10-25 13:11:00")
         self.assertEquals(res.Results[0].ListJoinedDate, "2010-10-25 13:11:00")
         self.assertEquals(res.Results[0].State, "Deleted")
         self.assertEquals(len(res.Results[0].CustomFields), 0)
@@ -271,7 +271,7 @@ def test_bounced(self):
         self.assertEquals(res.Results[0].EmailAddress,
                           "bouncedsubscriber@example.com")
         self.assertEquals(res.Results[0].Name, "Bounced One")
-        self.assertEquals(res.Results[0].StateChangedDate, "2010-10-25 13:11:00")
+        self.assertEquals(res.Results[0].Date, "2010-10-25 13:11:00")
         self.assertEquals(res.Results[0].ListJoinedDate, "2010-10-25 13:11:00")
         self.assertEquals(res.Results[0].State, "Bounced")
         self.assertEquals(len(res.Results[0].CustomFields), 0)
diff --git a/test/test_segment.py b/test/test_segment.py
@@ -46,7 +46,7 @@ def test_subscribers(self):
         self.assertEquals(len(res.Results), 2)
         self.assertEquals(res.Results[0].EmailAddress, "personone@example.com")
         self.assertEquals(res.Results[0].Name, "Person One")
-        self.assertEquals(res.Results[0].StateChangedDate, "2010-10-27 13:13:00")
+        self.assertEquals(res.Results[0].Date, "2010-10-27 13:13:00")
         self.assertEquals(res.Results[0].ListJoinedDate, "2010-10-27 13:13:00")
         self.assertEquals(res.Results[0].State, "Active")
         self.assertEquals(res.Results[0].CustomFields, [])
@@ -66,7 +66,7 @@ def test_subscribers_with_tracking_information_included(self):
         self.assertEquals(len(res.Results), 2)
         self.assertEquals(res.Results[0].EmailAddress, "personone@example.com")
         self.assertEquals(res.Results[0].Name, "Person One")
-        self.assertEquals(res.Results[0].StateChangedDate, "2010-10-27 13:13:00")
+        self.assertEquals(res.Results[0].Date, "2010-10-27 13:13:00")
         self.assertEquals(res.Results[0].ListJoinedDate, "2010-10-27 13:13:00")
         self.assertEquals(res.Results[0].State, "Active")
         self.assertEquals(res.Results[0].CustomFields, [])
diff --git a/test/test_subscriber.py b/test/test_subscriber.py
@@ -14,7 +14,7 @@ def test_get(self):
         subscriber = self.subscriber.get(self.list_id, email)
         self.assertEquals(subscriber.EmailAddress, email)
         self.assertEquals(subscriber.Name, "Subscriber One")
-        self.assertEquals(subscriber.StateChangedDate, "2010-10-25 10:28:00")
+        self.assertEquals(subscriber.Date, "2010-10-25 10:28:00")
         self.assertEquals(subscriber.ListJoinedDate, "2010-10-25 10:28:00")
         self.assertEquals(subscriber.State, "Active")
         self.assertEquals(len(subscriber.CustomFields), 3)
@@ -30,7 +30,7 @@ def test_get_without_arguments(self):
         subscriber = self.subscriber.get()
         self.assertEquals(subscriber.EmailAddress, email)
         self.assertEquals(subscriber.Name, "Subscriber One")
-        self.assertEquals(subscriber.StateChangedDate, "2010-10-25 10:28:00")
+        self.assertEquals(subscriber.Date, "2010-10-25 10:28:00")
         self.assertEquals(subscriber.ListJoinedDate, "2010-10-25 10:28:00")
         self.assertEquals(subscriber.State, "Active")
         self.assertEquals(len(subscriber.CustomFields), 3)
@@ -46,7 +46,7 @@ def test_get_with_tracking_preference_included(self):
         subscriber = self.subscriber.get(self.list_id, email, include_tracking_preference=True)
         self.assertEquals(subscriber.EmailAddress, email)
         self.assertEquals(subscriber.Name, "Subscriber One")
-        self.assertEquals(subscriber.StateChangedDate, "2010-10-25 10:28:00")
+        self.assertEquals(subscriber.Date, "2010-10-25 10:28:00")
         self.assertEquals(subscriber.ListJoinedDate, "2010-10-25 10:28:00")
         self.assertEquals(subscriber.State, "Active")
         self.assertEquals(len(subscriber.CustomFields), 3)

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`{`
`4`	`4`	`"EmailAddress": "bouncedsubscriber@example.com",`
`5`	`5`	`"Name": "Bounced One",`
`6`		`- "StateChangedDate": "2010-10-25 13:11:00",`
	`6`	`+ "Date": "2010-10-25 13:11:00",`
`7`	`7`	`"ListJoinedDate": "2010-10-25 13:11:00",`
`8`	`8`	`"State": "Bounced",`
`9`	`9`	`"CustomFields": [],`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"EmailAddress": "subscriber@example.com",`
`3`	`3`	`"Name": "Subscriber One",`
`4`		`- "StateChangedDate": "2010-10-25 10:28:00",`
	`4`	`+ "Date": "2010-10-25 10:28:00",`
`5`	`5`	`"ListJoinedDate": "2010-10-25 10:28:00",`
`6`	`6`	`"State": "Active",`
`7`	`7`	`"CustomFields": [`