Skip to content

Commit 2ed7ed3

Browse files
committed
Only keep a changeset for released behavior
The fixes to the multi-addon build and to --namespaced-targets both correct code introduced on this PR's base branch, which has never been merged or released, so they have nothing to announce in a changelog. What remains is the part existing users can observe: the --out default and the artifact naming. Narrowed the changeset to just those. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KfKQDvEkxNtkSE4aaF9yG8
1 parent 5fa3b60 commit 2ed7ed3

3 files changed

Lines changed: 10 additions & 45 deletions

File tree

‎.changeset/afraid-jars-attack.md‎

Lines changed: 0 additions & 15 deletions
This file was deleted.

‎.changeset/olive-pumas-shave.md‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎.changeset/tidy-pianos-repeat.md‎

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,13 @@
22
"cmake-rn": minor
33
---
44

5-
Emit prebuilds per target, next to the sources they were built from.
6-
7-
A project declaring multiple addons previously wrote every prebuild into a single
8-
output directory, named after the CMake target. Both are now derived per target:
9-
10-
- The output directory defaults to `{targetSourceDir}/build/{configuration}`,
11-
where the new `{targetSourceDir}` placeholder expands to the target's own source
12-
directory as reported by the CMake File API. A project declaring a single addon
13-
at the top level resolves to the same path as before.
14-
- The prebuild is named after the artifact on disk (the target's `OUTPUT_NAME`)
15-
rather than the CMake target name, so a target that had to be renamed to avoid a
16-
clash within the project still produces the artifact name the JS `require`
17-
expects.
18-
19-
This keeps prebuilds where the Babel plugin and auto-linking resolve them from.
20-
21-
Note that projects setting `OUTPUT_NAME` will see the emitted prebuild named after
22-
`OUTPUT_NAME` rather than the target name, and that `--out` no longer defaults to a
23-
directory inside `--build`.
5+
Derive the location and name of the final artifact from the target that produced
6+
it, rather than emitting everything into a single directory named after the CMake
7+
target:
8+
9+
- `--out` supports a new `{targetSourceDir}` placeholder, expanding to the source
10+
directory of the target being emitted, and now defaults to
11+
`{targetSourceDir}/build/{configuration}`. This resolves to the same path as
12+
before, unless `--build` is pointed outside of the source directory.
13+
- The artifact is named after the target's `OUTPUT_NAME` rather than the CMake
14+
target name. These are the same unless `OUTPUT_NAME` is set explicitly.

0 commit comments

Comments
 (0)