From 8dcce27b1b7d3bba0530ce18e92011dfd6a4c85e Mon Sep 17 00:00:00 2001 From: Nitish Agarwal <1592163+nitishagar@users.noreply.github.com> Date: Tue, 11 Aug 2026 21:54:29 +0530 Subject: [PATCH] Include directly for std::setw/setfill/setprecision usage The native engine build (cactus build --python) fails on strict libstdc++ (e.g. Raspberry Pi GCC) with "'setw' is not a member of 'std'" in cactus-engine/src/telemetry_impl.cpp, which uses std::setw/std::setfill without including . Add a direct #include to every translation unit that uses std::setw/std::setfill/std::setprecision without one: 2 production sources (telemetry_impl.cpp, complete.cpp) and 13 tests. Several compiled only via a transitive include through utils.h / test_utils.h, which is non-portable across libstdc++/libc++ and fragile to header changes; telemetry_impl.cpp had no such transitive path and failed outright. No behavioral change; headers only. Signed-off-by: Nitish Agarwal <1592163+nitishagar@users.noreply.github.com> --- cactus-engine/src/complete.cpp | 1 + cactus-engine/src/telemetry_impl.cpp | 1 + cactus-engine/tests/test_benchmark.cpp | 1 + cactus-engine/tests/test_embed.cpp | 1 + cactus-engine/tests/test_llm.cpp | 1 + cactus-engine/tests/test_utils.cpp | 1 + cactus-engine/tests/test_vlm.cpp | 1 + cactus-graph/tests/test_nn.cpp | 1 + cactus-kernels/tests/test_attention.cpp | 1 + cactus-kernels/tests/test_conv.cpp | 1 + cactus-kernels/tests/test_dsp.cpp | 1 + cactus-kernels/tests/test_elementwise.cpp | 1 + cactus-kernels/tests/test_matmul.cpp | 1 + cactus-kernels/tests/test_quant.cpp | 1 + cactus-kernels/tests/test_reduce.cpp | 1 + 15 files changed, 15 insertions(+) diff --git a/cactus-engine/src/complete.cpp b/cactus-engine/src/complete.cpp index d91b70272..9b7daf8b2 100644 --- a/cactus-engine/src/complete.cpp +++ b/cactus-engine/src/complete.cpp @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include diff --git a/cactus-engine/src/telemetry_impl.cpp b/cactus-engine/src/telemetry_impl.cpp index 0f5d85b1f..c3a0ea538 100644 --- a/cactus-engine/src/telemetry_impl.cpp +++ b/cactus-engine/src/telemetry_impl.cpp @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include diff --git a/cactus-engine/tests/test_benchmark.cpp b/cactus-engine/tests/test_benchmark.cpp index a24144ecc..656b9a834 100644 --- a/cactus-engine/tests/test_benchmark.cpp +++ b/cactus-engine/tests/test_benchmark.cpp @@ -1,5 +1,6 @@ #include "test_utils.h" #include +#include #include #include #include diff --git a/cactus-engine/tests/test_embed.cpp b/cactus-engine/tests/test_embed.cpp index 13078c473..299e7bc35 100644 --- a/cactus-engine/tests/test_embed.cpp +++ b/cactus-engine/tests/test_embed.cpp @@ -1,5 +1,6 @@ #include "test_utils.h" #include +#include #include using namespace EngineTestUtils; diff --git a/cactus-engine/tests/test_llm.cpp b/cactus-engine/tests/test_llm.cpp index 7f05eaa21..1bfab8069 100644 --- a/cactus-engine/tests/test_llm.cpp +++ b/cactus-engine/tests/test_llm.cpp @@ -3,6 +3,7 @@ #include #include #include +#include #include #if __has_include() diff --git a/cactus-engine/tests/test_utils.cpp b/cactus-engine/tests/test_utils.cpp index 76c3ddd97..79ad6f55c 100644 --- a/cactus-engine/tests/test_utils.cpp +++ b/cactus-engine/tests/test_utils.cpp @@ -2,6 +2,7 @@ #include #include #include +#include namespace TestUtils { diff --git a/cactus-engine/tests/test_vlm.cpp b/cactus-engine/tests/test_vlm.cpp index 85f0ae223..80f2524ec 100644 --- a/cactus-engine/tests/test_vlm.cpp +++ b/cactus-engine/tests/test_vlm.cpp @@ -1,5 +1,6 @@ #include "test_utils.h" #include +#include #include using namespace EngineTestUtils; diff --git a/cactus-graph/tests/test_nn.cpp b/cactus-graph/tests/test_nn.cpp index 67519ca28..890631931 100644 --- a/cactus-graph/tests/test_nn.cpp +++ b/cactus-graph/tests/test_nn.cpp @@ -3,6 +3,7 @@ #include #include #include +#include #include #include diff --git a/cactus-kernels/tests/test_attention.cpp b/cactus-kernels/tests/test_attention.cpp index 91c63b84c..699159815 100644 --- a/cactus-kernels/tests/test_attention.cpp +++ b/cactus-kernels/tests/test_attention.cpp @@ -1,6 +1,7 @@ #include "test_utils.h" #include #include +#include using namespace TestUtils; diff --git a/cactus-kernels/tests/test_conv.cpp b/cactus-kernels/tests/test_conv.cpp index c6ae32682..55b73d481 100644 --- a/cactus-kernels/tests/test_conv.cpp +++ b/cactus-kernels/tests/test_conv.cpp @@ -1,6 +1,7 @@ #include "test_utils.h" #include #include +#include using namespace TestUtils; diff --git a/cactus-kernels/tests/test_dsp.cpp b/cactus-kernels/tests/test_dsp.cpp index f55bd0fdd..47dd3c8e1 100644 --- a/cactus-kernels/tests/test_dsp.cpp +++ b/cactus-kernels/tests/test_dsp.cpp @@ -2,6 +2,7 @@ #include #include #include +#include using namespace TestUtils; diff --git a/cactus-kernels/tests/test_elementwise.cpp b/cactus-kernels/tests/test_elementwise.cpp index 337c58c25..779d011ed 100644 --- a/cactus-kernels/tests/test_elementwise.cpp +++ b/cactus-kernels/tests/test_elementwise.cpp @@ -1,6 +1,7 @@ #include "test_utils.h" #include #include +#include using namespace TestUtils; diff --git a/cactus-kernels/tests/test_matmul.cpp b/cactus-kernels/tests/test_matmul.cpp index 6cefff49d..c3bcda103 100644 --- a/cactus-kernels/tests/test_matmul.cpp +++ b/cactus-kernels/tests/test_matmul.cpp @@ -3,6 +3,7 @@ #include #include #include +#include using namespace TestUtils; diff --git a/cactus-kernels/tests/test_quant.cpp b/cactus-kernels/tests/test_quant.cpp index ee0bc3625..470325da9 100644 --- a/cactus-kernels/tests/test_quant.cpp +++ b/cactus-kernels/tests/test_quant.cpp @@ -1,6 +1,7 @@ #include "test_utils.h" #include #include +#include using namespace TestUtils; diff --git a/cactus-kernels/tests/test_reduce.cpp b/cactus-kernels/tests/test_reduce.cpp index a6c3753c2..7b3ad97f4 100644 --- a/cactus-kernels/tests/test_reduce.cpp +++ b/cactus-kernels/tests/test_reduce.cpp @@ -1,6 +1,7 @@ #include "test_utils.h" #include #include +#include using namespace TestUtils;