Refactor deletion logic and add new properties/methods

Abstracted message deletion into a new Delete() method in CafeController.cs. Added Client property to BotApp.cs and BotControllerBase.cs. Updated BotControllerBase.cs to include new namespaces and a safe Delete() method. Introduced TryGetMessageId extension method in TelegramUpdateExtensions.cs.

Author: bvdcode

Sources/TelegramBot.ConsoleTest/Controllers/CafeController.cs

@@ -49,7 +49,7 @@ public async Task<IActionResult> HandleBurgersAsync(int burgers, bool drink)
 
             await telegramBotClient.SendTextMessageAsync(adminId, orderText);
             SetValue("customerId", User.Id);
-            await telegramBotClient.DeleteMessageAsync(User.Id, Update.CallbackQuery!.Message!.MessageId);
+            Delete();
             return Text(text);
         }
 

Sources/TelegramBot/BotApp.cs

@@ -250,6 +250,7 @@ await authorizationHandler
             BotControllerBase controller = (BotControllerBase)ActivatorUtilities.CreateInstance(_serviceProvider, method.DeclaringType!);
             controller.Update = update;
             controller.User = user;
+            controller.Client = _client;
             if (_serviceProvider.GetService<IKeyValueProvider>() is IKeyValueProvider keyValueProvider)
             {
                 controller.KeyValueProvider = keyValueProvider;

Sources/TelegramBot/Controllers/BotControllerBase.cs

@@ -1,6 +1,8 @@
 using System;
 using System.Linq;
+using Telegram.Bot;
 using Telegram.Bot.Types;
+using TelegramBot.Extensions;
 using TelegramBot.Abstractions;
 using TelegramBot.ActionResults;
 using Telegram.Bot.Types.ReplyMarkups;
@@ -24,6 +26,11 @@ public abstract class BotControllerBase
         /// </summary>
         public Update Update { get; internal set; } = null!;
 
+        /// <summary>
+        /// <see cref="ITelegramBotClient"/> instance.
+        /// </summary>
+        public ITelegramBotClient Client { get; internal set; } = null!;
+
         /// <summary>
         /// Sends a text message to the sender.
         /// </summary>
@@ -155,5 +162,24 @@ public TValue GetValue<TValue>(string key)
             string json = GetValue(key);
             return string.IsNullOrWhiteSpace(json) ? default! : System.Text.Json.JsonSerializer.Deserialize<TValue>(json)!;
         }
+
+        /// <summary>
+        /// Deletes message from the current update, or does nothing if the message identifier is not found.
+        /// <br/>
+        /// Note: this method does not throw exceptions when the message ID is not found, access is denied, message is already deleted etc.
+        /// </summary>
+        public void Delete()
+        {
+            bool hasMessageId = Update.TryGetMessageId(out int messageId);
+            if (!hasMessageId)
+            {
+                return;
+            }
+            try
+            {
+                Client.DeleteMessageAsync(User.Id, messageId);
+            }
+            catch (Exception) { }
+        }
     }
 }

Sources/TelegramBot/Extensions/TelegramUpdateExtensions.cs

@@ -57,5 +57,28 @@ public static bool TryGetUser(this Update update, out User user)
             user = null!;
             return false;
         }
+
+        /// <summary>
+        /// Tries to get the message ID of the update.
+        /// </summary>
+        /// <param name="update">Telegram update.</param>
+        /// <param name="messageId">Message identifier.</param>
+        /// <returns>If the message identifier is not 0, returns true; otherwise, false.</returns>
+        public static bool TryGetMessageId(this Update update, out int messageId)
+        {
+            if (update.Message != null)
+            {
+                messageId = update.Message.MessageId;
+                return true;
+            }
+            else if (update.CallbackQuery != null && update.CallbackQuery.Message != null)
+            {
+                messageId = update.CallbackQuery.Message.MessageId;
+                return true;
+            }
+
+            messageId = 0;
+            return false;
+        }
     }
 }