Refactor TryMatchMethod for clarity and efficiency

Refactored the `TryMatchMethod` function to improve readability and performance by introducing a fast path for parameterless methods and delegating complex logic to a new helper method `TryExtractArgsFromParts`. The new helper method handles command part matching, placeholder resolution, and type conversion. Updated comments for better maintainability.

Author: bvdcode

Sources/TelegramBot/Handlers/InlineQueryHandler.cs

@@ -72,7 +72,9 @@ private bool TryMatchMethod(MethodInfo method, string command, out List<object>
         {
             args = new List<object>();
 
-            var attributes = method.GetCustomAttributes(typeof(InlineCommandAttribute), inherit: false);
+            var attributes = method.GetCustomAttributes(typeof(InlineCommandAttribute), inherit: false)
+                .OfType<InlineCommandAttribute>()
+                .ToArray();
             if (attributes.Length == 0)
             {
                 return false;
@@ -81,67 +83,63 @@ private bool TryMatchMethod(MethodInfo method, string command, out List<object>
             var incomingCommandParts = command.Split('/');
             var methodParameters = method.GetParameters();
 
-            foreach (var attribute in attributes)
+            // Fast path: parameterless method with an exact attribute command
+            if (methodParameters.Length == 0)
             {
-                if (!(attribute is InlineCommandAttribute botAttribute))
+                if (attributes.Any(a => string.Equals(a.Command, command, StringComparison.Ordinal)))
                 {
-                    continue;
+                    return true;
                 }
+                return false;
+            }
 
+            foreach (var botAttribute in attributes)
+            {
                 var controllerCommandParts = botAttribute.Command.Split('/');
-
-                // Exact match shortcut for methods without parameters
-                if (methodParameters.Length == 0)
+                if (controllerCommandParts.Length != incomingCommandParts.Length)
                 {
-                    if (string.Equals(botAttribute.Command, command, StringComparison.Ordinal))
-                    {
-                        return true;
-                    }
                     continue;
                 }
 
-                if (controllerCommandParts.Length != incomingCommandParts.Length)
+                if (TryExtractArgsFromParts(controllerCommandParts, incomingCommandParts, methodParameters, out var tempArgs))
                 {
-                    continue;
+                    args = tempArgs;
+                    return true;
                 }
+            }
 
-                var tempArgs = new List<object>(incomingCommandParts.Length);
-                bool match = true;
+            return false;
+        }
 
-                for (int i = 0; i < controllerCommandParts.Length; i++)
-                {
-                    var controllerPart = controllerCommandParts[i];
-                    var incomingPart = incomingCommandParts[i];
+        private bool TryExtractArgsFromParts(string[] controllerCommandParts, string[] incomingCommandParts, ParameterInfo[] methodParameters, out List<object> tempArgs)
+        {
+            tempArgs = new List<object>(incomingCommandParts.Length);
 
-                    if (IsPlaceholder(controllerPart))
+            for (int i = 0; i < controllerCommandParts.Length; i++)
+            {
+                var controllerPart = controllerCommandParts[i];
+                var incomingPart = incomingCommandParts[i];
+
+                if (IsPlaceholder(controllerPart))
+                {
+                    var name = PlaceholderName(controllerPart);
+                    var parameter = methodParameters.FirstOrDefault(p => p.Name == name);
+                    if (parameter != null)
                     {
-                        var name = PlaceholderName(controllerPart);
-                        var parameter = methodParameters.FirstOrDefault(p => p.Name == name);
-                        if (parameter != null)
+                        if (!TryConvertToType(incomingPart, parameter.ParameterType))
                         {
-                            if (!TryConvertToType(incomingPart, parameter.ParameterType))
-                            {
-                                match = false;
-                                break;
-                            }
+                            return false;
                         }
-                        tempArgs.Add(incomingPart);
-                    }
-                    else if (!string.Equals(controllerPart, incomingPart, StringComparison.Ordinal))
-                    {
-                        match = false;
-                        break;
                     }
+                    tempArgs.Add(incomingPart);
                 }
-
-                if (match)
+                else if (!string.Equals(controllerPart, incomingPart, StringComparison.Ordinal))
                 {
-                    args = tempArgs;
-                    return true;
+                    return false;
                 }
             }
 
-            return false;
+            return true;
         }
 
         private bool TryConvertToType(string value, Type targetType)