Fix BadRequestException message, refactor Mediator registration

- Correct BadRequestException message from "Unathorized" to "Bad request"
- Refactor Mediator registration: use HashSet for interfaces, replace Fill with AddRangeDistinct, and improve naming
- Use Count > 0 instead of Any() for processor registration checks
- Clarify estimatedPerWindow calculation in AesGcmStreamCipher
- Remove stray blank line in ShellLink.cs

Author: bvdcode

Sources/EasyExtensions.AspNetCore/Exceptions/BadRequestException.cs

@@ -10,6 +10,6 @@ namespace EasyExtensions.AspNetCore.Exceptions
     /// </summary>
     /// <param name="objectName">The name of the object associated with the unauthorized or invalid request.</param>
     public class BadRequestException(string objectName)
-        : WebApiException(HttpStatusCode.BadRequest, objectName, "Unathorized")
+        : WebApiException(HttpStatusCode.BadRequest, objectName, "Bad request")
     { }
 }

Sources/EasyExtensions.Crypto/AesGcmStreamCipher.cs

@@ -153,7 +153,7 @@ private int ComputeEffectiveWindowCap(int chunkSize)
                 return Math.Clamp(_windowCap, 4, int.MaxValue);
             }
             // Estimate per-window memory footprint: ciphertext buffer ~ chunkSize + headers/overhead ~ 64KB
-            long estimatedPerWindow = cs + 64L * 1024L;
+            long estimatedPerWindow = cs + (64L * 1024L);
             long maxWindowsByMem = Math.Max(4, _memoryLimitBytes.Value / Math.Max(estimatedPerWindow, 1));
             int effective = (int)Math.Clamp(maxWindowsByMem, 4, int.MaxValue);
             return Math.Min(_windowCap, effective);

Sources/EasyExtensions.Mediator/Registration/ServiceRegistrar.cs

@@ -136,9 +136,9 @@ private static void ConnectImplementationsToTypesClosing(Type openRequestInterfa
             CancellationToken cancellationToken = default)
         {
             var concretions = new List<Type>();
-            var interfaces = new List<Type>();
+            var interfaces = new HashSet<Type>();
             var genericConcretions = new List<Type>();
-            var genericInterfaces = new List<Type>();
+            var genericInterfaces = new HashSet<Type>();
 
             var types = assembliesToScan
                 .SelectMany(a => a.DefinedTypes)
@@ -154,55 +154,48 @@ private static void ConnectImplementationsToTypesClosing(Type openRequestInterfa
                 if (!type.IsOpenGeneric())
                 {
                     concretions.Add(type);
-
-                    foreach (var interfaceType in interfaceTypes)
-                    {
-                        interfaces.Fill(interfaceType);
-                    }
+                    AddRangeDistinct(interfaces, interfaceTypes);
                 }
                 else
                 {
                     genericConcretions.Add(type);
-                    foreach (var interfaceType in interfaceTypes)
-                    {
-                        genericInterfaces.Fill(interfaceType);
-                    }
+                    AddRangeDistinct(genericInterfaces, interfaceTypes);
                 }
             }
 
-            foreach (var @interface in interfaces)
+            foreach (var iface in interfaces)
             {
-                var exactMatches = concretions.Where(x => x.CanBeCastTo(@interface)).ToList();
+                var exactMatches = concretions.Where(x => x.CanBeCastTo(iface)).ToList();
                 if (addIfAlreadyExists)
                 {
                     foreach (var type in exactMatches)
                     {
-                        services.AddTransient(@interface, type);
+                        services.AddTransient(iface, type);
                     }
                 }
                 else
                 {
                     if (exactMatches.Count > 1)
                     {
-                        exactMatches.RemoveAll(m => !IsMatchingWithInterface(m, @interface));
+                        exactMatches.RemoveAll(m => !IsMatchingWithInterface(m, iface));
                     }
 
                     foreach (var type in exactMatches)
                     {
-                        services.TryAddTransient(@interface, type);
+                        services.TryAddTransient(iface, type);
                     }
                 }
 
-                if (!@interface.IsOpenGeneric())
+                if (!iface.IsOpenGeneric())
                 {
-                    AddConcretionsThatCouldBeClosed(@interface, concretions, services);
+                    AddConcretionsThatCouldBeClosed(iface, concretions, services);
                 }
             }
 
-            foreach (var @interface in genericInterfaces)
+            foreach (var iface in genericInterfaces)
             {
-                var exactMatches = genericConcretions.Where(x => x.CanBeCastTo(@interface)).ToList();
-                AddAllConcretionsThatClose(@interface, exactMatches, services, assembliesToScan, cancellationToken);
+                var exactMatches = genericConcretions.Where(x => x.CanBeCastTo(iface)).ToList();
+                AddAllConcretionsThatClose(iface, exactMatches, services, assembliesToScan, cancellationToken);
             }
         }
 
@@ -454,13 +447,21 @@ private static bool IsConcrete(this Type type)
             return !type.IsAbstract && !type.IsInterface;
         }
 
-        private static void Fill<T>(this IList<T> list, T value)
+        private static void AddRangeDistinct<T>(ISet<T> set, IEnumerable<T> values)
         {
-            if (list.Contains(value))
+            if (set == null)
+            {
+                throw new ArgumentNullException(nameof(set));
+            }
+            if (values == null)
+            {
+                throw new ArgumentNullException(nameof(values));
+            }
+
+            foreach (var value in values)
             {
-                return;
+                set.Add(value);
             }
-            list.Add(value);
         }
 
         /// <summary>
@@ -498,13 +499,13 @@ public static void AddRequiredServices(IServiceCollection services, MediatorServ
                 RegisterBehaviorIfImplementationsExist(services, typeof(RequestExceptionActionProcessorBehavior<,>), typeof(IRequestExceptionAction<,>));
             }
 
-            if (serviceConfiguration.RequestPreProcessorsToRegister.Any())
+            if (serviceConfiguration.RequestPreProcessorsToRegister.Count > 0)
             {
                 services.TryAddEnumerable(new ServiceDescriptor(typeof(IPipelineBehavior<,>), typeof(RequestPreProcessorBehavior<,>), ServiceLifetime.Transient));
                 services.TryAddEnumerable(serviceConfiguration.RequestPreProcessorsToRegister);
             }
 
-            if (serviceConfiguration.RequestPostProcessorsToRegister.Any())
+            if (serviceConfiguration.RequestPostProcessorsToRegister.Count > 0)
             {
                 services.TryAddEnumerable(new ServiceDescriptor(typeof(IPipelineBehavior<,>), typeof(RequestPostProcessorBehavior<,>), ServiceLifetime.Transient));
                 services.TryAddEnumerable(serviceConfiguration.RequestPostProcessorsToRegister);

Sources/EasyExtensions.Windows/ShellLink.cs

@@ -194,7 +194,6 @@ void GetPath([Out(), MarshalAs(UnmanagedType.LPStr)] StringBuilder pszFile,
             void SetPath([MarshalAs(UnmanagedType.LPStr)] string pszFile);
         }
 
-
         /// <summary>
         /// IShellLinkW interface for managing shell links (shortcuts) in Windows.
         /// </summary>