Skip to content

Commit 2bc660b

Browse files
committed
Refactor NUnit assertions for clarity and consistency
Updated assertions to use modern NUnit syntax for improved readability and consistency. Replaced `Is.EqualTo(0)` with `Is.Zero` where applicable. Grouped related assertions using `Assert.EnterMultipleScope()` to reduce redundancy. Corrected the initialization of an empty `MemoryStream` in one test case, though the change may introduce a syntax error due to the use of `[]` instead of `Array.Empty<byte>()`.
1 parent dcc95e6 commit 2bc660b

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

Sources/EasyExtensions.Tests/ChunkedStreamTests.cs

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ public void GetChunks_SplitsStreamIntoEqualSizedChunks_WhenLengthIsMultipleOfChu
2323
var chunks = chunked.GetChunks().ToList();
2424

2525
// Assert
26-
Assert.That(chunks.Count, Is.EqualTo(totalSize / chunkSize));
26+
Assert.That(chunks, Has.Count.EqualTo(totalSize / chunkSize));
2727
for (int idx = 0; idx < chunks.Count; idx++)
2828
{
2929
var chunk = chunks[idx];
3030
using (chunk)
3131
{
3232
Assert.That(chunk.Length, Is.EqualTo(chunkSize));
33-
Assert.That(chunk.Position, Is.EqualTo(0));
33+
Assert.That(chunk.Position, Is.Zero);
3434
// verify content is contiguous and matches source
3535
using var reader = new BinaryReader(chunk, System.Text.Encoding.UTF8, leaveOpen: true);
3636
var bytes = reader.ReadBytes((int)chunk.Length);
@@ -55,10 +55,13 @@ public void GetChunks_FinalChunkIsSmaller_WhenLengthNotMultipleOfChunkSize()
5555
var chunks = chunked.GetChunks().ToList();
5656

5757
// Assert
58-
Assert.That(chunks.Count, Is.EqualTo(3)); // 1024 + 1024 + 452
59-
Assert.That(chunks[0].Length, Is.EqualTo(chunkSize));
60-
Assert.That(chunks[1].Length, Is.EqualTo(chunkSize));
61-
Assert.That(chunks[2].Length, Is.EqualTo(totalSize - 2 * chunkSize));
58+
Assert.That(chunks, Has.Count.EqualTo(3)); // 1024 + 1024 + 452
59+
using (Assert.EnterMultipleScope())
60+
{
61+
Assert.That(chunks[0].Length, Is.EqualTo(chunkSize));
62+
Assert.That(chunks[1].Length, Is.EqualTo(chunkSize));
63+
Assert.That(chunks[2].Length, Is.EqualTo(totalSize - 2 * chunkSize));
64+
}
6265

6366
// Verify content of last chunk (do not dispose before reading)
6467
var last = chunks[2];
@@ -79,7 +82,7 @@ public void GetChunks_FinalChunkIsSmaller_WhenLengthNotMultipleOfChunkSize()
7982
public void GetChunks_EmptyStream_ReturnsNoChunks()
8083
{
8184
// Arrange
82-
using var baseStream = new MemoryStream(Array.Empty<byte>());
85+
using var baseStream = new MemoryStream([]);
8386
using var chunked = new ChunkedStream(baseStream, chunkSize: 1024);
8487

8588
// Act
@@ -105,7 +108,7 @@ public void Chunks_AreIndependentStreams_AtPositionZero()
105108
{
106109
using (chunk)
107110
{
108-
Assert.That(chunk.Position, Is.EqualTo(0));
111+
Assert.That(chunk.Position, Is.Zero);
109112
// Move position and ensure other chunks unaffected
110113
chunk.Position = Math.Min(10, chunk.Length);
111114
}

0 commit comments

Comments
 (0)