change favorites change endpoints (geosolutions-it#12005)

Author: rowheat02

web/client/api/GeoStoreDAO.js

@@ -652,23 +652,21 @@ const Api = {
         return axios.delete(url, Api.addBaseUrl(parseOptions(options))).then((response) => response.data);
     },
     /**
-     * add a resource to user favorites
-     * @param  {string} userId user identifier
+     * add a resource to user favorites (current logged user)
      * @param  {string} resourceId resource identifier
      * @param  {object} options additional axios options
      */
-    addFavoriteResource: (userId, resourceId, options) => {
-        const url = `/users/user/${userId}/favorite/${resourceId}`;
+    addFavoriteResource: (resourceId, options) => {
+        const url = `/users/user/favorite/${resourceId}`;
         return axios.post(url, undefined, Api.addBaseUrl(parseOptions(options))).then((response) => response.data);
     },
     /**
-     * remove a resource from user favorites
-     * @param  {string} userId user identifier
+     * remove a resource from user favorites (current logged user)
      * @param  {string} resourceId resource identifier
      * @param  {object} options additional axios options
      */
-    removeFavoriteResource: (userId, resourceId, options) => {
-        const url = `/users/user/${userId}/favorite/${resourceId}`;
+    removeFavoriteResource: (resourceId, options) => {
+        const url = `/users/user/favorite/${resourceId}`;
         return axios.delete(url, Api.addBaseUrl(parseOptions(options))).then((response) => response.data);
     },
     getIPRanges: function(options = {}) {

web/client/api/__tests__/GeoStoreDAO-test.jsx

@@ -508,25 +508,25 @@ describe('Test correctness of the GeoStore APIs', () => {
     it('addFavoriteResource', (done) => {
         mockAxios.onPost().reply((data) => {
             try {
-                expect(data.url).toEqual('/users/user/10/favorite/15');
+                expect(data.url).toEqual('/users/user/favorite/15');
                 done();
             } catch (e) {
                 done(e);
             }
             return [200];
         });
-        API.addFavoriteResource("10", "15");
+        API.addFavoriteResource("15");
     });
     it('removeFavoriteResource', (done) => {
         mockAxios.onDelete().reply((data) => {
             try {
-                expect(data.url).toEqual('/users/user/10/favorite/15');
+                expect(data.url).toEqual('/users/user/favorite/15');
                 done();
             } catch (e) {
                 done(e);
             }
             return [200];
         });
-        API.removeFavoriteResource("10", "15");
+        API.removeFavoriteResource("15");
     });
 });

web/client/plugins/ResourcesCatalog/containers/Favorites.jsx

@@ -50,7 +50,7 @@ function Favorites({
             const promise = isFavorite
                 ? GeoStoreDAO.removeFavoriteResource
                 : GeoStoreDAO.addFavoriteResource;
-            promise(user?.id, resource?.id)
+            promise(resource?.id)
                 .then(() => isMounted(() => {
                     setIsFavorite(!isFavorite);
                     updateResource({ isFavorite: !isFavorite, id: resource?.id });

web/client/plugins/ResourcesCatalog/containers/__tests__/Favorites-test.jsx

@@ -37,7 +37,7 @@ describe('Favorites container', () => {
     it('should trigger addFavoriteResource', (done) => {
         mockAxios.onPost().reply((data) => {
             try {
-                expect(data.url).toEqual('/users/user/10/favorite/15');
+                expect(data.url).toEqual('/users/user/favorite/15');
             } catch (e) {
                 done(e);
             }
@@ -67,7 +67,7 @@ describe('Favorites container', () => {
     it('should trigger removeFavoriteResource', (done) => {
         mockAxios.onDelete().reply((data) => {
             try {
-                expect(data.url).toEqual('/users/user/10/favorite/15');
+                expect(data.url).toEqual('/users/user/favorite/15');
             } catch (e) {
                 done(e);
             }
@@ -97,7 +97,7 @@ describe('Favorites container', () => {
     it('should trigger onSearch if the query has the favorite f filter', (done) => {
         mockAxios.onPost().reply((data) => {
             try {
-                expect(data.url).toEqual('/users/user/10/favorite/15');
+                expect(data.url).toEqual('/users/user/favorite/15');
             } catch (e) {
                 done(e);
             }