Skip to content

Commit ffc1dd2

Browse files
authored
Merge pull request #39 from blocknotes/internal-improvements
Internal improvements
2 parents 54919ef + 1c61d06 commit ffc1dd2

4 files changed

Lines changed: 22 additions & 8 deletions

File tree

.github/workflows/specs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313

1414
strategy:
1515
matrix:
16-
ruby: ['2.6', '2.7', '3.0']
16+
ruby: ['2.5', '2.6', '2.7', '3.0']
1717

1818
steps:
1919
- name: Checkout repository

.rubocop.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,12 @@ RSpec/ExampleLength:
3434
RSpec/MultipleMemoizedHelpers:
3535
# default: 5
3636
Max: 6
37+
38+
RSpec/SubjectStub:
39+
Exclude:
40+
- spec/units/prawn_html/attributes_spec.rb
41+
42+
Style/OpenStructUse:
43+
Exclude:
44+
- lib/prawn_html/attributes.rb
45+
- spec/units/prawn_html/attributes_spec.rb

prawn-html.gemspec

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,17 @@ Gem::Specification.new do |spec|
99
spec.version = PrawnHtml::VERSION
1010
spec.summary = 'Prawn PDF - HTML renderer'
1111
spec.description = 'HTML to PDF with Prawn PDF'
12+
1213
spec.required_ruby_version = '>= 2.5.0'
1314

14-
spec.license = 'MIT'
15-
spec.authors = ['Mattia Roccoberton']
16-
spec.email = 'mat@blocknot.es'
17-
spec.homepage = 'https://github.com/blocknotes/prawn-html'
15+
spec.license = 'MIT'
16+
spec.authors = ['Mattia Roccoberton']
17+
spec.email = 'mat@blocknot.es'
18+
spec.homepage = 'https://github.com/blocknotes/prawn-html'
19+
20+
spec.metadata['homepage_uri'] = spec.homepage
21+
spec.metadata['source_code_uri'] = spec.homepage
22+
spec.metadata['rubygems_mfa_required'] = 'true'
1823

1924
spec.files = Dir['lib/**/*', 'LICENSE.txt', 'README.md']
2025
spec.require_paths = ['lib']

spec/units/prawn_html/utils_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,13 @@
127127
context 'with a nil value' do
128128
let(:value) { nil }
129129

130-
it { is_expected.to eq nil }
130+
it { is_expected.to be_nil }
131131
end
132132

133133
context 'with a blank string value' do
134134
let(:value) { '' }
135135

136-
it { is_expected.to eq nil }
136+
it { is_expected.to be_nil }
137137
end
138138

139139
context 'with a string value (ex. "some_string")' do
@@ -161,7 +161,7 @@
161161
context 'with an invalid value (ex. "some_string")' do
162162
let(:value) { 'some_string' }
163163

164-
it { is_expected.to eq nil }
164+
it { is_expected.to be_nil }
165165
end
166166

167167
context 'with a valid value (ex. " bOlD ")' do

0 commit comments

Comments
 (0)