Skip to content

Commit 9ce7831

Browse files
committed
chore: Minor update in DbService
1 parent 677d375 commit 9ce7831

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

lib/active_storage/service/db_service.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ def download(key, &block)
5050

5151
def download_chunk(key, range)
5252
instrument :download_chunk, key: key, range: range do
53+
# NOTE: from/size are derived from Range#begin and Range#size (always integers),
54+
# so string interpolation into SQL is safe here.
5355
from = range.begin + 1
5456
size = range.size
5557
args = adapter_sqlserver? || adapter_sqlite? ? "data, #{from}, #{size}" : "data FROM #{from} FOR #{size}"
@@ -81,7 +83,7 @@ def delete_prefixed(prefix)
8183
def exist?(key)
8284
instrument :exist, key: key do |payload|
8385
comment = "DBService#exist?"
84-
result = ::ActiveStorageDB::File.annotate(comment).where(ref: key).exists?
86+
result = ::ActiveStorageDB::File.annotate(comment).exists?(ref: key)
8587
payload[:exist] = result
8688
result
8789
end
@@ -172,7 +174,7 @@ def retrieve_file(key)
172174
def object_for(key, fields: nil)
173175
comment = "DBService#object_for"
174176
scope = ::ActiveStorageDB::File.annotate(comment)
175-
scope = scope.select(*fields) if fields
177+
scope = scope.select(fields) if fields
176178
scope.find_by(ref: key)
177179
end
178180

0 commit comments

Comments
 (0)