RuboCop improvements

Author: blocknotes

.hound.yml

@@ -1,20 +1,24 @@
 inherit_from:
+  - .rubocop_todo.yml
   - https://relaxed.ruby.style/rubocop.yml
 
+
+
 require: rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.5
+  NewCops: enable
   Exclude:
     - bin/*
     - db/schema.rb
     - spec/dummy/**/*
     - vendor/**/*
+  TargetRubyVersion: 2.7
 
 Gemspec/RequiredRubyVersion:
   Enabled: false
 
-Metrics/LineLength:
+Layout/LineLength:
   Enabled: true
   Max: 120
 

.rubocop.yml

@@ -0,0 +1,24 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2021-04-28 06:26:05 UTC using RuboCop version 1.13.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'spec/tasks/active_storage_db_tasks_spec.rb'
+
+# Offense count: 1
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/active_storage/service/db_service.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/KeywordParametersOrder:
+  Exclude:
+    - 'spec/requests/file_controller_spec.rb'

.rubocop_todo.yml

@@ -13,8 +13,8 @@ group :development, :test do
   gem 'pg', '~> 1.2'
   gem 'rspec_junit_formatter', '~> 0.4'
   gem 'rspec-rails', '~> 4.0'
-  gem 'rubocop', '~> 0.91'
-  gem 'rubocop-rspec', '~> 1.42'
+  gem 'rubocop', '1.13'
+  gem 'rubocop-rspec', '2.2.0'
   gem 'selenium-webdriver', '~> 3.142'
   gem 'simplecov', '~> 0.18'
 

Gemfile

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-shared_context 'rake context' do
+shared_context 'with rake tasks' do
   Rails.application.load_tasks
 
   def execute_task(task, args = nil)

spec/support/shared_contexts/rake_context.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-RSpec.describe 'active_storage_db_tasks' do
-  include_context 'rake context'
+RSpec.describe 'ActiveStorageDB tasks' do # rubocop:disable RSpec/DescribeClass
+  include_context 'with rake tasks'
 
   describe 'asdb:ls' do
     subject(:task) { execute_task('asdb:ls') }