Fix: issues found by Claude.

Author: bjones1

CHANGELOG.md

@@ -22,7 +22,30 @@ Changelog
 [Github master](https://github.com/bjones1/CodeChat_Editor)
 -----------------------------------------------------------
 
-* No changes.
+* Claude code reviews revealed the following issues, which were fixed manually:
+  * Fix multi-byte Unicode encoding bug.
+  * Fix incorrect websocket shutdown sequence.
+  * On websocket disconnect and reconnect, correctly retain timeouts for
+    responses.
+  * Change websocket response timeout to a reasonable value.
+  * Provide better error reporting when `hashLocations.json` file isn't found.
+  * Improve encoder performance.
+  * Correct bug in diff computation.
+  * Correctly handle CRLFs in files that begin with a LF.
+  * Fix several XSS vulnerabilities.
+  * Remove redundant reference counting on shared state.
+  * Avoid panics when validating passwords and when converting paths to strings.
+  * Fix bugs in nested comment parser.
+  * Improve CLI interface with better userid/password parsing, error reporting,
+    and ipv6 support.
+  * Include Windows drive letter Z when looking for available drives.
+  * Use block comment delimiter found in code, not a hard-coded C-only
+    delimiter.
+  * Correct many errors in the grammar for supported languages.
+  * Add lexer support for shell scripts, Swift, TOML, and Verilog, and VHDL.
+  * Ensure math is re-typeset after saving the document.
+  * Delay math un-typesetting until all typesetting is complete.
+  * Improve error reporting in VSCode extension.
 
 Version 0.1.52 -- 2026-Apr-09
 -----------------------------

builder/src/main.rs

@@ -249,7 +249,7 @@ fn quick_copy_dir<P: AsRef<Path>>(src: P, dest: P, files: Option<P>) -> io::Resu
     // Per
     // [these docs](https://learn.microsoft.com/en-us/troubleshoot/windows-server/backup-and-storage/return-codes-used-robocopy-utility),
     // check the return code.
-    if cfg!(windows) && exit_code >= 8 || !cfg!(windows) && exit_code != 0 {
+    if (cfg!(windows) && exit_code >= 8) || (!cfg!(windows) && exit_code != 0) {
         Err(io::Error::other(format!(
             "Copy process return code {exit_code} indicates failure."
         )))
@@ -271,6 +271,8 @@ fn remove_dir_all_if_exists<P: AsRef<Path> + std::fmt::Display>(path: P) -> io::
     Ok(())
 }
 
+/// Search and replace a file using the regex. It's currently only used to
+/// update the version of a file; it does only one replacement.
 fn search_and_replace_file<
     P: AsRef<Path> + std::fmt::Display,
     S1: AsRef<str> + std::fmt::Display,
@@ -283,6 +285,8 @@ fn search_and_replace_file<
     let file_contents = fs::read_to_string(&path)?;
     let re = Regex::new(search_regex.as_ref())
         .map_err(|err| io::Error::other(format!("Error in search regex {search_regex}: {err}")))?;
+    // Note that this does only one replacement -- there should be exactly one
+    // version number to replace in a file.
     let file_contents_replaced = re.replace(&file_contents, replace_string.as_ref());
     assert_ne!(
         file_contents, file_contents_replaced,
@@ -413,7 +417,7 @@ fn run_install(dev: bool) -> io::Result<()> {
             cargo binstall cargo-outdated --no-confirm;
             info "cargo binstall cargo-sort";
             cargo binstall cargo-sort --no-confirm;
-            info "cargo binstall cargo-audio";
+            info "cargo binstall cargo-audit";
             cargo binstall cargo-audit --no-confirm;
         )?;
     }
@@ -427,7 +431,7 @@ fn run_update() -> io::Result<()> {
     run_cmd!(
         info "Builder: cargo update";
         cargo update --manifest-path=$BUILDER_PATH/Cargo.toml;
-        info "VSCoe extension: cargo update";
+        info "VSCode extension: cargo update";
         cargo update --manifest-path=$VSCODE_PATH/Cargo.toml;
         info "test_utils: cargo update"
         cargo update --manifest-path=$TEST_UTILS_PATH/Cargo.toml;
@@ -478,7 +482,7 @@ fn run_format_and_lint(check_only: bool) -> io::Result<()> {
         cargo audit --file=$BUILDER_PATH/Cargo.lock --no-fetch;
         info "VSCode extension: cargo audit";
         cargo audit --file=$VSCODE_PATH/Cargo.lock --no-fetch;
-        info "test_utils: cargo clippy and fmt"
+        info "test_utils: cargo audit"
         cargo audit --file=$TEST_UTILS_PATH/Cargo.lock --no-fetch;
 
         info "cargo sort";
@@ -578,7 +582,7 @@ fn run_client_build(
         true,
     )?;
 
-    // \<a id="#pdf.js>The PDF viewer for use with VSCode. Built it separately,
+    // \<a id="#pdf.js>The PDF viewer for use with VSCode. Build it separately,
     // since it's loaded apart from the rest of the Client.
     run_script(
         &esbuild,

client/package.json5

@@ -60,6 +60,8 @@
         '@codemirror/lang-sql': '^6.10.0',
         '@codemirror/lang-xml': '^6.1.0',
         '@codemirror/lang-yaml': '^6.1.3',
+        '@codemirror/language': '^6.12.3',
+        '@codemirror/legacy-modes': '^6.5.2',
         '@codemirror/state': '^6.6.0',
         '@codemirror/view': '6.38.8',
         '@hpcc-js/wasm-graphviz': '^1.21.2',
@@ -79,20 +81,20 @@
         '@types/mocha': '^10.0.10',
         '@types/node': '^24.12.2',
         '@types/toastify-js': '^1.12.4',
-        '@typescript-eslint/eslint-plugin': '^8.58.1',
-        '@typescript-eslint/parser': '^8.58.1',
+        '@typescript-eslint/eslint-plugin': '^8.58.2',
+        '@typescript-eslint/parser': '^8.58.2',
         chai: '^6.2.2',
         esbuild: '^0.28.0',
         eslint: '^10.2.0',
         'eslint-config-prettier': '^10.1.8',
         'eslint-plugin-import': '^2.32.0',
         'eslint-plugin-prettier': '^5.5.5',
-        globals: '^17.4.0',
+        globals: '^17.5.0',
         mocha: '^11.7.5',
-        'npm-check-updates': '^20.0.0',
-        prettier: '^3.8.1',
+        'npm-check-updates': '^20.0.2',
+        prettier: '^3.8.2',
         typescript: '^6.0.2',
-        'typescript-eslint': '^8.58.1',
+        'typescript-eslint': '^8.58.2',
     },
     scripts: {
         test: 'echo "Error: no test specified" && exit 1',

client/src/CodeChatEditor-test.mts

@@ -27,7 +27,7 @@ import "mocha/mocha.js";
 import "mocha/mocha.css";
 import { EditorView } from "@codemirror/view";
 import { ChangeSpec, EditorState, EditorSelection } from "@codemirror/state";
-import { CodeMirror, CodeMirrorDocBlockTuple } from "./shared_types.mjs";
+import { CodeMirror, CodeMirrorDocBlockTuple } from "./shared.mjs";
 import {
     DocBlockPlugin,
     CodeMirror_JSON_fields,

client/src/CodeChatEditor.mts

@@ -71,7 +71,7 @@ import {
     CodeMirror,
     autosave_timeout_ms,
     rand,
-} from "./shared_types.mjs";
+} from "./shared.mjs";
 import { show_toast } from "./show_toast.mjs";
 
 // ### CSS
@@ -257,10 +257,10 @@ const _open_lp = async (
         // Get the mode from the page's query parameters. Default to edit using
         // the
         // [nullish coalescing operator](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator).
-        // TODO: this isn't typesafe, since the `mode` might not be a key of
-        // `EditorMode`.
-        /// @ts-expect-error("See above.")
-        const _editorMode = EditorMode[urlParams.get("mode") ?? "edit"];
+        const mode = urlParams.get("mode") ?? EditorMode.edit;
+        const _editorMode = Object.values(EditorMode).includes(mode)
+            ? mode
+            : EditorMode.edit;
 
         // Get the <code>[current_metadata](#current_metadata)</code> from the
         // provided `code_chat_for_web` struct and store it as a global
@@ -372,7 +372,11 @@ const _open_lp = async (
     }
 };
 
-const save_lp = async (is_dirty: boolean) => {
+const save_lp = async (
+    // Avoid relying on the global `is_dirty`, which may change during an
+    // `await`.
+    is_dirty_now: boolean,
+) => {
     const update: UpdateMessageContents = {
         // The Framework will fill in this value.
         file_path: "",
@@ -385,7 +389,7 @@ const save_lp = async (is_dirty: boolean) => {
     }
 
     // Add the contents only if the document is dirty.
-    if (is_dirty) {
+    if (is_dirty_now) {
         /// @ts-expect-error("Declare here; it will be completed later.")
         let code_mirror_diffable: CodeMirrorDiffable = {};
         if (is_doc_only()) {
@@ -394,20 +398,25 @@ const save_lp = async (is_dirty: boolean) => {
                 "CodeChat-body",
             ) as HTMLDivElement;
             mathJaxUnTypeset(codechat_body);
-            // To save a document only, simply get the HTML from the only Tiny
-            // MCE div. Update the `doc_contents` to stay in sync with the
-            // Server.
-            doc_content = tinymce.activeEditor!.save();
-            (
-                code_mirror_diffable as {
-                    Plain: CodeMirror;
-                }
-            ).Plain = {
-                doc: doc_content,
-                doc_blocks: [],
-            };
-            // Retypeset all math after saving the document.
-            await mathJaxTypeset(codechat_body);
+            // Use a try/finally to ensure that the document is retypeset even
+            // if errors occur.
+            try {
+                // To save a document only, simply get the HTML from the only
+                // Tiny MCE div. Update the `doc_contents` to stay in sync with
+                // the Server.
+                doc_content = tinymce.activeEditor!.save();
+                (
+                    code_mirror_diffable as {
+                        Plain: CodeMirror;
+                    }
+                ).Plain = {
+                    doc: doc_content,
+                    doc_blocks: [],
+                };
+            } finally {
+                // Retypeset all math after saving the document.
+                await mathJaxTypeset(codechat_body);
+            }
         } else {
             code_mirror_diffable = CodeMirror_save();
             assert("Plain" in code_mirror_diffable);
@@ -518,15 +527,6 @@ export const restoreSelection = ({
     }
 };
 
-// Per
-// [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Navigator/platform#examples),
-// here's the least bad way to choose between the control key and the command
-// key.
-const _os_is_osx =
-    navigator.platform.indexOf("Mac") === 0 || navigator.platform === "iPhone"
-        ? true
-        : false;
-
 // Save CodeChat Editor contents.
 const on_save = async (only_if_dirty: boolean = false) => {
     if (only_if_dirty && !is_dirty) {

client/src/CodeChatEditorFramework.mts

@@ -17,7 +17,7 @@
 // `CodeChatEditorFramework.mts` -- the CodeChat Editor Client Framework
 // =====================================================================
 //
-// This maintains a websocket connection between the CodeChat Editor Server. The
+// This maintains a websocket connection with the CodeChat Editor Server. The
 // accompanying HTML is a full-screen iframe, allowing the Framework to change
 // or update the webpage in response to messages received from the websocket, or
 // to report navigation events to as a websocket message when the iframe's
@@ -40,7 +40,7 @@ import {
     KeysOfRustEnum,
     MessageResult,
     UpdateMessageContents,
-} from "./shared_types.mjs";
+} from "./shared.mjs";
 import {
     console_log,
     on_error,
@@ -207,6 +207,7 @@ class WebSocketComm {
                                     contents,
                                     current_update.is_re_translation,
                                     current_update.cursor_position,
+                                    current_update.scroll_position,
                                 );
                             } else {
                                 // If the page is still loading, wait until the
@@ -285,8 +286,7 @@ class WebSocketComm {
                     // `pending_messages`.
                     const pending_message = this.pending_messages[id];
                     if (pending_message !== undefined) {
-                        const { timer_id, callback } =
-                            this.pending_messages[id];
+                        const { timer_id, callback } = pending_message;
                         clearTimeout(timer_id);
                         callback();
                         delete this.pending_messages[id];
@@ -523,7 +523,7 @@ export const format_struct = (complex_data_structure: any): string =>
 /*eslint-disable-next-line @typescript-eslint/no-explicit-any */
 const report_error = (text: string, ...objs: any) => {
     console.error(text);
-    if (objs !== undefined) {
+    if (objs.length > 0) {
         console.log(...objs);
     }
     show_toast(text);