fix(electrum): always enable domain validation internally

Signed-off-by: Rahamath-Unnisa <rahamathunnisa287@gmail.com>

Author: Rahamath-unnisa

Cargo.lock

@@ -22,14 +22,11 @@ serde_json = "1.0"
 thiserror = "2.0.18"
 tokio = { version = "1", features = ["full"] }
 cli-table = "0.5.0"
-tracing = "0.1.44"
-tracing-subscriber = "0.3.20"
-toml = "1.1.0"
-serde= {version = "1.0", features = ["derive"]}
 
+bdk_electrum = { version = "0.23.0", optional = true }
 # Optional dependencies
 bdk_bitcoind_rpc = { version = "0.21.0", features = ["std"], optional = true }
-bdk_electrum = { version = "0.23.2", optional = true }
+
 bdk_esplora = { version = "0.22.1", features = ["async-https", "tokio"], optional = true }
 bdk_kyoto = { version = "0.15.4", optional = true }
 bdk_redb = { version = "0.1.1", optional = true }

Cargo.toml

@@ -269,7 +269,7 @@ pub struct WalletOpts {
     #[cfg(feature = "electrum")]
     #[arg(env = "ELECTRUM_BATCH_SIZE", short = 'b', long, default_value = "10")]
     pub batch_size: usize,
-    
+
     /// Esplora parallel requests.
     #[cfg(feature = "esplora")]
     #[arg(

src/commands.rs

@@ -634,11 +634,7 @@ pub(crate) async fn handle_online_wallet_subcommand(
             });
             match client {
                 #[cfg(feature = "electrum")]
-                Electrum {
-                    client,
-                    batch_size,
-                    validate_domain: _,
-                } => {
+                Electrum { client, batch_size } => {
                     // Populate the electrum client's transaction cache so it doesn't re-download transaction we
                     // already have.
                     client
@@ -716,11 +712,7 @@ pub(crate) async fn handle_online_wallet_subcommand(
 
             match client {
                 #[cfg(feature = "electrum")]
-                Electrum {
-                    client,
-                    batch_size,
-                    validate_domain,
-                } => {
+                Electrum { client, batch_size } => {
                     // Populate the electrum client's transaction cache so it doesn't re-download transaction we
                     // already have.
                     client
@@ -813,7 +805,6 @@ pub(crate) async fn handle_online_wallet_subcommand(
                 Electrum {
                     client,
                     batch_size: _,
-                    validate_domain,
                 } => client
                     .transaction_broadcast(&tx)
                     .map_err(|e| Error::Generic(e.to_string()))?,

src/handlers.rs

@@ -12,6 +12,7 @@
 
 use crate::commands::WalletOpts;
 use crate::error::BDKCliError as Error;
+use bdk_electrum::electrum_client::ConfigBuilder;
 #[cfg(feature = "cbf")]
 use bdk_kyoto::{
     BuilderExt, Info, LightClient, Receiver, ScanType::Sync, UnboundedReceiver, Warning,
@@ -20,7 +21,6 @@ use bdk_kyoto::{
 
 
 use bdk_wallet::bitcoin::{Address, Network, OutPoint, ScriptBuf};
-use electrum_client::ConfigBuilder;
 use std::fmt::Display;
 use std::path::{Path, PathBuf};
 use std::str::FromStr;
@@ -136,7 +136,6 @@ pub(crate) enum BlockchainClient {
     Electrum {
         client: Box<bdk_electrum::BdkElectrumClient<bdk_electrum::electrum_client::Client>>,
         batch_size: usize,
-        validate_domain: bool,
     },
     #[cfg(feature = "esplora")]
     Esplora {
@@ -177,15 +176,12 @@ pub(crate) fn new_blockchain_client(
     let client = match wallet_opts.client_type {
         #[cfg(feature = "electrum")]
         ClientType::Electrum => {
-            let config = ConfigBuilder::new()
-                .validate_domain(wallet_opts.validate_domain)
-                .build();
+            let config = ConfigBuilder::new().build();
             let client = bdk_electrum::electrum_client::Client::from_config(url, config)
                 .map(bdk_electrum::BdkElectrumClient::new)?;
             BlockchainClient::Electrum {
                 client: Box::new(client),
                 batch_size: wallet_opts.batch_size,
-                validate_domain: wallet_opts.validate_domain,
             }
         }
         #[cfg(feature = "esplora")]