Skip to content

Commit 4799c86

Browse files
committed
[MSVCRT_APITEST] Fix test condition for strtoul on ReactOS
Wine msvcrt behaves like Vista+ here. Also disable related static_crt tests, because it isn't even well defined how they should behave and what to compare it to.
1 parent ff7fdcf commit 4799c86

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

modules/rostests/apitests/crt/tcstoul.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,11 @@ START_TEST(tcstoul)
6363

6464
StartSeh()
6565
Result = _tcstoul(NULL, NULL, 0);
66-
EndSeh((GetNTVersion() >= _WIN32_WINNT_VISTA) ? 0 : STATUS_ACCESS_VIOLATION);
66+
#ifdef TEST_CRTDLL
67+
EndSeh(STATUS_ACCESS_VIOLATION);
68+
#else
69+
EndSeh(((GetNTVersion() >= _WIN32_WINNT_VISTA) || is_reactos()) ? 0 : STATUS_ACCESS_VIOLATION);
70+
#endif
6771

6872
StartSeh()
6973
Result = _tcstoul(_T(""), NULL, 0);

modules/rostests/apitests/crt/testlist.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ const struct test winetest_testlist[] =
5656
{ "sprintf", func_sprintf },
5757
{ "strcpy", func_strcpy },
5858
{ "strlen", func_strlen },
59-
{ "strtoul", func_strtoul },
60-
{ "wcstoul", func_wcstoul },
59+
//{ "strtoul", func_strtoul },
60+
//{ "wcstoul", func_wcstoul },
6161
{ "wctomb", func_wctomb },
6262
{ "wcstombs", func_wcstombs },
6363
{ "ceil", func_ceil },

0 commit comments

Comments
 (0)