fix sql stats in case multiples values with the same objectId are passed in input

Author: derlin

README.md

@@ -68,7 +68,7 @@ Currently available profiles (see the class `ch.derlin.bbdata.api.Profiles`):
 * `input`: will only register the "input" endpoint (`POST /objects/values`);
 * `output`: will only register the "output" endpoints (everything BUT the one above);
 * `noc`: short for "_No Cassandra_". It won't register endpoints needing a Cassandra connection (input and values);
-* `sqlstats`: use MySQL to store objects statistics, instead of Cassandra
+* `sqlstats`: use MySQL to store objects statistics, instead of Cassandra **BEWARE** this is waaaay slower !!
 
 Profiles can be combined (when it makes sense).
 

src/main/kotlin/ch/derlin/bbdata/common/stats/StatsLogic.kt

@@ -94,16 +94,22 @@ class SqlStatsLogic(private val statsRepository: SqlStatsRepository) : StatsLogi
     }
 
     override fun updateAllStats(vs: List<NewValue>) {
+        // get all unique objects whose objectIds are in vs
+        val stats = vs.map { it.objectId!! }.toSet().map{ objectId ->
+            objectId to statsRepository.findById(objectId).orElse(SqlStats(objectId = objectId))
+        }.toMap()
+
+        // update each: this will also work when multiple values target the same object
+        vs.forEach {
+            stats[it.objectId]!!.updateWithNewValue(it)
+        }
+
         // use the bulk save option of MySQL repositories to speed up the process
-        statsRepository.saveAll(vs.map { v ->
-            val stats = statsRepository.findById(v.objectId!!).orElse(SqlStats(objectId = v.objectId))
-            stats.updateWithNewValue(v)
-            stats
-        })
+        statsRepository.saveAll(stats.values)
     }
 
     override fun incrementReadCounter(objectId: Long) {
-        val stats = statsRepository.findById(objectId).orElseGet{ SqlStats(objectId = objectId) }
+        val stats = statsRepository.findById(objectId).orElse(SqlStats(objectId = objectId))
         stats.nReads += 1
         statsRepository.save(stats)
     }