go through (and fix) warnings from IntelliJ

Author: derlin

src/main/kotlin/ch/derlin/bbdata/AsyncConfig.kt

@@ -1,5 +1,6 @@
 package ch.derlin.bbdata
 
+import org.slf4j.Logger
 import org.slf4j.LoggerFactory
 import org.springframework.aop.interceptor.AsyncUncaughtExceptionHandler
 import org.springframework.beans.factory.annotation.Value
@@ -32,7 +33,7 @@ import java.util.concurrent.ThreadPoolExecutor
 class AsyncExecutorCustomizer : TaskExecutorCustomizer {
     @Value("\${spring.task.execution.pool.queue-capacity}")
     val queueCapacity: Int = -1
-    val logger = LoggerFactory.getLogger(AsyncExecutorCustomizer::class.java)
+    val logger: Logger = LoggerFactory.getLogger(AsyncExecutorCustomizer::class.java)
 
     override fun customize(taskExecutor: ThreadPoolTaskExecutor?) {
         taskExecutor?.let { executor ->
@@ -55,14 +56,14 @@ class AsyncConfig : AsyncConfigurer {
 
 class AsyncExceptionHandler : AsyncUncaughtExceptionHandler {
 
-    val logger = LoggerFactory.getLogger(AsyncExceptionHandler::class.java)
+    val logger: Logger = LoggerFactory.getLogger(AsyncExceptionHandler::class.java)
 
     /**
      * Ensure we get the exception logged.
      * Attention: this will be called only on async method with void return type !
      */
     override fun handleUncaughtException(throwable: Throwable, method: Method, vararg params: Any) {
-        val niceParams = params.take(2).map { it.toString() }.joinToString(",")
+        val niceParams = params.take(2).joinToString(",") { it.toString() }
         logger.error("in ${method.name} with ${params.size} params: $niceParams ...", throwable)
     }
 }

src/main/kotlin/ch/derlin/bbdata/BBDataApplication.kt

@@ -22,6 +22,7 @@ import org.springframework.transaction.annotation.EnableTransactionManagement
 import org.springframework.web.servlet.config.annotation.CorsRegistry
 import org.springframework.web.servlet.config.annotation.WebMvcConfigurer
 import javax.annotation.PostConstruct
+import kotlin.system.exitProcess
 
 
 @SpringBootApplication
@@ -107,7 +108,7 @@ class CachingConfig {
             // forbid in-memory caching if launching the app in split mode (input only or output only)
             logger.error("Using in-memory caching with split application (input|output in different JVMs) can lead to security issues." +
                     "Please, either disable caching or use an external cache such as redis.")
-            System.exit(1)
+            exitProcess(1)
         }
     }
 }

src/main/kotlin/ch/derlin/bbdata/Excluders.kt

@@ -43,7 +43,7 @@ class ExcludeAutoConfigPostProcessor : EnvironmentPostProcessor {
     var logger: DeferredLog = DeferredLog()
 
     companion object {
-        val PROP = "spring.autoconfigure.exclude"
+        const val PROP = "spring.autoconfigure.exclude"
     }
 
     override fun postProcessEnvironment(env: ConfigurableEnvironment, application: SpringApplication) {

src/main/kotlin/ch/derlin/bbdata/common/cassandra/CTypeResolver.kt

@@ -27,7 +27,7 @@ annotation class CType
 @Component
 class ContentTypeHandlerMethodArgumentResolver : HandlerMethodArgumentResolver {
     override fun supportsParameter(methodParameter: MethodParameter): Boolean {
-        return methodParameter.getParameterType().equals(String::class.java) &&
+        return methodParameter.parameterType == String::class.java &&
                 methodParameter.hasParameterAnnotation(CType::class.java)
     }
 

src/main/kotlin/ch/derlin/bbdata/common/cassandra/CassandraUtils.kt

@@ -1,6 +1,7 @@
 package ch.derlin.bbdata.common.cassandra
 
 import org.joda.time.YearMonth
+import org.joda.time.format.DateTimeFormatter
 
 /**
  * date: 19.12.19
@@ -9,17 +10,17 @@ import org.joda.time.YearMonth
 
 
 object CassandraUtils {
-    val YM_FORMAT = org.joda.time.format.DateTimeFormat.forPattern("yyyy-MM")
+    val YM_FORMAT: DateTimeFormatter = org.joda.time.format.DateTimeFormat.forPattern("yyyy-MM")
 
     fun xMonthsFrom(d1: YearMonth, x: Int): List<String> {
         val ym = YearMonth(d1)
         return monthsBetween(ym.minusMonths(x), ym)
     }
 
-    fun monthsBetween(d1: YearMonth, d2: YearMonth? = null): List<String> {
+    fun monthsBetween(d1: YearMonth, optionalD2: YearMonth? = null): List<String> {
         val months = mutableListOf<String>()
-        var d2 = d2 ?: YearMonth.now()
-        while (d1.compareTo(d2) <= 0) {
+        var d2 = optionalD2 ?: YearMonth.now()
+        while (d1 <= d2) {
             months.add(YM_FORMAT.print(d2))
             d2 = d2.minusMonths(1)
         }

src/main/kotlin/ch/derlin/bbdata/common/dates/DurationParser.kt

@@ -24,7 +24,7 @@ object DurationParser {
     /**
      * Parse a duration string.
      *
-     * @param periodString the duration string
+     * @param durationString the duration string
      * @return the period object, or a zero period if the parsing failed.
      */
     fun parse(durationString: String): MutablePeriod {

src/main/kotlin/ch/derlin/bbdata/common/dates/JodaUtils.kt

@@ -15,9 +15,9 @@ import java.util.*
  */
 object JodaUtils {
 
-    val FMT_ISO_MINUTES = "yyyy-MM-dd'T'HH:mm'Z'"
-    val FMT_ISO_SECONDS = "yyyy-MM-dd'T'HH:mm:ss'Z'"
-    val FMT_ISO_MILLIS = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"
+    const val FMT_ISO_MINUTES = "yyyy-MM-dd'T'HH:mm'Z'"
+    const val FMT_ISO_SECONDS = "yyyy-MM-dd'T'HH:mm:ss'Z'"
+    const val FMT_ISO_MILLIS = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"
 
     var defaultPattern: String = FMT_ISO_MILLIS
         set(value) {

src/main/kotlin/ch/derlin/bbdata/common/exceptions/ExceptionAdviser.kt

@@ -43,8 +43,8 @@ class ErrorAttributes : DefaultErrorAttributes() {
     override fun getErrorAttributes(webRequest: WebRequest, includeStackTrace: Boolean): Map<String, Any?> {
         val attrs = super.getErrorAttributes(webRequest, false)
         return mapOf(
-                "exception" to attrs.get("error"),
-                "details" to attrs.get("message"))
+                "exception" to attrs["error"],
+                "details" to attrs["message"])
     }
 }
 
@@ -99,20 +99,23 @@ class GlobalControllerExceptionHandler : ResponseEntityExceptionHandler() {
 
         fun List<ObjectError>.body(): ExceptionBody = ExceptionBody(
                 exception = WrongParamsException::class.simpleName.toString(),
-                details = this.associateBy({ (it as FieldError).getField() }, { it.defaultMessage })
+                details = this.associateBy({ (it as FieldError).field }, { it.defaultMessage })
         )
 
         fun DataIntegrityViolationException.body(): ExceptionBody =
                 (this.cause as? ConstraintViolationException)?.sqlException?.let {
                     val sqlMsg = it.message ?: ""
-                    val (name, msg) =
-                            if ("foreign key constraint fails" in sqlMsg) {
-                                "ForeignKeyException" to "A field references a non-existing resource."
-                            } else if ("Duplicate entry" in sqlMsg) {
-                                "DuplicateFieldException" to "value ${sqlMsg.split(" ")[2]} already exists."
-                            } else {
-                                "SqlException" to sqlMsg
-                            }
+                    val (name, msg) = when {
+                        "foreign key constraint fails" in sqlMsg -> {
+                            "ForeignKeyException" to "A field references a non-existing resource."
+                        }
+                        "Duplicate entry" in sqlMsg -> {
+                            "DuplicateFieldException" to "value ${sqlMsg.split(" ")[2]} already exists."
+                        }
+                        else -> {
+                            "SqlException" to sqlMsg
+                        }
+                    }
                     ExceptionBody(name, msg)
                 } ?: ExceptionBody.fromThrowable(this)
     }

src/main/kotlin/ch/derlin/bbdata/common/exceptions/Exceptions.kt

@@ -11,7 +11,7 @@ open class AppException(val details: Any) : Throwable() {
 
 
 class ItemNotFoundException(itemName: String = "resource", msg: String? = null) :
-        AppException(msg ?: "The ${itemName} was not found or can't be accessed with this apikey.")
+        AppException(msg ?: "The $itemName was not found or can't be accessed with this apikey.")
 
 class UnauthorizedException(msg: String = "This resource is protected.") :
         AppException(msg)

src/main/kotlin/ch/derlin/bbdata/common/stats/SqlStats.kt

@@ -8,6 +8,7 @@ import javax.persistence.Column
 import javax.persistence.Entity
 import javax.persistence.Id
 import javax.persistence.Table
+import kotlin.math.abs
 
 /**
  * date: 25.05.20
@@ -37,7 +38,7 @@ data class SqlStats(
 ) {
     fun updateWithNewValue(v: NewValue) {
         if (nWrites > 0L) {
-            val deltaMs = Math.abs(v.timestamp!!.millis - lastTs!!.millis)
+            val deltaMs = abs(v.timestamp!!.millis - lastTs!!.millis)
             avgSamplePeriod = (avgSamplePeriod * (nWrites - 1) + deltaMs) / nWrites
         }