Skip to content

Commit 70eb13f

Browse files
committed
Auditing mpeg4 box types
1 parent c477378 commit 70eb13f

1 file changed

Lines changed: 20 additions & 8 deletions

File tree

src/mpeg4/mpeg4BoxType.ts

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
import {ByteVector, StringType} from "../byteVector";
22

33
/**
4-
* Provides references to different box types used by the library. This class is used to severely reduce the number
5-
* of times these types are created in {@link AppleTag,} greatly improving the speed at which warm files are read.
4+
* Provides references to different box types used by the library. This class is used to severely
5+
* reduce the number of times these types are created in {@link AppleTag,} greatly improving the
6+
* speed at which warm files are read.
7+
*
8+
* These box types were cross-referenced with FFMPEG source and Exiftool database.
69
*/
710
export default class Mpeg4BoxType {
811
/** QuickTime album artist box */
@@ -13,8 +16,11 @@ export default class Mpeg4BoxType {
1316
public static readonly ART = this.getType("©ART");
1417
/** QuickTime comment box */
1518
public static readonly CMT = this.getType("©cmt");
16-
/** QuickTime conductor box? @TODO: Verify this works should not be ©con */
17-
public static readonly COND = this.getType("cond");
19+
/**
20+
* QuickTime conductor box
21+
* @remarks "cond" in .NET source, but Exiftool says should be ©con.
22+
*/
23+
public static readonly COND = this.getType("©con");
1824
/** QuickTime cover art box */
1925
public static readonly COVR = this.getType("covr");
2026
/** ISO 64-bit chunk offset box */
@@ -91,19 +97,25 @@ export default class Mpeg4BoxType {
9197
public static readonly STCO = this.getType("stco");
9298
/** ISO sample description box */
9399
public static readonly STSD = this.getType("stsd");
94-
/** Subtitle box? @TODO: There's no record of this one */
95-
public static readonly SUBT = this.getType("Subt");
100+
/**
101+
* QuickTime subtitle box
102+
* @remarks "Subt" in .NET source, but this appears to be for subtitle tracks, not metadata.
103+
*/
104+
public static readonly SUBT = this.getType("©st3");
96105
/** Alias text box? @TODO: There's no record of this one */
97106
public static readonly TEXT = this.getType("text");
98107
/** QuickTime BPM box */
99108
public static readonly TMPO = this.getType("tmpo");
100109
/** ISO track container box */
101110
public static readonly TRAK = this.getType("trak");
102-
/** QuickTime track number box */
111+
/** QuickTime track number box @TODO: What about ©TRK as per FFMPEG source? */
103112
public static readonly TRKN = this.getType("trkn");
104113
/** ISO User data box */
105114
public static readonly UDTA = this.getType("udta");
106-
/** Alias URL box? @TODO: There's no record of this one */
115+
/**
116+
* Alias URL box?
117+
* @remarks Specified in FFMPEG source but no in Exiftool.
118+
*/
107119
public static readonly URL = this.getType("©url");
108120
/** ISO user extension box */
109121
public static readonly UUID = this.getType("uuid");

0 commit comments

Comments
 (0)