Commit 4e5a797
Benjamin Russell
Fix MP3 VBR Headers (#113)
**Description**: This is basically a rewrite of the VBR header implementation for MP3 files. It offers a much more robust solution for determining duration of MP3s and best efforts at determining MP3 bitrates.
**Testing**: Brand new testing of the VBR headers and MPEG audio headers
---
* Code for reading VBR headers is waaaaay improved. Only thing remaining is taking into consideration encoder delays from sample count
* Incorporate encoder delay/padding from LAME headers
* Incorporate delay for VBRI headers
* Adding sample files
* Working on tests...
* 100% coverage of MpegAudioHeader
* Unit tests for VBRI headers
* Unit tests for VBR headers
* Updating MPEG header to prevent reserved bitrate/audio sample rates from being propagated
* Rollback "allow zero" changes, patch up the rest of the unit tests
* Removing properties tests from mp3 id3vx tests
* Fix MPEG audio stream detection
ALSO UNCOVER A HUGE BUG IN APE FILE INTEGRATION TESTS??? WTF
* Fixing a thing after merging develop
* Enabling one more test1 parent 39a345a commit 4e5a797
21 files changed
Lines changed: 1424 additions & 1165 deletions
File tree
- src
- mpeg
- test-integration
- resources/samples
- test-unit/mpeg
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
432 | 432 | | |
433 | 433 | | |
434 | 434 | | |
435 | | - | |
436 | | - | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
437 | 441 | | |
438 | 442 | | |
439 | 443 | | |
| |||
460 | 464 | | |
461 | 465 | | |
462 | 466 | | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
463 | 475 | | |
464 | 476 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | | - | |
37 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
38 | 41 | | |
39 | 42 | | |
40 | 43 | | |
41 | 44 | | |
42 | | - | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
| |||
0 commit comments