Merge pull request #394 from bear/feature/changes_to_tweet_counting

Changes to tweet counting

Author: jeremylow

Makefile

@@ -35,7 +35,7 @@ docs:
 	$(MAKE) -C doc html
 
 lint:
-	flake8 twitter > violations.flake8.txt
+	pycodestyle --config={toxinidir}/setup.cfg twitter tests
 
 test: lint
 	python setup.py test

README.rst

@@ -44,7 +44,7 @@ You can install python-twitter using::
 
     $ pip install python-twitter
 
-	
+
 If you are using python-twitter on Google App Engine, see `more information <GAE.rst>`_ about including 3rd party vendor library dependencies in your App Engine project.
 
 

doc/changes_to_tweet_counting.rst

@@ -0,0 +1,79 @@
+REST API Changes
+=================
+
+Information compiled on Sept 14, 2016.
+
+``statuses/update`` Endpoint
+----------------------------
+
+``auto_populate_reply_metadata``
++++++++++++++++++++++++++++++++
+
+* Default is ``false``
+
+* Must have ``in_reply_to_status_id`` set.
+
+* Unknown what happens if not set. Probably error (does it get posted?)
+
+* If the status to which you're replying is deleted, tweet will fail to post.
+
+``exclude_reply_user_ids``
+++++++++++++++++++++++++++
+
+* List of ``user_ids`` to remove from result of ``auto_populate_reply_metadata``.
+
+* Doesn't apply to the first ``user_id``.
+
+* If you try to remove it, this will be silently ignored by Twitter.
+
+``attachment_url``
+++++++++++++++++++
+
+* Must be a status permalnk or a DM deep link.
+
+* If it's anything else and included in this parameter, Twitter will return an error.
+
+
+Most Other Endpoints
+--------------------
+
+``tweet_mode``
+++++++++++++++
+
+* Any endpoint that returns a tweet will accept this param.
+
+* Must be in ``['compat', 'extended']``
+
+* If ``tweet_mode == 'compat'``, then no ``extended_tweet`` node in the json returned.
+
+* If ``tweet_mode == 'extended'``, then you'll get the ``extended_tweet`` node.
+
+
+Errors
+------
+* 44 -> URL passed to attachment_url is invalid
+
+* 385 -> Replied to deleted tweet or tweet not visible to you
+
+* 386 -> Too many attachments types (ie a GIF + quote tweet)
+
+
+Streaming API
+=============
+
+Everything is going to be compatibility mode for now; however **all** tweets with have an ``extended_tweet`` node, which will contain the new information. According to Twitter's documentation though, there's the possibility that this node may not exist. We should be careful about making assumptions here.
+
+
+Changes to Models
+=================
+
+Classic tweet: tweet with length < 140 char.
+Extended tweet: tweet with extended entities and text > 140 chars.
+
+Twitter doesn't say if extended tweet with a total length of < 140 characters will be considered a "Classic tweet". They also state that an extended tweet shall have "text content [that] exceeds 140 characters in length", however this is contradictory to earlier statements about total text length retaining a hard max at 140 characters.
+
+There will be two rendering modes: Compatibility and Extended. If in compatibility mode and tweet is "classic", no changes to tweet JSON. If in Extended mode, the following will change:
+
+* ``text`` -> truncated version of the extended tweet's text + "..." + permalink to tweet. (Twitter is mute on whether an extended tweet's with (text + @mentions + urls) < 140 characters will have the @mentions + urls put back in ``text`` field.)
+
+* ``truncated`` -> gets set to ``True`` if extended tweet is rendered in compat mode.

doc/conf.py

@@ -57,9 +57,9 @@
 # built documents.
 #
 # The short X.Y version.
-version = '3.1'
+version = '3.2'
 # The full version, including alpha/beta/rc tags.
-release = '3.1'
+release = '3.2dev0'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

requirements.testing.txt

@@ -7,7 +7,6 @@ pytest
 pytest-cov
 pytest-runner
 mccabe
-flake8
 mock
 six
 coverage

setup.cfg

@@ -8,8 +8,8 @@ ignore =
   violations.flake8.txt
 
 [flake8]
-ignore = E111,E124,E126,E201,E202,E221,E241,E302,E501
+ignore = E111,E124,E126,E221,E501
 
 [pep8]
-ignore = E111,E124,E126,E128,E201,E202,E221,E226,E241,E301,E302,E303,E402,E501,W291
-max-line-length = 160
+ignore = E111,E124,E126,E221,E501
+max-line-length = 100

testdata/3.2/extended_tweet_in_compat_mode.json

@@ -0,0 +1 @@
+{"contributors": null, "in_reply_to_status_id_str": null, "lang": "en", "source": "<a href=\"http://twitter.com\" rel=\"nofollow\">Twitter Web Client</a>", "in_reply_to_user_id": null, "possibly_sensitive_appealable": false, "coordinates": null, "truncated": true, "retweet_count": 0, "retweeted": false, "possibly_sensitive": false, "in_reply_to_user_id_str": null, "entities": {"symbols": [], "user_mentions": [], "urls": [{"expanded_url": "https://twitter.com/i/web/status/782737772490600448", "indices": [117, 140], "url": "https://t.co/et3OTOxWSa", "display_url": "twitter.com/i/web/status/7\u2026"}], "hashtags": []}, "geo": null, "is_quote_status": false, "favorite_count": 0, "id_str": "782737772490600448", "id": 782737772490600448, "created_at": "Mon Oct 03 00:23:22 +0000 2016", "text": "has more details about these changes.  Thanks for making more expressive!writing requirements to python_twitt pytho\u2026 https://t.co/et3OTOxWSa", "place": null, "in_reply_to_screen_name": null, "in_reply_to_status_id": null, "favorited": false, "user": {"follow_request_sent": false, "protected": true, "default_profile_image": true, "profile_sidebar_fill_color": "000000", "favourites_count": 1, "utc_offset": null, "has_extended_profile": false, "lang": "en", "profile_image_url": "http://abs.twimg.com/sticky/default_profile_images/default_profile_2_normal.png", "friends_count": 2, "profile_text_color": "000000", "geo_enabled": true, "profile_banner_url": "https://pbs.twimg.com/profile_banners/4012966701/1453123196", "verified": false, "listed_count": 1, "is_translator": false, "location": "", "entities": {"description": {"urls": []}}, "name": "notinourselves", "is_translation_enabled": false, "time_zone": null, "id_str": "4012966701", "profile_background_tile": false, "followers_count": 1, "profile_sidebar_border_color": "000000", "contributors_enabled": false, "following": false, "description": "", "url": null, "statuses_count": 84, "default_profile": false, "profile_link_color": "000000", "profile_image_url_https": "https://abs.twimg.com/sticky/default_profile_images/default_profile_2_normal.png", "notifications": false, "profile_background_image_url": "http://pbs.twimg.com/profile_background_images/736320724164448256/LgaAQoav.jpg", "screen_name": "notinourselves", "profile_background_image_url_https": "https://pbs.twimg.com/profile_background_images/736320724164448256/LgaAQoav.jpg", "id": 4012966701, "profile_use_background_image": true, "created_at": "Wed Oct 21 23:53:04 +0000 2015", "profile_background_color": "000000"}}

testdata/3.2/extended_tweet_in_extended_mode.json

@@ -0,0 +1 @@
+{"contributors": null, "in_reply_to_status_id_str": null, "lang": "en", "in_reply_to_user_id_str": null, "in_reply_to_user_id": null, "possibly_sensitive_appealable": false, "coordinates": null, "full_text": "has more details about these changes.  Thanks for making more expressive!writing requirements to python_twitt python_twitter.egg-info/SOURCE https://t.co/JWSPztfoyt", "truncated": false, "retweet_count": 0, "retweeted": false, "possibly_sensitive": false, "entities": {"symbols": [], "media": [{"id_str": "782737766455119872", "type": "photo", "media_url_https": "https://pbs.twimg.com/media/CtzX2fnXEAAMAjK.jpg", "display_url": "pic.twitter.com/JWSPztfoyt", "sizes": {"large": {"w": 1024, "resize": "fit", "h": 1024}, "thumb": {"w": 150, "resize": "crop", "h": 150}, "small": {"w": 680, "resize": "fit", "h": 680}, "medium": {"w": 1024, "resize": "fit", "h": 1024}}, "expanded_url": "https://twitter.com/notinourselves/status/782737772490600448/photo/1", "indices": [141, 164], "id": 782737766455119872, "url": "https://t.co/JWSPztfoyt", "media_url": "http://pbs.twimg.com/media/CtzX2fnXEAAMAjK.jpg"}], "user_mentions": [], "urls": [], "hashtags": []}, "geo": null, "is_quote_status": false, "favorite_count": 0, "id_str": "782737772490600448", "extended_entities": {"media": [{"id_str": "782737766455119872", "type": "photo", "media_url_https": "https://pbs.twimg.com/media/CtzX2fnXEAAMAjK.jpg", "display_url": "pic.twitter.com/JWSPztfoyt", "sizes": {"large": {"w": 1024, "resize": "fit", "h": 1024}, "thumb": {"w": 150, "resize": "crop", "h": 150}, "small": {"w": 680, "resize": "fit", "h": 680}, "medium": {"w": 1024, "resize": "fit", "h": 1024}}, "expanded_url": "https://twitter.com/notinourselves/status/782737772490600448/photo/1", "indices": [141, 164], "id": 782737766455119872, "url": "https://t.co/JWSPztfoyt", "media_url": "http://pbs.twimg.com/media/CtzX2fnXEAAMAjK.jpg", "ext_alt_text": null}]}, "created_at": "Mon Oct 03 00:23:22 +0000 2016", "source": "<a href=\"http://twitter.com\" rel=\"nofollow\">Twitter Web Client</a>", "place": null, "favorited": false, "in_reply_to_screen_name": null, "in_reply_to_status_id": null, "id": 782737772490600448, "display_text_range": [0, 140], "user": {"follow_request_sent": false, "protected": true, "default_profile_image": true, "profile_sidebar_fill_color": "000000", "favourites_count": 1, "utc_offset": null, "has_extended_profile": false, "lang": "en", "profile_image_url": "http://abs.twimg.com/sticky/default_profile_images/default_profile_2_normal.png", "friends_count": 2, "profile_text_color": "000000", "geo_enabled": true, "profile_banner_url": "https://pbs.twimg.com/profile_banners/4012966701/1453123196", "verified": false, "listed_count": 1, "is_translator": false, "location": "", "entities": {"description": {"urls": []}}, "name": "notinourselves", "is_translation_enabled": false, "time_zone": null, "id_str": "4012966701", "profile_background_tile": false, "followers_count": 1, "profile_sidebar_border_color": "000000", "contributors_enabled": false, "following": false, "description": "", "url": null, "statuses_count": 84, "default_profile": false, "profile_link_color": "000000", "profile_image_url_https": "https://abs.twimg.com/sticky/default_profile_images/default_profile_2_normal.png", "notifications": false, "profile_background_image_url": "http://pbs.twimg.com/profile_background_images/736320724164448256/LgaAQoav.jpg", "screen_name": "notinourselves", "profile_background_image_url_https": "https://pbs.twimg.com/profile_background_images/736320724164448256/LgaAQoav.jpg", "id": 4012966701, "profile_use_background_image": true, "created_at": "Wed Oct 21 23:53:04 +0000 2015", "profile_background_color": "000000"}}

tests/test_api.py

@@ -12,6 +12,7 @@
 ACCESS_TOKEN_KEY = os.getenv('ACCESS_TOKEN_KEY', None)
 ACCESS_TOKEN_SECRET = os.getenv('ACCESS_TOKEN_SECRET', None)
 
+
 @unittest.skipIf(not CONSUMER_KEY and not CONSUMER_SECRET, "No tokens provided")
 class ApiTest(unittest.TestCase):
     def setUp(self):