Extract PlantUML jar from asar before running

Author: beNative

electron/main.ts

@@ -546,6 +546,56 @@ function derivePlantumlFriendlyError(details?: string | null, exitCode?: number)
     return 'Local PlantUML renderer failed to produce output.';
 }
 
+function isPackagedAsarPath(filePath: string): boolean {
+    return /\.asar($|[\\/])/.test(filePath);
+}
+
+async function ensurePlantumlJarExtracted(sourcePath: string): Promise<string> {
+    if (!isPackagedAsarPath(sourcePath)) {
+        return sourcePath;
+    }
+
+    const tempDir = path.join(app.getPath('temp'), 'docforge-plantuml');
+    const destinationPath = path.join(tempDir, 'plantuml.jar');
+
+    await fs.mkdir(tempDir, { recursive: true });
+
+    let needsExtraction = true;
+    try {
+        const [sourceStats, destStats] = await Promise.all([fs.stat(sourcePath), fs.stat(destinationPath)]);
+        if (sourceStats.size === destStats.size) {
+            needsExtraction = false;
+        }
+    } catch {
+        // Either the destination does not exist yet or we could not stat one of the files.
+        needsExtraction = true;
+    }
+
+    if (!needsExtraction) {
+        return destinationPath;
+    }
+
+    const pipeline = promisify(stream.pipeline);
+
+    try {
+        await pipeline(createReadStream(sourcePath), createWriteStream(destinationPath));
+    } catch (error) {
+        try {
+            await fs.unlink(destinationPath);
+        } catch {
+            // Ignore cleanup failures; we'll retry extraction later if needed.
+        }
+
+        const message =
+            error instanceof Error
+                ? error.message
+                : 'Failed to extract bundled PlantUML renderer from application archive.';
+        throw new Error(`Unable to prepare PlantUML renderer: ${message}`);
+    }
+
+    return destinationPath;
+}
+
 async function resolvePlantUmlJar(): Promise<string> {
     if (cachedPlantumlJarPath) {
         return cachedPlantumlJarPath;
@@ -571,8 +621,9 @@ async function resolvePlantUmlJar(): Promise<string> {
         for (const candidate of candidates) {
             try {
                 await fs.access(candidate);
-                cachedPlantumlJarPath = candidate;
-                return candidate;
+                const usablePath = await ensurePlantumlJarExtracted(candidate);
+                cachedPlantumlJarPath = usablePath;
+                return usablePath;
             } catch {
                 // Continue searching
             }