From 3d2c8a4983e0325cf12a6f35cf7a4b5d69e9da3d Mon Sep 17 00:00:00 2001 From: Edvin Covaci Date: Tue, 22 Sep 2026 11:36:06 +0200 Subject: [PATCH 1/3] feat: add icon support for BccCapacityIndicator --- .../BccCapacityIndicator.css | 14 ++++++ .../BccCapacityIndicator.stories.ts | 30 ++++++++++++ .../BccCapacityIndicator.vue | 49 ++++++++++++------- 3 files changed, 75 insertions(+), 18 deletions(-) diff --git a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.css b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.css index 88164505..c47e2251 100644 --- a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.css +++ b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.css @@ -47,4 +47,18 @@ @apply ctx-red-subtlest; --bcc-capacity-indicator-background: var(--ctx-background); } + + .bcc-capacity-indicator .bcc-capacity-indicator-icon { + width: 100%; + height: 100%; + color: var(--bcc-capacity-indicator-text); + } + + .bcc-capacity-indicator.borderless { + --bcc-capacity-indicator-background: var(--ctx-background); + } + .bcc-capacity-indicator.borderless .circle, + .bcc-capacity-indicator.borderless .circle-used { + stroke: none; + } } diff --git a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.stories.ts b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.stories.ts index 58669699..2943db57 100644 --- a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.stories.ts +++ b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.stories.ts @@ -1,4 +1,5 @@ import { BCC_CONTEXT_LIST } from '@/contexts'; +import { BlockIcon, CheckIcon, DoneAllIcon, PriorityHighIcon } from '@bcc-code/icons-vue'; import type { Meta, StoryObj } from '@storybook/vue3-vite'; import { ref } from 'vue'; import BccCapacityIndicator from './BccCapacityIndicator.vue'; @@ -13,6 +14,7 @@ const meta: Meta = { animationDuration: { control: 'number' }, squared: { control: 'boolean' }, colored: { control: 'boolean' }, + borderless: { control: 'boolean' }, context: { control: 'select', options: BCC_CONTEXT_LIST.filter(ctx => ctx.includes('-subtle')) }, }, }; @@ -73,6 +75,34 @@ export const Colored: Story = { }), }; +export const Icons: Story = { + render: () => ({ + components: { BccCapacityIndicator }, + setup() { + return { CheckIcon, DoneAllIcon, BlockIcon, PriorityHighIcon }; + }, + template: ` +
+ + + + +
+ `, + }), +}; + +export const Borderless: Story = { + render: () => ({ + components: { BccCapacityIndicator }, + template: ` +
+ +
+ `, + }), +}; + export const WithContext: Story = { render: () => ({ components: { BccCapacityIndicator }, diff --git a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.vue b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.vue index bce01414..ca37dce2 100644 --- a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.vue +++ b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.vue @@ -1,6 +1,7 @@ - - {{ progress < 100 ? total - valueUsed : 0 }} - - + + + + From 4011f13c267ca4bdbdb00d274274c4da480561e9 Mon Sep 17 00:00:00 2001 From: Edvin Covaci Date: Tue, 22 Sep 2026 12:42:45 +0200 Subject: [PATCH 2/3] fix: round number --- .../custom/BccCapacityIndicator/BccCapacityIndicator.css | 4 +--- .../BccCapacityIndicator/BccCapacityIndicator.stories.ts | 2 +- .../custom/BccCapacityIndicator/BccCapacityIndicator.vue | 8 +++----- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.css b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.css index c47e2251..29ef4abf 100644 --- a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.css +++ b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.css @@ -48,9 +48,7 @@ --bcc-capacity-indicator-background: var(--ctx-background); } - .bcc-capacity-indicator .bcc-capacity-indicator-icon { - width: 100%; - height: 100%; + .bcc-capacity-indicator .icon { color: var(--bcc-capacity-indicator-text); } diff --git a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.stories.ts b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.stories.ts index 2943db57..f4fe894f 100644 --- a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.stories.ts +++ b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.stories.ts @@ -85,7 +85,7 @@ export const Icons: Story = {
- +
`, diff --git a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.vue b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.vue index ca37dce2..02bba8b6 100644 --- a/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.vue +++ b/component-library/src/components/custom/BccCapacityIndicator/BccCapacityIndicator.vue @@ -46,8 +46,6 @@ const percentage = computed(() => { const { value: progress } = useAnimatedNumber(percentage, percentage.value, props.animationDuration); const dashArray = Math.PI * 18 * 2; - -const iconSize = (40 * 2) / 3; - - - + + +