Skip to content

Commit 7b95b30

Browse files
Tsvetan StoychevTsvetan Stoychev
authored andcommitted
Fix obsolete translation test assumptions
1 parent d130088 commit 7b95b30

5 files changed

Lines changed: 13 additions & 45 deletions

File tree

‎checklist.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,9 @@ Acceptance criteria:
149149
- [ ] Make CI regenerate the loaders and fail when the committed output differs.
150150
- [ ] Document the source and version of the bundled Boomerang asset.
151151
- [x] Add a repeatable command for generating `languages/basicrum.pot`.
152-
- [x] Add a repeatable command for compiling translation MO files.
153-
- [x] Make CI detect stale POT or MO files.
152+
- [x] Keep locale-specific PO and MO files out of the repository and release ZIP.
153+
- [x] Keep POT generation as a local maintenance command; the standalone
154+
translation CI job was removed by product decision.
154155

155156
Acceptance criteria:
156157

‎docs/audits/checklist.md‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,6 @@ operator-journey defect, P3 = minor/polish.
9595
limitation. (privacy 8 / BR-WP-14)
9696
- [ ] P3 Declare WooCommerce HPOS compatibility
9797
(`FeaturesUtil::declare_compatibility`, guarded). (UX 9)
98-
- [ ] P3 Bulgarian catalog: complete it or drop the po/mo pair (8 of 66
99-
strings translated ships today). (UX 9)
10098
- [ ] P3 Optional hardening: reject protocol-relative/relative beacon URLs
10199
in `Validate.php` (BR-WP-06 was overturned to PASS - the bundle's
102100
`beacon_url_force_https` already prevents plaintext beacons). (privacy 10)

‎docs/audits/operator-experience-audit.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ settings screen. (issue-backoffice-unlinked, walkthrough-05, BR-DOC-16)
159159
- [ ] Declare WooCommerce HPOS (custom order tables) compatibility via
160160
`FeaturesUtil::declare_compatibility()`; the plugin advertises WooCommerce
161161
support but makes no declaration. (critic)
162-
- [ ] Resolve the Bulgarian catalog: 8 of 66 strings translated yet a
163-
compiled .mo ships, giving Bulgarian admins a mixed-language UI. Complete
164-
it or drop the pair until substantially complete. (critic)
162+
- [x] Remove the incomplete Bulgarian PO/MO catalogs and keep locale-specific
163+
catalogs out of release ZIPs until bundled translations are deliberately
164+
restored. (critic, superseded by product decision on 2026-07-19)
165165
- [ ] Explain in plain language why fields are grayed out before Enable is
166166
checked. (issue-disabled-state-unexplained)
167167
- [ ] Soften residual developer jargon: `manage_options capability`,

‎docs/audits/privacy-audit.md‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,15 @@ cookies to maintain measurement state".
8080
- [ ] Update `tests/unit/PrivacyTest.php` string assertions.
8181
- [ ] Keep the wording editable and qualified; no compliance claims.
8282

83-
## 5. Regenerate translation catalogs for the pending header edit (DISC-10)
83+
## 5. Translation catalogs (DISC-10, superseded)
8484

85-
The uncommitted `basicrum.php` Description change makes
86-
`languages/basicrum.pot` and the bg_BG catalogs stale; the CI translation job
87-
runs `git diff --exit-code` on `plugins/basicrum/languages` and will fail on
88-
this working tree.
85+
Resolved by product decision on 2026-07-19: the Bulgarian PO/MO catalogs and
86+
standalone translation CI job were removed. Keep the POT-only local generator
87+
for future gettext changes, and keep locale-specific catalogs out of release
88+
ZIPs unless bundled translations are deliberately restored.
8989

90-
- [ ] Run `make translations` and commit the regenerated `basicrum.pot`,
91-
`basicrum-bg_BG.po`, and `basicrum-bg_BG.mo` together with the header and
92-
readme edits.
93-
- [ ] Fold in the new strings from items 3 and 4 when those land.
90+
- [x] Regenerate and commit `languages/basicrum.pot` when source strings change.
91+
- [x] Exclude and reject locale-specific PO/MO files in release packages.
9492

9593
## 6. Match public page-type lists to the detector (DISC-08)
9694

‎plugins/basicrum/tests/integration/PluginBootstrapTest.php‎

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
namespace Basicrum\WP\Tests\Integration;
99

1010
use Basicrum\WP\Helpers;
11-
use Basicrum\WP\Plugin;
1211

1312
/**
1413
* Verifies the plugin loads correctly inside the WordPress test environment.
@@ -38,32 +37,4 @@ public function test_helper_defaults_are_available() {
3837
$this->assertSame( '0', $defaults['enabled'] );
3938
$this->assertSame( 'footer', $defaults['script_position'] );
4039
}
41-
42-
/**
43-
* Ensure the bundled translation catalog loads at the normal init priority.
44-
*
45-
* @return void
46-
*/
47-
public function test_translation_loader_uses_default_init_priority() {
48-
global $wp_filter;
49-
50-
$callbacks = $wp_filter['init']->callbacks;
51-
52-
foreach ( $callbacks as $priority => $registered_callbacks ) {
53-
foreach ( $registered_callbacks as $callback ) {
54-
$function = $callback['function'];
55-
56-
if (
57-
is_array( $function )
58-
&& $function[0] instanceof Plugin
59-
&& 'load_textdomain' === $function[1]
60-
) {
61-
$this->assertSame( 10, $priority );
62-
return;
63-
}
64-
}
65-
}
66-
67-
$this->fail( 'The Basicrum translation loader was not registered.' );
68-
}
6940
}

0 commit comments

Comments
 (0)