Skip to content

Commit 634c364

Browse files
Tsvetan StoychevTsvetan Stoychev
authored andcommitted
Remove bundled Bulgarian translations
1 parent eace920 commit 634c364

18 files changed

Lines changed: 180 additions & 895 deletions

File tree

‎.agents/skills/change-basicrum-settings/SKILL.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ description: Change Basicrum WordPress settings across defaults, admin UI, valid
66
# Change Basicrum Settings
77

88
Treat a setting as one behavior spanning storage, administration, validation,
9-
runtime use, upgrades, tests, documentation, and translations.
9+
runtime use, upgrades, tests, documentation, and the gettext template.
1010

1111
## Map the setting
1212

@@ -23,7 +23,7 @@ runtime use, upgrades, tests, documentation, and translations.
2323
## Implement the complete behavior
2424

2525
- Keep the `basicrum_settings` schema synchronized across defaults, UI,
26-
validation, runtime code, tests, docs, translations, and any post-release
26+
validation, runtime code, tests, docs, the POT template, and any post-release
2727
migrations.
2828
- Make server-side validation authoritative. Client-side disabled states and
2929
invalid-field styling are usability aids, not security controls.
@@ -56,6 +56,6 @@ make unit
5656
make conventions
5757
```
5858

59-
Run `make translations` for changed strings and require a second generation to
60-
produce no diff. Manually verify enabled, disabled, invalid, and valid form
59+
Run `make translations` for changed strings and require a second POT generation
60+
to produce no diff. Manually verify enabled, disabled, invalid, and valid form
6161
states when layout or browser behavior changes.

‎.agents/skills/integrate-basicrum-consent/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,5 +74,5 @@ git diff --check
7474
```
7575

7676
Update `examples/integrations/README.md`, the main README, plugin readme, privacy
77-
guidance, release required-file checks, and translations when the
77+
guidance, release required-file checks, and POT template when the
7878
administrator-visible contract changes.

‎.agents/skills/release-basicrum-plugin/SKILL.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Test the artifact users install, not only the source checkout.
1515
dependencies in a temporary tree with an optimized authoritative autoloader;
1616
do not replace normal Composer PSR-4 loading with a handwritten runtime
1717
autoloader.
18-
- Include referenced runtime PHP, JavaScript, CSS, images, translations, readme,
18+
- Include referenced runtime PHP, JavaScript, CSS, images, the POT template, readme,
1919
license, and production vendor files.
2020
- Exclude tests, Playwright and Node files, examples, Docker files, agent skills,
2121
local configuration, caches, and development dependencies.
@@ -40,7 +40,7 @@ explicit and use combinations supported by WordPress core.
4040
merging updates.
4141
- Keep default workflow permissions read-only. Grant `contents: write` only to
4242
release jobs that attach artifacts.
43-
- Run Composer validation, auditing, PHPStan, translation reproducibility,
43+
- Run Composer validation, auditing, PHPStan, POT-template reproducibility,
4444
repository conventions, and generated-asset checks.
4545

4646
## Exercise the artifact

‎.agents/skills/update-basicrum-copy/SKILL.md‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
---
22
name: update-basicrum-copy
3-
description: Update Basicrum branding, user-facing copy, documentation, and WordPress gettext catalogs. Use for naming changes, BasicRUM or Basic Rum cleanup, Brum Site ID help text, logos, POT/PO/MO files, or ASCII-hyphen checks.
3+
description: Update Basicrum branding, user-facing copy, documentation, and the WordPress gettext template. Use for naming changes, BasicRUM or Basic Rum cleanup, Brum Site ID help text, logos, POT files, or ASCII-hyphen checks.
44
---
55

66
# Update Basicrum Copy
77

8-
Change source text and every generated or translated representation as one unit.
8+
Change source text and its generated gettext template as one unit.
99

1010
## Find the full text surface
1111

1212
1. Search case-insensitively across PHP, JavaScript, CSS, Markdown, WordPress
13-
readme, tests, fixtures, examples, workflows, POT, and PO files.
14-
2. Distinguish source strings from generated catalogs and compiled MO files.
13+
readme, tests, fixtures, examples, workflows, and POT files.
14+
2. Distinguish source strings from the generated POT template.
1515
3. Check identifiers separately from display text; do not casually rename stored
1616
option keys, hooks, handles, or public callbacks.
1717

@@ -23,7 +23,8 @@ Change source text and every generated or translated representation as one unit.
2323
- Use ASCII hyphens only. Do not introduce en dashes or em dashes.
2424
- Keep statements about consent, privacy, and compliance precise. Basicrum
2525
follows the external tool's decision; it does not make a site compliant.
26-
- Keep WordPress gettext calls in PHP source. Do not hand-edit binary MO files.
26+
- Keep WordPress gettext calls in PHP source. Do not add locale-specific PO or
27+
MO files unless bundled translations are deliberately restored.
2728
- Update tests that intentionally assert rendered copy without making tests less
2829
specific merely to avoid maintaining wording.
2930

@@ -43,6 +44,5 @@ git diff --check
4344
```
4445

4546
The second translation run must be idempotent. Search again for every retired
46-
spelling after generation, inspect the POT and PO diff, and verify MO files were
47-
produced by the documented tool. Run relevant PHP or browser tests when rendered
48-
markup, selectors, or behavior changed.
47+
spelling after generation and inspect the POT diff. Run relevant PHP or browser
48+
tests when rendered markup, selectors, or behavior changed.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
interface:
22
display_name: "Update Basicrum Copy"
3-
short_description: "Update branding, copy, and translation catalogs"
4-
default_prompt: "Use $update-basicrum-copy to update Basicrum wording and regenerate every translation artifact."
3+
short_description: "Update branding, copy, and gettext template"
4+
default_prompt: "Use $update-basicrum-copy to update Basicrum wording and regenerate the POT template."

‎.github/workflows/ci.yml‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -54,27 +54,6 @@ jobs:
5454
working-directory: plugins/basicrum
5555
run: composer analyse
5656

57-
translations:
58-
name: Translation catalogs
59-
runs-on: ubuntu-latest
60-
61-
steps:
62-
- name: Checkout
63-
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
64-
65-
- name: Setup PHP and WP-CLI
66-
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # v2
67-
with:
68-
php-version: '8.2'
69-
tools: wp-cli:2.12.0
70-
coverage: none
71-
72-
- name: Regenerate translation catalogs
73-
run: sh tools/update-translations.sh plugins/basicrum
74-
75-
- name: Check for stale translation artifacts
76-
run: git diff --exit-code -- plugins/basicrum/languages
77-
7857
javascript:
7958
name: JavaScript loader behavior
8059
runs-on: ubuntu-latest
@@ -232,7 +211,6 @@ jobs:
232211
needs:
233212
- conventions
234213
- quality
235-
- translations
236214
- javascript
237215
- woocommerce-e2e
238216
- unit

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ The installable plugin is [`plugins/basicrum/`](plugins/basicrum/). Repository r
2626

2727
Follow the permanent conventions in [AGENTS.md](AGENTS.md), including WordPress Coding Standards, PHP 7.4 compatibility, ASCII hyphens, synchronized version metadata, privacy-safe consent behavior, and immutable GitHub Actions pins.
2828

29-
When changing user-facing text, regenerate WordPress translation catalogs. When changing settings, keep defaults, rendering, validation, runtime behavior, tests, and documentation synchronized.
29+
When changing user-facing text, regenerate the WordPress POT template. Locale-specific PO and MO files are not bundled. When changing settings, keep defaults, rendering, validation, runtime behavior, tests, and documentation synchronized.
3030

3131
## Verification
3232

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ help:
3232
@echo " composer-validate Validate Composer metadata and lock file"
3333
@echo " composer-audit Audit locked Composer dependencies"
3434
@echo " conventions Enforce ASCII hyphens and version consistency"
35-
@echo " translations Update POT, PO, and MO translation catalogs"
35+
@echo " translations Update the POT translation template"
3636
@echo " js-install Install locked JavaScript test dependencies"
3737
@echo " js-test Run loader behavior tests in Chromium"
3838
@echo " woocommerce-e2e Run WooCommerce page-type browser tests"

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ The complete webmaster-facing behavior and consent instructions live in the [Wor
1919
| Path | Purpose |
2020
| --- | --- |
2121
| [`plugins/basicrum/`](plugins/basicrum/) | Installable plugin source |
22-
| [`tools/`](tools/) | Setup, test, translation, and release scripts |
22+
| [`tools/`](tools/) | Setup, test, and release scripts |
2323
| [`docker/`](docker/) | Local WordPress and WooCommerce environments |
2424
| [`tests/javascript/`](tests/javascript/) | Browser tests for loaders, consent adapters, and settings |
2525
| [`examples/integrations/`](examples/integrations/) | Consent-tool integration examples |

‎docs/audits/checklist.md‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@ operator-journey defect, P3 = minor/polish.
99

1010
## A. Plugin engineering
1111

12-
- [x] P0 Regenerate translation catalogs and commit (`make translations`).
13-
Completed in `784b2bf`. Two consecutive generations produced identical
14-
catalogs, and the translation CI gate passed after push. (privacy 5 /
15-
DISC-10, lab-elevated)
12+
- [x] P0 Remove the bundled Bulgarian PO/MO catalogs and the standalone
13+
translation CI job by product decision. Keep the POT-only local generator for
14+
future gettext work, exclude locale-specific catalogs from release ZIPs, and
15+
remove the translation job from the release dependency chain. (privacy 5 /
16+
DISC-10, superseded)
1617
- [x] P1 Make `strip_query_string` a first-class Visitor Privacy setting,
1718
disabled by default by product decision and emitted as a Boomerang boolean.
1819
When enabled, this flag redacts `u`, `nu`, `r`, and `restiming`

0 commit comments

Comments
 (0)