Belt and braces

Author: mclarkson

src/arch.sh

@@ -17,6 +17,9 @@ set_arch() {
     elif [[ $(uname -m) == "arm64" ]]; then
       export __mokarch=arm64
     fi
+  else
+    printf 'ERROR: Unknown OS type: %s\n' "${__mokostype}" >"${STDERR}"
+    exit "${ERROR}"
   fi
 }
 

src/buildimage.sh

@@ -43,8 +43,8 @@ build image options:
  Flags:
   --get-prebuilt-image - Instead of building a 'node' image
          locally, download it from a container registry instead.
-  --k8sver VERSION - The Kubernetes version, e.g. "1.32.0" or "1.32.1".
-         A previous version cannot be built from scratch. This option
+  --k8sver VERSION - The Kubernetes version, e.g. "1.32.0"
+         A previous version cannot be built from scratch hence this option
          must be used with '--get-prebuilt-image'. To build a previous
          version of kubernetes it must be built with a previous version
          of mok.

src/createcluster.sh

@@ -137,7 +137,7 @@ create cluster [flags] options:
   --with-lb - Add a haproxy load balancer. The software will be installed
          and set up to reverse proxy to the master node(s), unless
          --skiplbsetup is used.
-  --k8sver VERSION - The Kubernetes version, e.g. "1.32.0" or "1.32.1".
+  --k8sver VERSION - The Kubernetes version, e.g. "1.32.0".
          A previous version will need to be downloaded first with:
            mok build image --get-prebuilt-image --k8sver VERSION
   --masters NUM - The number of master containers to create.

src/main.sh

@@ -17,6 +17,7 @@ MA_program_args() {
 # MA_arg_1 getter outputs the first argument sent by the user.
 # Used by _CU_podman_checks so it doesn't check for a podman machine
 # if we're running 'machine' commands
+# FIXME: The command might not be the first argument. It could be '-p'
 MA_arg_1() {
   printf '%s' "${_MA[arg_1]}"
 }