replace deprecated client injection (#605)

* replace deprecated client injection

* remove unused error

* fix tests

Author: m-terra

cmd/main.go

@@ -191,6 +191,9 @@ func (m *Main) addToManager(r manager.Runnable) {
 	if r, ok := r.(inject.Reader); ok {
 		r.InjectReader(m.Manager.GetAPIReader())
 	}
+	if r, ok := r.(inject.Client); ok {
+		r.InjectClient(m.Manager.GetClient())
+	}
 	if h, ok := r.(inject.Healthz); ok {
 		if hc := h.HealthzCheck(); hc != nil {
 			if err := m.Manager.AddHealthzCheck(h.Name(), hc); err != nil {

pkg/cron/cron.go

@@ -45,9 +45,8 @@ func (j *cronJob) InjectController(c lifecycle.Controller) {
 }
 
 // InjectClient inject the client
-func (j *cronJob) InjectClient(c client.Client) error {
+func (j *cronJob) InjectClient(c client.Client) {
 	j.client = c
-	return nil
 }
 
 // NeedLeaderElection may only start if leader is elected

pkg/cron/cron_test.go

@@ -49,7 +49,7 @@ var _ = Describe("Cron", func() {
 		cj = Job().(*cronJob)
 		cj.InjectController(mockController)
 		cj.InjectConfig(cfg)
-		Ω(cj.InjectClient(mockClient)).ShouldNot(HaveOccurred())
+		cj.InjectClient(mockClient)
 	})
 	Context("NeedLeaderElection", func() {
 		It("should be true", func() {

pkg/inject/interfaces.go

@@ -25,6 +25,11 @@ type Reader interface {
 	InjectReader(client.Reader)
 }
 
+// Client inject the api client
+type Client interface {
+	InjectClient(client.Client)
+}
+
 // Config inject the config
 type Config interface {
 	InjectConfig(*config.Config)