Update/sc2 firmware signals#7
Conversation
Update PDC, steering wheel, MPPT, and powertrain decode rules to match firmware CAN layout. Remove signals not present in firmware repos or the spreadsheet, keeping BMS, Software subsystem, and MCC spreadsheet entries. Co-authored-by: Cursor <cursoragent@cursor.com>
Re-add maximum_distance_traveled and optimized_target_power as FFF software-computed outputs alongside the other non-CAN subsystems. Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the telemetry format definitions in format.json by removing obsolete keys, renaming powertrain status fields to lowercase snake_case, and adding new MPPT, PDC, and steering wheel sensor signals. The review feedback suggests improving consistency by renaming the low-voltage telemetry keys (e.g., lv_12V_telem to lv_12v_telem) to use lowercase 'v' and clearing the unit field for direction_switch to an empty string instead of a description.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Restore lv_12V_telem, lv_5V_telem, and lv_5V_current so format.json keys align with sc2-pdc source and the signal spreadsheet. Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
No description provided.