[Compilation Error] `dprintf` argument mismatch

[incognitte]

Compiling on Haiku OS R1/beta3 (Revision hrev55181+62) x86_gcc2 fails with the following error.

/boot/home/driveencryption/lib/crypt.cpp:1442: passing const char *' to argument 1 of dprintf(int, const char *, ...)' lacks a cast
/boot/system/develop/headers/posix/stdio.h:174: too few arguments to function `int dprintf(int, const char *, ...)'
/boot/home/driveencryption/lib/crypt.cpp:1442: at this point in file
/boot/system/develop/etc/makefile-engine:300: recipe for target 'objects.x86-cc2-release/crypt.o' failed
make[1]: *** [objects.x86-cc2-release/crypt.o] Error 1
make[1]: Leaving directory '/boot/home/driveencryption/lib'
makefile:3: recipe for target 'default' failed
make: *** [default] Error 2

A closer inspection suggests that dprintf in posix/stdio.h expects file handle as the first argument

extern int		dprintf(int fd, char const *format, ...) __PRINTFLIKE(2,3);

while crypt.cpp calls it without this argument (an example)

	dprintf("magic: %.4s\n", (char*)&header.magic);

I suspect this error is caused after this commit to Haiku OS

[axeld]

Yes, indeed, that makes sense. Looks like we have to define _KERNEL_MODE for the driver then.

[incognitte]

Your suggestion is correct _KERNEL_MODE needs to be defined as 1 like below:

Modify crypt.cpp and add the following to line 9

// issue #5  dprintf argument mismatch
#ifndef _KERNEL_MODE
#	define _KERNEL_MODE 1
#endif

then it compiles correctly and error free.

Unit tests however don't compile because dprintf is defined twice!

/storage/projects/driveencryption/test/crypt_test.cpp: In function `void dprintf(const char *, ...)':
/storage/projects/driveencryption/test/crypt_test.cpp:23: declaration of C function `void dprintf(const char *, ...)' conflicts with
/boot/system/develop/headers/posix/stdio.h:174: previous declaration `int dprintf(int, const char *, ...)' here

[incognitte]

In order to get make test compile, _KERNEL_MODE needs to be defined 0

However link fails looking for a library called kernelland_emu

/storage/projects/driveencryption> make test
make[1]: Entering directory '/storage/projects/driveencryption/test'
cc -o "objects.x86-cc2-release/crypt_test"      objects.x86-cc2-release/crypt_test.o  -Xlinker -soname=_APP_  -L./  ../lib/objects.x86-cc2-release/libcrypt.a  -lkernelland_emu 
/packages/gcc-2.95.3_2017_07_20-2/.self/develop/tools/i586-pc-haiku/bin/ld: cannot find -lkernelland_emu
collect2: ld returned 1 exit status
/boot/system/develop/etc/makefile-engine:249: recipe for target 'objects.x86-cc2-release/crypt_test' failed
make[1]: *** [objects.x86-cc2-release/crypt_test] Error 1
make[1]: Leaving directory '/storage/projects/driveencryption/test'
makefile:20: recipe for target 'test' failed
make: *** [test] Error 2

I am now puzzled because, I can find it in the Haiku source tree, but pkgman cannot find any reference to this library

/storage/projects/driveencryption> pkgman search kernelland_emu 
No matching packages found.

BTW, here is the output of git diff if you want to try by yourself.

diff --git a/lib/crypt.cpp b/lib/crypt.cpp
index f478ced..2d1de81 100644
--- a/lib/crypt.cpp
+++ b/lib/crypt.cpp
@@ -6,6 +6,9 @@
  * Truecrypt License.
  */
+// issue #5  dprintf argument mismatch 
+#ifndef _KERNEL_MODE
+#      define _KERNEL_MODE 1
+#endif
 
 #include "crypt.h"
 

diff --git a/test/crypt_test.cpp b/test/crypt_test.cpp
index 8bfd2d3..ce93ba6 100644
--- a/test/crypt_test.cpp
+++ b/test/crypt_test.cpp
@@ -3,7 +3,7 @@
  * Distributed under the terms of the MIT License.
  */
 
-
+// issue #5  dprintf argument mismatch
+#define _KERNEL_MODE 0
 #include "crypt.h"
 
 #include "random.h"