provide an immutable copy of the parameters dictionary

Author: lbalmaceda

lib/src/main/java/com/auth0/authentication/AuthenticationAPIClient.java

@@ -49,23 +49,22 @@
  */
 public class AuthenticationAPIClient {
 
+    private static final String DEFAULT_DB_CONNECTION = "Username-Password-Authentication";
+    private static final String SMS_CONNECTION = "sms";
+    private static final String EMAIL_CONNECTION = "email";
     private static final String USERNAME_KEY = "username";
     private static final String PASSWORD_KEY = "password";
-    private static final String DEFAULT_DB_CONNECTION = "Username-Password-Authentication";
     private static final String ID_TOKEN_KEY = "id_token";
     private static final String EMAIL_KEY = "email";
     private static final String REFRESH_TOKEN_KEY = "refresh_token";
-
     private static final String PHONE_NUMBER_KEY = "phone_number";
+    private static final String USER_ID_KEY = "user_id";
+    private static final String DELEGATION_PATH = "delegation";
     private static final String ACCESS_TOKEN_PATH = "access_token";
-    private static final String SMS_CONNECTION = "sms";
-    private static final String EMAIL_CONNECTION = "email";
     private static final String SIGN_UP_PATH = "signup";
     private static final String DB_CONNECTIONS_PATH = "dbconnections";
     private static final String CHANGE_PASSWORD_PATH = "change_password";
     private static final String UNLINK_PATH = "unlink";
-    private static final String USER_ID_KEY = "user_id";
-    private static final String DELEGATION_PATH = "delegation";
     private static final String PASSWORDLESS_PATH = "passwordless";
     private static final String START_PATH = "start";
     private static final String OAUTH_PATH = "oauth";

lib/src/main/java/com/auth0/authentication/ParameterBuilder.java

@@ -26,6 +26,7 @@
 
 import com.auth0.util.CheckHelper;
 
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -177,18 +178,18 @@ public ParameterBuilder addAll(Map<String, Object> parameters) {
      *
      * @return itself
      */
-    public ParameterBuilder clearAllA() {
+    public ParameterBuilder clearAll() {
         parameters.clear();
         return this;
     }
 
     /**
      * Create a {@link Map} with all the parameters
      *
-     * @return a new map with the parameters
+     * @return an unmodifiable map with the parameters
      */
     public Map<String, Object> asDictionary() {
-        return new HashMap<>(this.parameters);
+        return Collections.unmodifiableMap(new HashMap<>(this.parameters));
     }
 
     /**

lib/src/test/java/com/auth0/authentication/ParameterBuilderTest.java

@@ -35,7 +35,9 @@
 import java.util.HashMap;
 import java.util.Map;
 
+import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.equalToIgnoringCase;
+import static org.hamcrest.Matchers.instanceOf;
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.not;
 import static org.hamcrest.Matchers.notNullValue;
@@ -132,8 +134,18 @@ public void shouldDoNothingWhenAddingNullParameters() throws Exception {
     @Test
     public void shouldProvideADictionaryCopy() throws Exception {
         Map<String, Object> parameters = builder.setClientId(CLIENT_ID).asDictionary();
-        parameters.put("key", "value");
-        assertThat(builder.asDictionary(), not(hasEntry("key", "value")));
+        builder.set("key", "value");
+        assertThat(parameters, not(hasEntry("key", "value")));
+    }
+
+    @Test
+    public void shouldProvideAnImmutableDictionary() throws Exception {
+        Map<String, Object> parameters = builder.setClientId(CLIENT_ID).asDictionary();
+        try {
+            parameters.put("key", "value");
+        } catch (Exception e) {
+            assertThat(e.getClass().getName(), is(equalTo(UnsupportedOperationException.class.getName())));
+        }
     }
 
     private static Matcher<Map<? extends String, ?>> hasEntry(String key, Object value) {