Skip to content

Commit 12ca19e

Browse files
committed
Remove unused methods
1 parent 60238c1 commit 12ca19e

3 files changed

Lines changed: 18 additions & 38 deletions

File tree

lib/src/main/java/com/auth0/internal/BaseAuthenticationRequest.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import java.util.Map;
1010

1111
import static com.auth0.authentication.ParameterBuilder.ACCESS_TOKEN_KEY;
12-
import static com.auth0.authentication.ParameterBuilder.CLIENT_ID_KEY;
1312
import static com.auth0.authentication.ParameterBuilder.CONNECTION_KEY;
1413
import static com.auth0.authentication.ParameterBuilder.DEVICE_KEY;
1514
import static com.auth0.authentication.ParameterBuilder.GRANT_TYPE_KEY;
@@ -28,18 +27,6 @@ public BaseAuthenticationRequest(HttpUrl url, OkHttpClient client, ObjectMapper
2827
super(url, client, mapper, httpMethod);
2928
}
3029

31-
/**
32-
* Sets the 'client_id' parameter
33-
*
34-
* @param clientId clientID
35-
* @return itself
36-
*/
37-
@Override
38-
public AuthenticationRequest setClientId(String clientId) {
39-
addParameter(CLIENT_ID_KEY, clientId);
40-
return this;
41-
}
42-
4330
/**
4431
* Sets the 'grant_type' parameter
4532
*

lib/src/main/java/com/auth0/internal/RequestFactory.java

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -61,48 +61,49 @@ public AuthenticationRequest authenticationPOST(HttpUrl url, OkHttpClient client
6161
}
6262

6363
public <T> ParameterizableRequest<T> POST(HttpUrl url, OkHttpClient client, ObjectMapper mapper, Class<T> clazz) {
64-
return addMetricHeader(new SimpleRequest<>(url, client, mapper, "POST", clazz));
64+
final SimpleRequest<T> request = new SimpleRequest<>(url, client, mapper, "POST", clazz);
65+
addMetrics(request);
66+
return request;
6567
}
6668

6769
public ParameterizableRequest<Map<String, Object>> rawPOST(HttpUrl url, OkHttpClient client, ObjectMapper mapper) {
6870
final SimpleRequest<Map<String, Object>> request = new SimpleRequest<>(url, client, mapper, "POST");
69-
addMetricHeader(request);
71+
addMetrics(request);
7072
return request;
7173
}
7274

7375
public ParameterizableRequest<Void> POST(HttpUrl url, OkHttpClient client, ObjectMapper mapper) {
74-
return addMetricHeader(new VoidRequest(url, client, mapper, "POST"));
76+
final VoidRequest request = new VoidRequest(url, client, mapper, "POST");
77+
addMetrics(request);
78+
return request;
7579
}
7680

7781
public ParameterizableRequest<Void> POST(HttpUrl url, OkHttpClient client, ObjectMapper mapper, String jwt) {
7882
final AuthorizableRequest<Void> request = new VoidRequest(url, client, mapper, "POST")
7983
.setBearer(jwt);
80-
return addMetricHeader(request);
84+
addMetrics(request);
85+
return request;
8186
}
8287

8388
public <T> ParameterizableRequest<T> PUT(HttpUrl url, OkHttpClient client, ObjectMapper mapper, Class<T> clazz) {
84-
return addMetricHeader(new SimpleRequest<>(url, client, mapper, "PUT", clazz));
89+
final SimpleRequest<T> request = new SimpleRequest<>(url, client, mapper, "PUT", clazz);
90+
addMetrics(request);
91+
return request;
8592
}
8693

8794
public <T> ParameterizableRequest<T> PATCH(HttpUrl url, OkHttpClient client, ObjectMapper mapper, Class<T> clazz) {
88-
return addMetricHeader(new SimpleRequest<>(url, client, mapper, "GET", clazz));
95+
final SimpleRequest<T> request = new SimpleRequest<>(url, client, mapper, "GET", clazz);
96+
addMetrics(request);
97+
return request;
8998
}
9099

91100
public <T> ParameterizableRequest<T> DELETE(HttpUrl url, OkHttpClient client, ObjectMapper mapper, Class<T> clazz) {
92-
return addMetricHeader(new SimpleRequest<>(url, client, mapper, "DELETE", clazz));
93-
}
94-
95-
private <T> ParameterizableRequest<T> addMetricHeader(ParameterizableRequest<T> request) {
96-
if (this.clientInfo != null) {
97-
request.addHeader(Metrics.HEADER_NAME, this.clientInfo);
98-
}
99-
if (this.userAgent!= null) {
100-
request.addHeader("User-Agent", this.userAgent);
101-
}
101+
final SimpleRequest<T> request = new SimpleRequest<>(url, client, mapper, "DELETE", clazz);
102+
addMetrics(request);
102103
return request;
103104
}
104105

105-
private <T> void addMetrics(AuthorizableRequest<T> request) {
106+
private <T> void addMetrics(ParameterizableRequest<T> request) {
106107
if (this.clientInfo != null) {
107108
request.addHeader(Metrics.HEADER_NAME, this.clientInfo);
108109
}

lib/src/main/java/com/auth0/request/AuthenticationRequest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,6 @@
99
*/
1010
public interface AuthenticationRequest extends Request<Credentials> {
1111

12-
/**
13-
* Sets the 'client_id' parameter
14-
*
15-
* @param clientId clientID
16-
* @return itself
17-
*/
18-
AuthenticationRequest setClientId(String clientId);
19-
2012
/**
2113
* Sets the 'grant_type' parameter
2214
*

0 commit comments

Comments
 (0)