Merge value modeling improvements from targeting-bugfixes while preserving diagnostics

- Added recalculate targets functionality with save all button
- Enhanced time-saved chart with dynamic Y-axis and target lines
- Fixed type issues in target-calculation-service.ts using parseFloat for string conversions
- Simplified status.service.ts repositories API call
- Added value-modeling-explanation.md documentation
- Maintained all diagnostic functionality and type safety

Author: MattG57

backend/src/services/status.service.ts

@@ -11,7 +11,7 @@ export interface StatusType {
   };
   installations: {
     installation: Endpoints["GET /app/installations"]["response"]["data"][0]
-    repos: Endpoints["GET /installation/repositories"]["response"]["data"]["repositories"];
+    repos: Endpoints["GET /app/installations"]["response"]["data"];
   }[];
   surveyCount: number;
   auth?: {
@@ -56,12 +56,10 @@ class StatusService {
 
     status.installations = [];
     for (const installation of app.github.installations) {
-      const repos = await installation.octokit.paginate<Endpoints["GET /installation/repositories"]["response"]["data"]["repositories"][0]>(
-        installation.installation.repositories_url
-      );
+      const repos = await installation.octokit.request(installation.installation.repositories_url);
       status.installations.push({
         installation: installation.installation,
-        repos: repos
+        repos: repos.data.repositories
       });
     }
 

backend/src/services/target-calculation-service.ts

@@ -702,7 +702,8 @@ RESULT:
     const userTimeSavings = distinctUsers.map(userId => {
       const userSurveys = this.surveysWeekly.filter(survey => survey.userId === userId);
       const totalPercent = userSurveys.reduce((sum, survey) => {
-        const percentTimeSaved = typeof survey.percentTimeSaved === 'number' ? survey.percentTimeSaved : 0;
+        // Always parse percentTimeSaved as float
+        const percentTimeSaved = survey.percentTimeSaved != null ? parseFloat(survey.percentTimeSaved as any) : 0;
         return sum + percentTimeSaved;
       }, 0);
       return totalPercent / userSurveys.length; // Average percent time saved per user
@@ -711,17 +712,17 @@ RESULT:
     // Average across all users
     const avgPercentTimeSaved = userTimeSavings.reduce((sum, percent) => sum + percent, 0) / userTimeSavings.length;
 
-    // Convert settings values to numbers
-    const hoursPerYear = typeof this.settings.hoursPerYear === 'number' ? this.settings.hoursPerYear : 2000;
-    const percentCoding = typeof this.settings.percentCoding === 'number' ? this.settings.percentCoding : 50;
+    // Convert settings values to numbers (parse from string if needed)
+    const hoursPerYear = this.settings.hoursPerYear != null ? parseFloat(this.settings.hoursPerYear as any) : 2000;
+    const percentCoding = this.settings.percentCoding != null ? parseFloat(this.settings.percentCoding as any) : 50;
 
     // Calculate weekly hours saved based on settings and average percent
     const weeklyHours = hoursPerYear / 50; // Assuming 50 working weeks
     const weeklyDevHours = weeklyHours * (percentCoding / 100);
     const avgWeeklyTimeSaved = weeklyDevHours * (avgPercentTimeSaved / 100);
 
     // Calculate max based on settings
-    const maxPercentTimeSaved = typeof this.settings.percentTimeSaved === 'number' ? this.settings.percentTimeSaved : 20;
+    const maxPercentTimeSaved = this.settings.percentTimeSaved != null ? parseFloat(this.settings.percentTimeSaved as any) : 20;
     const maxWeeklyTimeSaved = weeklyDevHours * (maxPercentTimeSaved / 100);
 
     const result = {
@@ -785,11 +786,11 @@ RESULT:
     const adoptedDevs = this.calculateAdoptedDevs().current;
     const weeklyTimeSavedHrs = this.calculateWeeklyTimeSavedHrs().current;
 
-    // Ensure all values are properly typed as numbers
-    const hoursPerYear = typeof this.settings.hoursPerYear === 'number' ? this.settings.hoursPerYear : 2000;
+    // Always parse settings values as numbers (from string if needed)
+    const hoursPerYear = this.settings.hoursPerYear != null ? parseFloat(this.settings.hoursPerYear as any) : 2000;
     const weeksInYear = Math.round(hoursPerYear / 40) || 50; // Calculate weeks and ensure it's a number
 
-    const devCostPerYear = typeof this.settings.devCostPerYear === 'number' ? this.settings.devCostPerYear : 0;
+    const devCostPerYear = this.settings.devCostPerYear != null ? parseFloat(this.settings.devCostPerYear as any) : 0;
     const hourlyRate = devCostPerYear > 0 ? (devCostPerYear / hoursPerYear) : 50;
 
     const annualSavings = weeklyTimeSavedHrs * weeksInYear * hourlyRate * adoptedDevs;
@@ -824,8 +825,8 @@ RESULT:
     const adoptedDevs = this.calculateAdoptedDevs().current;
     const weeklyTimeSavedHrs = this.calculateWeeklyTimeSavedHrs().current;
 
-    // Convert hours per year to number
-    const hoursPerYear = typeof this.settings.hoursPerYear === 'number' ? this.settings.hoursPerYear : 2000;
+    // Always parse hours per year as number
+    const hoursPerYear = this.settings.hoursPerYear != null ? parseFloat(this.settings.hoursPerYear as any) : 2000;
     const hoursPerWeek = hoursPerYear / 50 || 40; // Default to 40 if undefined
 
     // Calculate productivity boost factor (not percentage)

backend/src/services/value-modeling-explanation.md

@@ -0,0 +1,89 @@
+# Value Modeling & Targeting Documentation
+
+This document outlines the rationale and logic behind the calculated metrics and targets used in the "Value Modeling & Targeting" dashboard. Each section corresponds to a category of metrics displayed in the dashboard.
+
+## Org Metrics
+
+### Seats
+- **Logic**: Based on the average total active seats (licenses) across top 10 recent days for the organization.
+- **Max**: Set to known total developer headcount.
+
+### Adopted Devs
+- **Logic**: Average of total active developers using AI tooling (e.g. Copilot) from top 10 recent days for the organization.
+- **Max**: Total known developer count.
+
+### Monthly Devs Reporting Time Savings
+- **Logic**: Count of distinct users who responded to time-savings surveys in past 30 days.
+- **Target**: Double the current, indicating intent to increase reporting.
+
+### % of Seats Reporting Time Savings
+- **Logic**: (Monthly reporting users / total seats) * 100.
+- **Purpose**: Shows how broadly time savings are captured.
+
+### % of Seats Adopted
+- **Logic**: (Adopted Devs / Total Seats) * 100.
+- **Use**: Adoption penetration relative to seat assignments.
+
+### % of Max Adopted
+- **Logic**: (Adopted Devs / Total Developer Count) * 100.
+- **Use**: Indicates potential ceiling for adoption.
+
+## Daily User Metrics
+
+### Daily IDE Suggestions
+- **Logic**: Averaged from last 5 valid daily records.
+- **Target/Max**: Calibrated based on observed high-performing usage.
+
+### Daily IDE Acceptances
+- **Logic**: Suggestions * 30% (default assumed acceptance rate).
+- **Target/Max**: Reflects healthy usage from productive orgs.
+
+### Daily IDE Chat Turns
+- **Logic**: Average of chat turns per day per user from recent week.
+- **Target/Max**: Reflects healthy usage from productive orgs.
+
+### Daily Dot-Com Chats
+- **Logic**: Chat Turns * 33% (estimated portion on dot-com).
+- **Target**: Not yet set pending more data.
+
+### Weekly PR Summaries
+- **Logic**: Total PR summaries / daily active users from last week.
+
+### Weekly Time Saved
+- **Logic**: Weekly average from time savings reports per developer.
+- **Calculation**:
+  ```
+  const weeklyHours = hoursPerYear / 50; // Assuming 50 working weeks
+  const weeklyDevHours = weeklyHours * (percentCoding / 100);
+  const avgWeeklyTimeSaved = weeklyDevHours * (avgPercentTimeSaved / 100);
+  ```
+
+## Calculated Impacts
+
+### Monthly Time Savings (hrs)
+- **Formula**: Adopted Devs * Weekly Time Saved * 4.
+- **Max**: 80 hours/month * total seats (full work month).
+
+### Annual Time Savings (Dollars)
+- **Formula**: Weekly Time Saved * 50 weeks * $100/hr * Adopted Devs.
+- **Note**: $100/hr is assumed average developer cost.
+
+### Productivity / Throughput Boost
+- **Formula**: ((40 + Weekly Time Saved) / 40 - 1) * 100.
+- **Purpose**: Estimates effective increase in output per dev.
+
+## Source of Calculations
+
+All calculations were derived from one or more of:
+- Recent metric exports (5 most recent days)
+- Monthly time-savings surveys
+- Developer seat and activity data
+- Assumed baselines (e.g., 40-hr weeks, $100/hr, 70% acceptance)
+
+Targets are either:
+- Reflective of past top 10 org benchmarks
+- Strategically aspirational (2x current, known limits)
+
+This model provides a structured framework for tracking usage, estimating impact, and guiding adoption investments.
+
+> Edits can include notes on thresholds, cohort segmentation, or more nuanced modeling (e.g., p50/p90 range breakdowns).