From 10db28c455287b43f53ce1852af39cb950385630 Mon Sep 17 00:00:00 2001 From: DjDeveloperr Date: Fri, 20 Nov 2026 05:03:53 +0000 Subject: [PATCH] drm/asahi: g17: keep the commit-stop raise to the T8142 #2469 kept the GPU domain raise at the sleep commit's stop on the T8142 and on every apple,agx-g17s part. The G17S M5 boards (J714s, J716c) never run it: they stop the GPU through their own M5 commit stop, which this doesn't touch. On them the flag only made asahi_g17_commit_finish() print "GPU domain at the commit stop: 0x0, raise to full 0" from fields the M5 stop never fills, which reads as a raise that didn't happen. The other G17S boards (K114c, K116s) take the generic stop, where the raise was never measured; their sleep was tested before it came in. Keep the raise to the T8142, the SoC it was made for (the J815's GPU gates itself between frames and its registers may not answer below full power): the other G17S boards go back to the stop they were tested with, and the M5 boards stop printing the empty line. Signed-off-by: Diljit Singh --- drivers/gpu/drm/asahi/g17/sleep.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/asahi/g17/sleep.c b/drivers/gpu/drm/asahi/g17/sleep.c index 3a29524ca1448..380e6662f1419 100644 --- a/drivers/gpu/drm/asahi/g17/sleep.c +++ b/drivers/gpu/drm/asahi/g17/sleep.c @@ -370,7 +370,7 @@ struct asahi_g17_commit { /* * Whether the commit's stop raises the GPU's domain before it touches the coprocessor: on the * SoCs the raise was made for, the T8142 (J815: the GPU gates itself between frames and its - * registers may not answer below full power) and the T6050. Elsewhere the stop goes straight + * registers may not answer below full power). Elsewhere the stop goes straight * to the idle poll, as before the raise. On the T8140 (J700) the domain reads its target on * and nothing powered under automatic power at the commit (0x1000230f); a raise from there * times out with BUSY latched, the PMP's AP IDLE then goes unanswered, the sleep takes the @@ -378,8 +378,7 @@ struct asahi_g17_commit { */ static bool asahi_g17_commit_raises(struct device *dev) { - return of_device_is_compatible(dev->of_node, "apple,agx-t8142") || - of_device_is_compatible(dev->of_node, "apple,agx-g17s"); + return of_device_is_compatible(dev->of_node, "apple,agx-t8142"); } /*