Skip to content

Commit bb43044

Browse files
wu-shengCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 335d0c6 commit bb43044

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

CHANGES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Release Notes.
2424
* Add Elasticsearch Java client (co.elastic.clients:elasticsearch-java) plugin for 7.16.x-9.x.
2525
* Only publish `apm-application-toolkit` modules to Maven Central. Agent and plugins are distributed via download package and Docker images.
2626
* Add unified release script (`tools/releasing/release.sh`) with two-step flow: `prepare-vote` and `vote-passed`.
27-
* Fix `JDBCPluginConfig.Plugin.JDBC.SQL_BODY_MAX_LENGTH` was not honored by clickhouse-0.3.1 and clickhouse-0.3.2.x plugins.
27+
* Fix an issue where `JDBCPluginConfig.Plugin.JDBC.SQL_BODY_MAX_LENGTH` was not honored by clickhouse-0.3.1 and clickhouse-0.3.2.x plugins.
2828

2929
All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/249?closed=1)
3030

apm-sniffer/apm-sdk-plugin/clickhouse-0.3.1-plugin/src/test/java/org/apache/skywalking/apm/plugin/jdbc/clickhouse/ClickHouseStatementTracingWrapperTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public void shortSqlIsRecordedAsIs() throws Exception {
8282
@Test
8383
public void longSqlIsTruncatedToConfiguredLimit() throws Exception {
8484
JDBCPluginConfig.Plugin.JDBC.SQL_BODY_MAX_LENGTH = 16;
85-
// 32 chars, twice the limit, so the helper must truncate to first 16 chars and append "..."
85+
// Longer than the limit, so the helper must truncate to first 16 chars and append "..."
8686
String sql = "SELECT * FROM table_with_many_cols";
8787

8888
ClickHouseStatementTracingWrapper.of(connectionInfo, "execute", sql, () -> Boolean.TRUE);

apm-sniffer/apm-sdk-plugin/clickhouse-0.3.2.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/jdbc/clickhouse/ClickHousePrepareStatementTracingTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public void shortSqlIsRecordedAsIs() throws Exception {
8383
@Test
8484
public void longSqlIsTruncatedToConfiguredLimit() throws Exception {
8585
JDBCPluginConfig.Plugin.JDBC.SQL_BODY_MAX_LENGTH = 16;
86-
// 32 chars, twice the limit, so the helper must truncate to first 16 chars and append "..."
86+
// Longer than the configured limit, so the helper must truncate to the first 16 chars and append "..."
8787
String sql = "SELECT * FROM table_with_many_cols";
8888

8989
ClickHousePrepareStatementTracing.of(connectionInfo, "execute", sql, () -> Boolean.TRUE);

0 commit comments

Comments
 (0)