fix(file-index): address search review feedback

Author: zjw1111

include/paimon/read_context.h

@@ -109,7 +109,7 @@ class PAIMON_EXPORT ReadContext {
         return full_text_search_;
     }
 
-    bool HasFileIndexSearch() const {
+    bool HasVectorOrFullTextSearch() const {
         return vector_search_ != nullptr || full_text_search_ != nullptr;
     }
 
@@ -339,14 +339,20 @@ class PAIMON_EXPORT ReadContextBuilder {
     /// @return Reference to this builder for method chaining.
     ReadContextBuilder& SetPredicate(const std::shared_ptr<Predicate>& predicate);
 
-    /// Configure file-local vector search. The limit is applied independently to every data file.
-    /// Vector search and full-text search are mutually exclusive.
+    /// Set the vector search request used when reading data.
+    ///
+    /// TODO(jinli.zjw): Support combining vector search with predicates and full-text search. Merge
+    /// per-file candidates to compute read-level top-k results.
+    ///
     /// @param vector_search Vector search request, or nullptr to clear it.
     /// @return Reference to this builder for method chaining.
     ReadContextBuilder& SetVectorSearch(const std::shared_ptr<VectorSearch>& vector_search);
 
-    /// Configure file-local full-text search. The limit is applied independently to every data
-    /// file. Full-text search and vector search are mutually exclusive.
+    /// Set the full-text search request used when reading data.
+    ///
+    /// TODO(jinli.zjw): Support combining full-text search with predicates and vector search. Apply
+    /// the search limit to merged per-file results at read level.
+    ///
     /// @param full_text_search Full-text search request, or nullptr to clear it.
     /// @return Reference to this builder for method chaining.
     ReadContextBuilder& SetFullTextSearch(const std::shared_ptr<FullTextSearch>& full_text_search);

src/paimon/CMakeLists.txt

@@ -652,6 +652,7 @@ if(PAIMON_BUILD_TESTS)
                     common/predicate/predicate_utils_test.cpp
                     common/predicate/predicate_validator_test.cpp
                     common/reader/complete_index_score_batch_reader_test.cpp
+                    common/reader/complete_index_score_file_batch_reader_test.cpp
                     common/reader/concat_batch_reader_test.cpp
                     common/reader/data_file_reader_factory_test.cpp
                     common/reader/late_materializing_file_batch_reader_test.cpp

src/paimon/common/file_index/scored_file_index_result_test.cpp

@@ -36,10 +36,6 @@ TEST(ScoredFileIndexResultTest, TestCreate) {
     EXPECT_TRUE(remain);
     EXPECT_EQ("row positions: {2,5}, scores: {0.25,0.75}", result->ToString());
 
-    std::shared_ptr<FileIndexResult> file_index_result = result;
-    ASSERT_OK_AND_ASSIGN(remain, file_index_result->IsRemain());
-    EXPECT_TRUE(remain);
-
     ASSERT_OK_AND_ASSIGN(std::shared_ptr<ScoredFileIndexResult> empty,
                          ScoredFileIndexResult::Create(RoaringBitmap32(), {}));
     EXPECT_TRUE(empty->IsEmpty());