Skip to content

Commit 813a359

Browse files
committed
index: upgrade Lumina to 0.4.0
1 parent a774f8e commit 813a359

2 files changed

Lines changed: 26 additions & 6 deletions

File tree

‎src/paimon/indexer/lumina/lumina_global_index_test.cpp‎

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,27 @@ class LuminaGlobalIndexTest : public ::testing::Test {
281281
std::vector<float> query_ = {1.0f, 1.0f, 1.0f, 1.1f};
282282
};
283283

284-
TEST_F(LuminaGlobalIndexTest, TestSimple) {
284+
class LuminaGlobalIndexBackendTest : public LuminaGlobalIndexTest,
285+
public ::testing::WithParamInterface<std::string> {
286+
public:
287+
void SetUp() override {
288+
LuminaGlobalIndexTest::SetUp();
289+
options_["lumina.index.type"] = GetParam();
290+
if (GetParam() == "flatnsw") {
291+
options_["lumina.flatnsw.build.thread_count"] = "1";
292+
// Use a large search width for the small dataset to reduce approximate-search misses.
293+
options_["lumina.flatnsw.search.ef_search"] = "64";
294+
}
295+
}
296+
};
297+
298+
INSTANTIATE_TEST_SUITE_P(Backends, LuminaGlobalIndexBackendTest,
299+
::testing::Values(std::string("bruteforce"), std::string("flatnsw")),
300+
[](const ::testing::TestParamInfo<std::string>& info) {
301+
return info.param;
302+
});
303+
304+
TEST_P(LuminaGlobalIndexBackendTest, TestSimple) {
285305
auto test_root_dir = paimon::test::UniqueTestDirectory::Create();
286306
ASSERT_TRUE(test_root_dir);
287307
std::string test_root = test_root_dir->Str();
@@ -315,7 +335,7 @@ TEST_F(LuminaGlobalIndexTest, TestSimple) {
315335
}
316336
}
317337

318-
TEST_F(LuminaGlobalIndexTest, TestWithFilter) {
338+
TEST_P(LuminaGlobalIndexBackendTest, TestWithFilter) {
319339
auto test_root_dir = paimon::test::UniqueTestDirectory::Create();
320340
ASSERT_TRUE(test_root_dir);
321341
std::string test_root = test_root_dir->Str();
@@ -736,7 +756,7 @@ TEST_F(LuminaGlobalIndexTest, TestWriteAndReadWithTagFilter) {
736756
}
737757
}
738758

739-
TEST_F(LuminaGlobalIndexTest, TestWriteAndReadWithMixedTagPredicates) {
759+
TEST_P(LuminaGlobalIndexBackendTest, TestWriteAndReadWithMixedTagPredicates) {
740760
auto test_root_dir = paimon::test::UniqueTestDirectory::Create();
741761
ASSERT_TRUE(test_root_dir);
742762
std::string test_root = test_root_dir->Str();
@@ -1360,7 +1380,7 @@ TEST_F(LuminaGlobalIndexTest, TestHighCardinalityAndMultiThreadSearch) {
13601380
}
13611381
}
13621382

1363-
TEST_F(LuminaGlobalIndexTest, TestWriteWithNullRows) {
1383+
TEST_P(LuminaGlobalIndexBackendTest, TestWriteWithNullRows) {
13641384
auto test_root_dir = paimon::test::UniqueTestDirectory::Create();
13651385
ASSERT_TRUE(test_root_dir);
13661386
std::string test_root = test_root_dir->Str();

‎third_party/versions.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ PAIMON_DATASKETCHES_BUILD_VERSION=5.2.0
139139
PAIMON_DATASKETCHES_BUILD_SHA256_CHECKSUM=63e6bda660ee9730cc39746de87fd983118c28149e32ff9389fac98b27010a53
140140
PAIMON_DATASKETCHES_PKG_NAME=datasketches-cpp-${PAIMON_DATASKETCHES_BUILD_VERSION}.tar.gz
141141

142-
PAIMON_LUMINA_BUILD_VERSION=0.3.1
143-
PAIMON_LUMINA_BUILD_SHA256_CHECKSUM=2aed1ae238c866c12ee01fad17d52651a9029cba1b972b23cd640959310e2149
142+
PAIMON_LUMINA_BUILD_VERSION=0.4.0
143+
PAIMON_LUMINA_BUILD_SHA256_CHECKSUM=5e23348383d3aace6c9c8b3590e560273fa77d671f338ae6a6d98b8c6fa61dcd
144144
PAIMON_LUMINA_PKG_NAME=lumina_release-${PAIMON_LUMINA_BUILD_VERSION}.tar.gz
145145

146146
PAIMON_JINDOSDK_C_BUILD_VERSION=6.10.2

0 commit comments

Comments
 (0)