@@ -1307,7 +1307,6 @@ TEST_F(RealtimeWriteInteTest, TestRealtimeDeduplicateRollingRestoresEveryOffsetS
13071307 const std::vector<Row> first_expected = {{1 , " old" , " p0" }, {2 , " old" , " p0" }, {3 , " old" , " p0" },
13081308 {4 , " old" , " p0" }, {5 , " old" , " p0" }, {6 , " old" , " p0" }};
13091309 ASSERT_OK_AND_ASSIGN (std::vector<Row> rows_before_prepare, ReadRows (realtime_context));
1310- std::sort (rows_before_prepare.begin (), rows_before_prepare.end ());
13111310 ASSERT_EQ (first_expected, rows_before_prepare);
13121311 ASSERT_OK_AND_ASSIGN (std::vector<RealtimeCommitProgress> progress,
13131312 writer->PrepareCommitWithProgress (/* commit_identifier=*/ 0 ));
@@ -1325,15 +1324,12 @@ TEST_F(RealtimeWriteInteTest, TestRealtimeDeduplicateRollingRestoresEveryOffsetS
13251324 std::optional<std::string>(file->file_name + " .offset" )));
13261325 }
13271326 ASSERT_OK_AND_ASSIGN (std::vector<Row> rows_after_prepare, ReadRows (realtime_context));
1328- std::sort (rows_after_prepare.begin (), rows_after_prepare.end ());
13291327 ASSERT_EQ (first_expected, rows_after_prepare);
13301328 ASSERT_OK_AND_ASSIGN (int64_t snapshot_id, Commit (progress, /* commit_identifier=*/ 0 ));
13311329 ASSERT_OK_AND_ASSIGN (std::vector<Row> rows_before_refresh, ReadRows (realtime_context));
1332- std::sort (rows_before_refresh.begin (), rows_before_refresh.end ());
13331330 ASSERT_EQ (first_expected, rows_before_refresh);
13341331 ASSERT_OK (writer->RefreshCommittedSnapshot (snapshot_id));
13351332 ASSERT_OK_AND_ASSIGN (std::vector<Row> rows_after_refresh, ReadRows (realtime_context));
1336- std::sort (rows_after_refresh.begin (), rows_after_refresh.end ());
13371333 ASSERT_EQ (first_expected, rows_after_refresh);
13381334 ASSERT_OK (writer->Close ());
13391335 writer.reset ();
@@ -1343,17 +1339,14 @@ TEST_F(RealtimeWriteInteTest, TestRealtimeDeduplicateRollingRestoresEveryOffsetS
13431339 ASSERT_OK_AND_ASSIGN (realtime_context, RealtimeContext::Create ());
13441340 ASSERT_OK_AND_ASSIGN (writer, CreateRealtimeWriter (realtime_context));
13451341 ASSERT_OK_AND_ASSIGN (std::vector<Row> restored_rows, ReadRows (realtime_context));
1346- std::sort (restored_rows.begin (), restored_rows.end ());
13471342 ASSERT_EQ (first_expected, restored_rows);
13481343 ASSERT_OK_AND_ASSIGN (std::unique_ptr<RecordBatch> update,
13491344 MakeBatch ({Row{1 , " new" , " p0" }, Row{3 , " new" , " p0" }, Row{5 , " new" , " p0" }},
13501345 /* partitioned=*/ false ));
13511346 ASSERT_OK (writer->Write (std::move (update)));
1352- std::vector<Row> expected = {{2 , " old" , " p0" }, {4 , " old" , " p0" }, {6 , " old" , " p0" },
1353- {1 , " new" , " p0" }, {3 , " new" , " p0" }, {5 , " new" , " p0" }};
1354- std::sort (expected.begin (), expected.end ());
1347+ const std::vector<Row> expected = {{2 , " old" , " p0" }, {4 , " old" , " p0" }, {6 , " old" , " p0" },
1348+ {1 , " new" , " p0" }, {3 , " new" , " p0" }, {5 , " new" , " p0" }};
13551349 ASSERT_OK_AND_ASSIGN (rows_before_prepare, ReadRows (realtime_context));
1356- std::sort (rows_before_prepare.begin (), rows_before_prepare.end ());
13571350 ASSERT_EQ (expected, rows_before_prepare);
13581351 ASSERT_OK_AND_ASSIGN (progress, writer->PrepareCommitWithProgress (/* commit_identifier=*/ 1 ));
13591352 ASSERT_EQ (1 , progress.size ());
@@ -1364,19 +1357,15 @@ TEST_F(RealtimeWriteInteTest, TestRealtimeDeduplicateRollingRestoresEveryOffsetS
13641357 ASSERT_TRUE (progress[0 ].deleted_offsets ->Contains (offset));
13651358 }
13661359 ASSERT_OK_AND_ASSIGN (rows_after_prepare, ReadRows (realtime_context));
1367- std::sort (rows_after_prepare.begin (), rows_after_prepare.end ());
13681360 ASSERT_EQ (expected, rows_after_prepare);
13691361 ASSERT_OK_AND_ASSIGN (snapshot_id, Commit (progress, /* commit_identifier=*/ 1 ));
13701362 ASSERT_OK_AND_ASSIGN (rows_before_refresh, ReadRows (realtime_context));
1371- std::sort (rows_before_refresh.begin (), rows_before_refresh.end ());
13721363 ASSERT_EQ (expected, rows_before_refresh);
13731364 ASSERT_OK (writer->RefreshCommittedSnapshot (snapshot_id));
13741365 ASSERT_OK_AND_ASSIGN (rows_after_refresh, ReadRows (realtime_context));
1375- std::sort (rows_after_refresh.begin (), rows_after_refresh.end ());
13761366 ASSERT_EQ (expected, rows_after_refresh);
13771367 ASSERT_OK (writer->Close ());
13781368 ASSERT_OK_AND_ASSIGN (std::vector<Row> rows, ReadRows ());
1379- std::sort (rows.begin (), rows.end ());
13801369 ASSERT_EQ (expected, rows);
13811370}
13821371
0 commit comments