Skip to content

Commit 5eefab6

Browse files
committed
fix(test): resolve file index search CI failures
1 parent d103f55 commit 5eefab6

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

‎src/paimon/common/io/byte_array_output_stream_test.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ TEST(ByteArrayOutputStreamTest, TestWriteAndFinish) {
5050
ASSERT_NOK_WITH_MSG(stream->Finish(pool.get()), "already been finished");
5151
stream.reset();
5252
ASSERT_EQ("abcdef", std::string(result->data(), result->size()));
53-
ASSERT_EQ(6, pool->CurrentUsage());
53+
ASSERT_EQ(result->size() + sizeof(Bytes), pool->CurrentUsage());
5454
result.reset();
5555
ASSERT_EQ(0, pool->CurrentUsage());
5656
}

‎src/paimon/common/reader/complete_index_score_batch_reader_test.cpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,6 @@ TEST_F(CompleteIndexScoreBatchReaderTest, TestFileReaderForwardsOperationsAndRes
174174
auto reader = std::make_unique<CompleteIndexScoreFileBatchReader>(
175175
std::move(inner_reader), std::vector<float>{1.25f, 2.5f}, GetArrowPool(GetDefaultPool()));
176176

177-
ASSERT_OK_AND_ASSIGN(std::unique_ptr<::ArrowSchema> file_schema, reader->GetFileSchema());
178-
EXPECT_TRUE(file_schema);
179177
ASSERT_OK_AND_ASSIGN(uint64_t row_count, reader->GetNumberOfRows());
180178
EXPECT_EQ(2, row_count);
181179
EXPECT_FALSE(reader->SupportPreciseBitmapSelection());

‎src/paimon/core/operation/raw_file_split_read_test.cpp‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include <vector>
2727

2828
#include "arrow/api.h"
29+
#include "arrow/c/bridge.h"
2930
#include "arrow/ipc/json_simple.h"
3031
#include "gtest/gtest.h"
3132
#include "paimon/common/data/binary_row.h"
@@ -34,6 +35,7 @@
3435
#include "paimon/common/reader/concat_batch_reader.h"
3536
#include "paimon/common/types/data_field.h"
3637
#include "paimon/common/utils/arrow/mem_utils.h"
38+
#include "paimon/common/utils/arrow/status_utils.h"
3739
#include "paimon/core/core_options.h"
3840
#include "paimon/core/deletionvectors/bitmap_deletion_vector.h"
3941
#include "paimon/core/global_index/indexed_split_impl.h"
@@ -95,8 +97,10 @@ class RawVectorSearchTestReader final : public FileIndexReader {
9597
class RawVectorSearchTestIndexer final : public FileIndexer {
9698
public:
9799
Result<std::shared_ptr<FileIndexReader>> CreateReader(
98-
::ArrowSchema*, int32_t, int32_t, const std::shared_ptr<InputStream>&,
100+
::ArrowSchema* arrow_schema, int32_t, int32_t, const std::shared_ptr<InputStream>&,
99101
const std::shared_ptr<MemoryPool>&) const override {
102+
PAIMON_ASSIGN_OR_RAISE_FROM_ARROW([[maybe_unused]] std::shared_ptr<arrow::Schema> schema,
103+
arrow::ImportSchema(arrow_schema));
100104
return std::make_shared<RawVectorSearchTestReader>();
101105
}
102106

@@ -141,8 +145,10 @@ class RawFullTextSearchTestReader final : public FileIndexReader {
141145
class RawFullTextSearchTestIndexer final : public FileIndexer {
142146
public:
143147
Result<std::shared_ptr<FileIndexReader>> CreateReader(
144-
::ArrowSchema*, int32_t, int32_t, const std::shared_ptr<InputStream>&,
148+
::ArrowSchema* arrow_schema, int32_t, int32_t, const std::shared_ptr<InputStream>&,
145149
const std::shared_ptr<MemoryPool>&) const override {
150+
PAIMON_ASSIGN_OR_RAISE_FROM_ARROW([[maybe_unused]] std::shared_ptr<arrow::Schema> schema,
151+
arrow::ImportSchema(arrow_schema));
146152
return std::make_shared<RawFullTextSearchTestReader>();
147153
}
148154

0 commit comments

Comments
 (0)