Skip to content

Commit 5c718d8

Browse files
committed
refactor: hide BlobDescriptor implementation constants
1 parent f403fd2 commit 5c718d8

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎include/paimon/data/blob_descriptor.h‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,6 @@ class PAIMON_EXPORT BlobDescriptor {
7979
: version_(version), uri_(uri), offset_(offset), length_(length) {}
8080

8181
private:
82-
static constexpr int64_t kMagic = 0x424C4F4244455343l;
83-
/// one byte for version, eight bytes for magic number.
84-
static constexpr uint64_t kMinDescriptorLength = 9;
8582
static constexpr int8_t kCurrentVersion = 2;
8683

8784
const int8_t version_ = kCurrentVersion;

‎src/paimon/common/data/blob_descriptor.cpp‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,13 @@
3131
#include "paimon/status.h"
3232

3333
namespace paimon {
34+
namespace {
35+
36+
constexpr int64_t kMagic = 0x424C4F4244455343l;
37+
// One byte for version, eight bytes for magic number.
38+
constexpr uint64_t kMinDescriptorLength = 9;
39+
40+
} // namespace
3441

3542
Result<std::unique_ptr<BlobDescriptor>> BlobDescriptor::Create(const std::string& uri,
3643
int64_t offset, int64_t length) {

0 commit comments

Comments
 (0)