Address review comments on rename_view

- Add @OverRide to RestCatalog/SqlCatalog rename_view and restore it on
  BigQueryMetastoreCatalog.load_namespace_properties
- Split identifiers once in RestCatalog.rename_view
- Fix "fully classified" typo in the Catalog.rename_view docstring
- Add a cross-namespace rename integration test
- Drop a stale skip on test_rest_custom_namespace_separator reintroduced by rebase

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: 2 people

pyiceberg/catalog/__init__.py

@@ -746,7 +746,7 @@ def create_view(
 
     @abstractmethod
     def rename_view(self, from_identifier: str | Identifier, to_identifier: str | Identifier) -> None:
-        """Rename a fully classified view name.
+        """Rename a fully qualified view name.
 
         Args:
             from_identifier (str | Identifier): Existing view identifier.

pyiceberg/catalog/bigquery_metastore.py

@@ -337,6 +337,7 @@ def load_view(self, identifier: str | Identifier) -> View:
     def rename_view(self, from_identifier: str | Identifier, to_identifier: str | Identifier) -> None:
         raise NotImplementedError
 
+    @override
     def load_namespace_properties(self, namespace: str | Identifier) -> Properties:
         dataset_name = self.identifier_to_database(namespace, NoSuchNamespaceError)
 

pyiceberg/catalog/rest/__init__.py

@@ -1859,23 +1859,23 @@ def drop_view(self, identifier: str | Identifier) -> None:
         except HTTPError as exc:
             _handle_non_200_response(exc, {404: NoSuchViewError})
 
+    @override
     @retry(**_RETRY_ARGS)
     def rename_view(self, from_identifier: str | Identifier, to_identifier: str | Identifier) -> None:
         self._check_endpoint(Capability.V1_RENAME_VIEW)
-        payload = {
-            "source": self._split_identifier_for_json(from_identifier),
-            "destination": self._split_identifier_for_json(to_identifier),
-        }
-
-        # Ensure source and destination namespaces exist before rename.
-        source_namespace = self._split_identifier_for_json(from_identifier)["namespace"]
-        dest_namespace = self._split_identifier_for_json(to_identifier)["namespace"]
+        source = self._split_identifier_for_json(from_identifier)
+        destination = self._split_identifier_for_json(to_identifier)
 
+        # Ensure that namespaces exist on source and destination.
+        source_namespace = source["namespace"]
         if not self.namespace_exists(source_namespace):
             raise NoSuchNamespaceError(f"Source namespace does not exist: {source_namespace}")
-        if not self.namespace_exists(dest_namespace):
-            raise NoSuchNamespaceError(f"Destination namespace does not exist: {dest_namespace}")
 
+        destination_namespace = destination["namespace"]
+        if not self.namespace_exists(destination_namespace):
+            raise NoSuchNamespaceError(f"Destination namespace does not exist: {destination_namespace}")
+
+        payload = {"source": source, "destination": destination}
         response = self._session.post(self.url(Endpoints.rename_view), json=payload)
         try:
             response.raise_for_status()

pyiceberg/catalog/sql.py

@@ -848,5 +848,6 @@ def close(self) -> None:
         if hasattr(self, "engine"):
             self.engine.dispose()
 
+    @override
     def rename_view(self, from_identifier: str | Identifier, to_identifier: str | Identifier) -> None:
         raise NotImplementedError

tests/integration/test_catalog.py

@@ -786,7 +786,27 @@ def test_rest_rename_view(
 
 
 @pytest.mark.integration
-@pytest.mark.skip(reason="Requires Iceberg REST Fixtures 1.11.x")
+def test_rest_rename_view_across_namespaces(
+    rest_catalog: RestCatalog, example_view_metadata_v1: dict[str, Any], database_name: str, view_name: str
+) -> None:
+    to_database_name = f"{database_name}_renamed"
+    from_identifier = (database_name, view_name)
+    to_identifier = (to_database_name, view_name)
+
+    rest_catalog.create_namespace_if_not_exists(database_name)
+    rest_catalog.create_namespace_if_not_exists(to_database_name)
+    view = View(from_identifier, ViewMetadata.model_validate(example_view_metadata_v1))
+
+    rest_catalog.create_view(from_identifier, view.schema(), view.current_version())
+    assert rest_catalog.view_exists(from_identifier)
+
+    rest_catalog.rename_view(from_identifier, to_identifier)
+
+    assert not rest_catalog.view_exists(from_identifier)
+    assert rest_catalog.view_exists(to_identifier)
+
+
+@pytest.mark.integration
 def test_rest_custom_namespace_separator(rest_catalog: RestCatalog, table_schema_simple: Schema) -> None:
     """
     Tests that the REST catalog correctly picks up the namespace-separator from the config endpoint.